DPDK patches and discussions
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: john.mcnamara@intel.com, marko.kovacevic@intel.com, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] doc/devbind: remove references to igb_uio
Date: Mon, 7 Sep 2020 10:08:16 +0100	[thread overview]
Message-ID: <20200907090816.GF312@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <20200906033846.24686-1-stephen@networkplumber.org>

On Sat, Sep 05, 2020 at 08:38:46PM -0700, Stephen Hemminger wrote:
> We should be encouraging the use of vfio_pci for developers, not telling
> them to use igb_uio.
> 
> Also fix typo where .py suffix is visible in document.
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
>  doc/guides/tools/devbind.rst | 20 ++++++++++----------
>  1 file changed, 10 insertions(+), 10 deletions(-)
> 
> diff --git a/doc/guides/tools/devbind.rst b/doc/guides/tools/devbind.rst
> index a2910e103aab..52690f018648 100644
> --- a/doc/guides/tools/devbind.rst
> +++ b/doc/guides/tools/devbind.rst
> @@ -30,11 +30,11 @@ OPTIONS
>          Print the current status of all known network interfaces.
>          For each device, it displays the PCI domain, bus, slot and function,
>          along with a text description of the device. Depending upon whether the
> -        device is being used by a kernel driver, the ``igb_uio`` driver, or no
> +        device is being used by a kernel driver, the ``vfio_pci`` driver, or no
>          driver, other relevant information will be displayed:
>          - the Linux interface name e.g. ``if=eth0``
> -        - the driver being used e.g. ``drv=igb_uio``
> -        - any suitable drivers not currently using that device e.g. ``unused=igb_uio``
> +        - the driver being used e.g. ``drv=vfio_pci``
> +        - any suitable drivers not currently using that device e.g. ``unused=vfio_pci``
>          NOTE: if this flag is passed along with a bind/unbind option, the
>          status display will always occur after the other operations have taken
>          place.
> @@ -69,7 +69,7 @@ OPTIONS
>  
>  .. warning::
>  
> -    While any user can run the ``dpdk-devbind.py`` script to view the status of the network ports,
> +    While any user can run the ``dpdk-devbind`` script to view the status of the network ports,
>      binding or unbinding network ports requires root privileges.

Agree with all the replacements of igb_uio with vfio, but why remove the
.py suffix here? The script won't run without giving its full name, so this
removal seems unhelpful to the user.

  reply	other threads:[~2020-09-07  9:08 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-06  3:38 Stephen Hemminger
2020-09-07  9:08 ` Bruce Richardson [this message]
2020-09-07 17:22   ` Stephen Hemminger
2020-09-24 17:53 ` [dpdk-dev] [PATCH v2] " Stephen Hemminger
2020-10-14 16:43   ` Ferruh Yigit
2020-11-26 11:48     ` Bruce Richardson
2020-11-26 16:00       ` David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200907090816.GF312@bricha3-MOBL.ger.corp.intel.com \
    --to=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=john.mcnamara@intel.com \
    --cc=marko.kovacevic@intel.com \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).