From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id EB788A04B9; Mon, 7 Sep 2020 11:08:24 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 122D21BE85; Mon, 7 Sep 2020 11:08:24 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 6350929AC for ; Mon, 7 Sep 2020 11:08:22 +0200 (CEST) IronPort-SDR: d9/vuDayorOgzIc/syDNEjFpIcRkNCgYANyF/sJrpeeY0R8/NtuvXaZOcDrPUZ7MCA/6CQxD5g sv4N6uSdjzww== X-IronPort-AV: E=McAfee;i="6000,8403,9736"; a="222185930" X-IronPort-AV: E=Sophos;i="5.76,401,1592895600"; d="scan'208";a="222185930" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Sep 2020 02:08:21 -0700 IronPort-SDR: yUkuGHBKQ2yLVLB/jVk2hGNtplEi9qnQDMFABzK2e4LntNxzSXndEhwRi79oH9Lu4J9cG5q8nR 0Px7oQloxvkA== X-IronPort-AV: E=Sophos;i="5.76,401,1592895600"; d="scan'208";a="479576654" Received: from bricha3-mobl.ger.corp.intel.com ([10.251.80.24]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 07 Sep 2020 02:08:19 -0700 Date: Mon, 7 Sep 2020 10:08:16 +0100 From: Bruce Richardson To: Stephen Hemminger Cc: john.mcnamara@intel.com, marko.kovacevic@intel.com, dev@dpdk.org Message-ID: <20200907090816.GF312@bricha3-MOBL.ger.corp.intel.com> References: <20200906033846.24686-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200906033846.24686-1-stephen@networkplumber.org> Subject: Re: [dpdk-dev] [PATCH] doc/devbind: remove references to igb_uio X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Sat, Sep 05, 2020 at 08:38:46PM -0700, Stephen Hemminger wrote: > We should be encouraging the use of vfio_pci for developers, not telling > them to use igb_uio. > > Also fix typo where .py suffix is visible in document. > > Signed-off-by: Stephen Hemminger > --- > doc/guides/tools/devbind.rst | 20 ++++++++++---------- > 1 file changed, 10 insertions(+), 10 deletions(-) > > diff --git a/doc/guides/tools/devbind.rst b/doc/guides/tools/devbind.rst > index a2910e103aab..52690f018648 100644 > --- a/doc/guides/tools/devbind.rst > +++ b/doc/guides/tools/devbind.rst > @@ -30,11 +30,11 @@ OPTIONS > Print the current status of all known network interfaces. > For each device, it displays the PCI domain, bus, slot and function, > along with a text description of the device. Depending upon whether the > - device is being used by a kernel driver, the ``igb_uio`` driver, or no > + device is being used by a kernel driver, the ``vfio_pci`` driver, or no > driver, other relevant information will be displayed: > - the Linux interface name e.g. ``if=eth0`` > - - the driver being used e.g. ``drv=igb_uio`` > - - any suitable drivers not currently using that device e.g. ``unused=igb_uio`` > + - the driver being used e.g. ``drv=vfio_pci`` > + - any suitable drivers not currently using that device e.g. ``unused=vfio_pci`` > NOTE: if this flag is passed along with a bind/unbind option, the > status display will always occur after the other operations have taken > place. > @@ -69,7 +69,7 @@ OPTIONS > > .. warning:: > > - While any user can run the ``dpdk-devbind.py`` script to view the status of the network ports, > + While any user can run the ``dpdk-devbind`` script to view the status of the network ports, > binding or unbinding network ports requires root privileges. Agree with all the replacements of igb_uio with vfio, but why remove the .py suffix here? The script won't run without giving its full name, so this removal seems unhelpful to the user.