From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1AD8CA04B1; Mon, 7 Sep 2020 19:20:24 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 68A6D1B9B7; Mon, 7 Sep 2020 19:20:23 +0200 (CEST) Received: from mail-pg1-f196.google.com (mail-pg1-f196.google.com [209.85.215.196]) by dpdk.org (Postfix) with ESMTP id 8CC18255 for ; Mon, 7 Sep 2020 19:20:22 +0200 (CEST) Received: by mail-pg1-f196.google.com with SMTP id g29so8298178pgl.2 for ; Mon, 07 Sep 2020 10:20:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ix9HBRBZXEbsUDKL3tyO26tGz6g1bzHNiRlouC+mM6w=; b=OkBa0HYQUNq45IfaR5E28/hgUg5YxID1+lAcMGrXn14cpA2fwClz9I0HnEXkMuxehI v2KbVsUFVOU4SJ/p+9jETvvsSiY7WnbQ4tYlElHYDxitsg/uycB3x8GqKxiwnOvWTtq5 640Cun47GXkJlgSQbsB2NEuChLcU1Pm96OlhMCVbRPTfu9T81Fe3awJxqR5KlE6jm0xN 1lovNX/T0rawCjtetjq35qcuT7eSKn1xWKUmtugUgV9EjRHMO/IHy9h/S4xFUz6c3nGe D2876eGvHuqvdET6RjavDelJU8g+pC4tfg2ZOPnoW4OoMajgTfbjreYlpMul7z3tnjSD 74cw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ix9HBRBZXEbsUDKL3tyO26tGz6g1bzHNiRlouC+mM6w=; b=Y00S4dacn5WNxaSXgHSDd2SthQzc/f0Y28OwqRaxfazrjNK+Fj+IBFALXwk2vylm9D 4KQ8+SdAWd5o/6VD/7m1n5Vxfd/m8dfWrIw1Il8RMcE0P9MqrOWkFNV+mvZssnmqScDy 8tUzFpErW9O2bTNAgn4ObVMO/C/ABjXEmPx+Sc28z6fgRXglfbgJbSQwz3v8DkBtMauJ bZipaXvfRKJ1ebzXxap0+213PfDLYCEwNoN0+xc8i2J1aStBpW8zwRTx0CkoxCsZVHwl 5gwvkQEqWZ5zRWVmBB+/H4wnpT8N2x8OJuHXHEF5fLiDv4Kp5LkbK0LGw1lKwquPGbyD J13w== X-Gm-Message-State: AOAM531DceSwgZ/knK4oFsH32dBgRpT+6EyhxVAWlMjye8V+kLEqXOXu 3WbUlaFFlb+Qo8eLL5VzCNBtgg== X-Google-Smtp-Source: ABdhPJyOm4C6+uscSU9ScF+z+qdOF7B+n2b2X2yImAtoM8AwugfgUBUTFmrNs/hRfFPJvSb2LkP6AA== X-Received: by 2002:a63:5e43:: with SMTP id s64mr17568336pgb.313.1599499221599; Mon, 07 Sep 2020 10:20:21 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id d1sm12876147pjs.17.2020.09.07.10.20.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Sep 2020 10:20:20 -0700 (PDT) Date: Mon, 7 Sep 2020 10:20:13 -0700 From: Stephen Hemminger To: Bruce Richardson Cc: Ferruh Yigit , dev@dpdk.org Message-ID: <20200907102013.71343968@hermes.lan> In-Reply-To: <20200907085827.GC312@bricha3-MOBL.ger.corp.intel.com> References: <20200901165643.15668-1-stephen@networkplumber.org> <20200906034247.25111-1-stephen@networkplumber.org> <20200907085827.GC312@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v5] usertools: add huge page setup script X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, 7 Sep 2020 09:58:27 +0100 Bruce Richardson wrote: > On Mon, Sep 07, 2020 at 09:54:29AM +0100, Ferruh Yigit wrote: > > On 9/6/2020 4:42 AM, Stephen Hemminger wrote: > > > This is an improved version of the setup of huge pages > > > bases on earlier DPDK setup. Differences are: > > > * it autodetects NUMA vs non NUMA > > > * it allows setting different page sizes > > > recent kernels support multiple sizes. > > > * it accepts a parameter in bytes (not pages). > > > > > > If necessary the steps of clearing old settings and mounting/umounting > > > can be done individually. > > > > > > Signed-off-by: Stephen Hemminger > > > > <...> > > > > > @@ -1,4 +1,9 @@ > > > # SPDX-License-Identifier: BSD-3-Clause > > > # Copyright(c) 2017 Intel Corporation > > > > > > -install_data(['dpdk-devbind.py', 'dpdk-pmdinfo.py', 'dpdk-telemetry.py'], install_dir: 'bin') > > > +install_data([ > > > + 'dpdk-devbind.py', > > > + 'dpdk-pmdinfo.py', > > > + 'dpdk-telemetry.py', > > > + 'hugepage_setup.py' > > > +],install_dir: 'bin') > > > > > > > Should script name has 'dpdk-' prefix as others do? > > +1 to that. Ok but - in the name violates Python lint naming for modules. The standard is underscore.