From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0E3AEA04AA; Tue, 8 Sep 2020 16:58:15 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 879924C99; Tue, 8 Sep 2020 16:58:14 +0200 (CEST) Received: from mail-pg1-f194.google.com (mail-pg1-f194.google.com [209.85.215.194]) by dpdk.org (Postfix) with ESMTP id 1CF9ADE0 for ; Tue, 8 Sep 2020 16:58:13 +0200 (CEST) Received: by mail-pg1-f194.google.com with SMTP id m8so4927365pgi.3 for ; Tue, 08 Sep 2020 07:58:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Bbg8rbrO3LRsdcG0ze3KHf52mZ5q7cL2e6TrOKJv1uE=; b=Fo9qfWFQoQZJg+W5CILjKN7Cy23UQ0oiOwraUGLCQ0/G5EBTSRFxX44mZBXMgLMXdm xH4Nk+PU9PgYkdR+uXOm5VQY877L9i6Vx3rR7UN08Op0v7Par1Uhz7c0AE8x5vE+Gaet TeYwG3IsnqFR1cJgyT+GRBbKJwzJSCCjwBmYPUvxMhG8QLHtcsncJT8U5Dfe/FEHyVa+ IbMu8bRzqd3pKyJQhCotAx2GaDpL6snX2CTAtXfNUkMoZqFQvi2YXa12Wy9X39U9djyq 8ExKNLzW0dB/eR31ADDaRi0lpXuh/6pjUcAQpY6mQ1nKak0MY5983OxFbkmHoks3AJY1 Znwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Bbg8rbrO3LRsdcG0ze3KHf52mZ5q7cL2e6TrOKJv1uE=; b=JRHP79tbG8du3QGGqQ3UNdoP4UHU0avu3Tan5N8wgGtwN9ylnELHWC2a6QpIRZFzWl ZBJU3MxYTgRrDF1RFiHo0hViUR9LH7xX8iK2VS8uVSz1D6hOUrkPa415UZL5wthkZjWa 2gJDZj6HdFMzuROyf/fSIvSkBGJUqaW1+tGvbQBKAV4i5jHYpC12XrPF/ofv7eJli1jW adpWBtZ/5M3saHWgu/2tCL+/faT198tumQZMsJj5+MfnklK788xhUadso/6tbGy8VpQz 2BYiS0Rut6pYJe2TgXDuRxKH5C7mlE1s1+HmyKPcZLyojCjYUmPG2IWy1VjKiJVMc8B2 Tavg== X-Gm-Message-State: AOAM533RZXmn/RxJ5/uHQB0liPjsGHtkdLj5CxOPNPjZvIMJDixWwLqD EBWi5N+DBoZ3fWAajflFHJdPQg== X-Google-Smtp-Source: ABdhPJweIYLeG7PFIkPpW4XFI2zu2oa4dE0cfGgWf6DFplJRBIDNqmDSGw9ywZvfp96gFZhp3PaJdg== X-Received: by 2002:a63:c705:: with SMTP id n5mr20061590pgg.19.1599577092278; Tue, 08 Sep 2020 07:58:12 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id l24sm18428325pff.20.2020.09.08.07.58.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Sep 2020 07:58:12 -0700 (PDT) Date: Tue, 8 Sep 2020 07:58:03 -0700 From: Stephen Hemminger To: Bruce Richardson Cc: Ferruh Yigit , dev@dpdk.org Message-ID: <20200908075803.18b7835d@hermes.lan> In-Reply-To: <20200908081808.GB351@bricha3-MOBL.ger.corp.intel.com> References: <20200901165643.15668-1-stephen@networkplumber.org> <20200906034247.25111-1-stephen@networkplumber.org> <20200907085827.GC312@bricha3-MOBL.ger.corp.intel.com> <20200907102013.71343968@hermes.lan> <20200908081808.GB351@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v5] usertools: add huge page setup script X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, 8 Sep 2020 09:18:08 +0100 Bruce Richardson wrote: > On Mon, Sep 07, 2020 at 10:20:13AM -0700, Stephen Hemminger wrote: > > On Mon, 7 Sep 2020 09:58:27 +0100 > > Bruce Richardson wrote: > > > > > On Mon, Sep 07, 2020 at 09:54:29AM +0100, Ferruh Yigit wrote: > > > > On 9/6/2020 4:42 AM, Stephen Hemminger wrote: > > > > > This is an improved version of the setup of huge pages > > > > > bases on earlier DPDK setup. Differences are: > > > > > * it autodetects NUMA vs non NUMA > > > > > * it allows setting different page sizes > > > > > recent kernels support multiple sizes. > > > > > * it accepts a parameter in bytes (not pages). > > > > > > > > > > If necessary the steps of clearing old settings and mounting/umounting > > > > > can be done individually. > > > > > > > > > > Signed-off-by: Stephen Hemminger > > > > > > > > <...> > > > > > > > > > @@ -1,4 +1,9 @@ > > > > > # SPDX-License-Identifier: BSD-3-Clause > > > > > # Copyright(c) 2017 Intel Corporation > > > > > > > > > > -install_data(['dpdk-devbind.py', 'dpdk-pmdinfo.py', 'dpdk-telemetry.py'], install_dir: 'bin') > > > > > +install_data([ > > > > > + 'dpdk-devbind.py', > > > > > + 'dpdk-pmdinfo.py', > > > > > + 'dpdk-telemetry.py', > > > > > + 'hugepage_setup.py' > > > > > +],install_dir: 'bin') > > > > > > > > > > > > > Should script name has 'dpdk-' prefix as others do? > > > > > > +1 to that. > > > > Ok but - in the name violates Python lint naming for modules. > > The standard is underscore. > > We don't really need 100% lint cleanliness for all our scripts, 95% is > surely enough. However, if you feel strongly, then I suggest we prefix all > our python scripts with "dpdk_", rather than "dpdk-" Agree. Just wanted to raise the observation. Maybe add a .pylintrc to usertools to suppress this warning.