From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C6175A04AA; Tue, 8 Sep 2020 11:34:37 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 55E771BF7E; Tue, 8 Sep 2020 11:34:37 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id B82361BEAC for ; Tue, 8 Sep 2020 11:34:35 +0200 (CEST) IronPort-SDR: 6NGfgtmcUnL78yxmTOea3KA1upJmWQHkbMHf61qxTyBwVrQeYW+FoVxcn9oIhtNfsYCIaBQzPz iYdMgRThJbuA== X-IronPort-AV: E=McAfee;i="6000,8403,9737"; a="145822758" X-IronPort-AV: E=Sophos;i="5.76,405,1592895600"; d="scan'208";a="145822758" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Sep 2020 02:34:34 -0700 IronPort-SDR: iOlP8qZSMlsCDlbL9GQH4Any9tuOhVJN1vFperRu3i9/VV0PD4MF7SXGSIh8nCHNYgbt9M4jr1 FIsqwK7A9zLg== X-IronPort-AV: E=Sophos;i="5.76,405,1592895600"; d="scan'208";a="479949866" Received: from bricha3-mobl.ger.corp.intel.com ([10.251.81.164]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 08 Sep 2020 02:34:33 -0700 Date: Tue, 8 Sep 2020 10:34:30 +0100 From: Bruce Richardson To: Thomas Monjalon Cc: dev@dpdk.org, david.marchand@redhat.com, ferruh.yigit@intel.com, jerinj@marvell.com, stephen@networkplumber.org Message-ID: <20200908093430.GD351@bricha3-MOBL.ger.corp.intel.com> References: <20200907225049.547832-1-thomas@monjalon.net> <20200908082557.GC351@bricha3-MOBL.ger.corp.intel.com> <2557168.Xcie88ISVP@thomas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2557168.Xcie88ISVP@thomas> Subject: Re: [dpdk-dev] [PATCH] kernel: remove igb_uio X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Sep 08, 2020 at 11:27:23AM +0200, Thomas Monjalon wrote: > 08/09/2020 10:25, Bruce Richardson: > > On Tue, Sep 08, 2020 at 02:14:02AM +0200, Thomas Monjalon wrote: > > > On Tue Sep 8, 2020 at 2:50 AM CEST, Thomas Monjalon wrote: > > > > As decided in the Technical Board in November 2019, > > > > the kernel module igb_uio is moved to the dpdk-kmods repository > > > > in the /linux/igb_uio/ directory. > > > > > > The code is moved with its git history in > > > http://git.dpdk.org/dpdk-kmods/ > > > > > > The move process started with these commands: > > > cd dpdk > > > dir=igb_uio > > > path1=lib/librte_eal/linuxapp/$dir > > > path2=kernel/linux/$dir > > > git format-patch -o $dir 0c9a540ed2.. -- $path1 $path2 > > > find $dir -type f -exec sed -i "s,$path1\|$path2,linux/$dir," '{}' \; > > > cd ../dpdk-kmods > > > git am ../dpdk/$dir/* > > > git filter-branch --force > > > --index-filter "git rm --cached --ignore-unmatch linux/$dir/Makefile" > > > --prune-empty --tag-name-filter cat -- --all > > > > > > Makefile and meson.build files were not imported at all. > > > Some other commits were skipped (virtio, vmxnet3 and Xen dom0 support), > > > because they were not very useful and reverted later in the history. > > > Anyway the original history is available forever in dpdk.git. > > > > > > Currently it cannot compile because the file rte_pci_dev_feature_defs.h > > > is missing, defining enum rte_intr_mode. An option is to import this file. > > > > > > It would be nice to add a README file in the new igb_uio directory. > > > Volunteers welcome :) > > > > In terms of building the module, one option which I think is worth > > considering is to try and use meson subject/wrap support to download and > > build this module as part of the main DPDK build, as now, when enable_kmods > > option is set. With a wrap file in DPDK it can automatically pull down and > > build the code as part of a main project build. I assume that integration > > into main DPDK build is still something worth having? The only thing I > > don't like about using a wrap file is that it has to be placed in a folder > > called "subproject" at the top level of the DPDK project. > > The idea is encouraging the use of VFIO and make igb_uio deprecated. > I think we should not do any effort to ease igb_uio usage inside dpdk.git. > Compiling the kernel module standalone in dpdk-kmods.git looks enough, isn't it? > Ok, that is fine if that is the objective. I thought the objective was to move all kernel modules out of the DPDK tree, but if it's only certain modules, then that is different. /Bruce