DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [RFC] app/testpmd: distinguish ICMP identifier fields in packet
@ 2020-09-08 10:06 lizh
  2020-09-08 12:56 ` Thomas Monjalon
                   ` (2 more replies)
  0 siblings, 3 replies; 9+ messages in thread
From: lizh @ 2020-09-08 10:06 UTC (permalink / raw)
  To: dekelp, orika, viacheslavo, matan; +Cc: dev, thomas, rasland

Ability to distinguish ICMP identifier fields in packets.
Dstinguish ICMP sequence number field too.
Already supports ICMP code and type fields in current version.
Existing fields in ICMP header contain the required information.
ICMP header already is supported and no code change in RTE FLOW.
Extend testpmd CLI to include the fields of ident and sequence number.
One example:
flow create 0 ingress pattern eth / ipv4 /
 icmp code is 1 ident is 5 seq is 6 /
 end actions count / queue index 0 / end
The ICMP packet with code 1, identifier 5 and
sequence number 6 will be matched.
It will implement action counter and forward to queue 0.

Signed-off-by: lizh <lizh@nvidia.com>
---
 app/test-pmd/cmdline_flow.c | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
index 6263d307ed..6e04d538ea 100644
--- a/app/test-pmd/cmdline_flow.c
+++ b/app/test-pmd/cmdline_flow.c
@@ -143,6 +143,8 @@ enum index {
 	ITEM_ICMP,
 	ITEM_ICMP_TYPE,
 	ITEM_ICMP_CODE,
+	ITEM_ICMP_IDENT,
+	ITEM_ICMP_SEQ,
 	ITEM_UDP,
 	ITEM_UDP_SRC,
 	ITEM_UDP_DST,
@@ -893,6 +895,8 @@ static const enum index item_ipv6[] = {
 static const enum index item_icmp[] = {
 	ITEM_ICMP_TYPE,
 	ITEM_ICMP_CODE,
+	ITEM_ICMP_IDENT,
+	ITEM_ICMP_SEQ,
 	ITEM_NEXT,
 	ZERO,
 };
@@ -2193,6 +2197,20 @@ static const struct token token_list[] = {
 		.args = ARGS(ARGS_ENTRY_HTON(struct rte_flow_item_icmp,
 					     hdr.icmp_code)),
 	},
+	[ITEM_ICMP_IDENT] = {
+		.name = "ident",
+		.help = "ICMP packet identifier",
+		.next = NEXT(item_icmp, NEXT_ENTRY(UNSIGNED), item_param),
+		.args = ARGS(ARGS_ENTRY_HTON(struct rte_flow_item_icmp,
+					     hdr.icmp_ident)),
+	},
+	[ITEM_ICMP_SEQ] = {
+		.name = "seq",
+		.help = "ICMP packet sequence number",
+		.next = NEXT(item_icmp, NEXT_ENTRY(UNSIGNED), item_param),
+		.args = ARGS(ARGS_ENTRY_HTON(struct rte_flow_item_icmp,
+					     hdr.icmp_seq_nb)),
+	},
 	[ITEM_UDP] = {
 		.name = "udp",
 		.help = "match UDP header",
-- 
2.21.0


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [dpdk-dev] [RFC] app/testpmd: distinguish ICMP identifier fields in packet
  2020-09-08 10:06 [dpdk-dev] [RFC] app/testpmd: distinguish ICMP identifier fields in packet lizh
@ 2020-09-08 12:56 ` Thomas Monjalon
  2020-09-09  3:41   ` Li Zhang
  2020-09-09  3:34 ` [dpdk-dev] [RFC v2 1/1] " Li Zhang
  2020-09-09  3:49 ` Li Zhang
  2 siblings, 1 reply; 9+ messages in thread
From: Thomas Monjalon @ 2020-09-08 12:56 UTC (permalink / raw)
  To: lizh; +Cc: dekelp, orika, viacheslavo, matan, dev, rasland

Hi,

lizh <lizh@nvidia.com> wrote:
> Ability to distinguish ICMP identifier fields in packets.
> Dstinguish ICMP sequence number field too.
> Already supports ICMP code and type fields in current version.
> Existing fields in ICMP header contain the required information.
> ICMP header already is supported and no code change in RTE FLOW.
> Extend testpmd CLI to include the fields of ident and sequence number.
> One example:
> flow create 0 ingress pattern eth / ipv4 /
> 
>  icmp code is 1 ident is 5 seq is 6 /
>  end actions count / queue index 0 / end
> 
> The ICMP packet with code 1, identifier 5 and
> sequence number 6 will be matched.
> It will implement action counter and forward to queue 0.
> 
> Signed-o\0ff-by: lizh <lizh@nvidia.com>

Please configure your git environment so that your full name
is filled. Then redo the Signed-off so that it appears as:
	Li Zhang <lizh@nvidia.com>

As you are new to DPDK, I suggest reading the guidelines for contributing:
	https://core.dpdk.org/contribute/#send

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [dpdk-dev] [RFC v2 1/1] app/testpmd: distinguish ICMP identifier fields in packet
  2020-09-08 10:06 [dpdk-dev] [RFC] app/testpmd: distinguish ICMP identifier fields in packet lizh
  2020-09-08 12:56 ` Thomas Monjalon
@ 2020-09-09  3:34 ` Li Zhang
  2020-09-22 15:38   ` Ferruh Yigit
  2020-09-23  9:04   ` Ferruh Yigit
  2020-09-09  3:49 ` Li Zhang
  2 siblings, 2 replies; 9+ messages in thread
From: Li Zhang @ 2020-09-09  3:34 UTC (permalink / raw)
  To: dekelp, orika, viacheslavo, matan; +Cc: dev, thomas, rasland, lizh

From: lizh <lizh@nvidia.com>

Ability to distinguish ICMP identifier fields in packets.
Dstinguish ICMP sequence number field too.
Already supports ICMP code and type fields in current version.
Existing fields in ICMP header contain the required information.
ICMP header already is supported and no code change in RTE FLOW.
Extend testpmd CLI to include the fields of ident and sequence number.
One example:
flow create 0 ingress pattern eth / ipv4 /
 icmp code is 1 ident is 5 seq is 6 /
 end actions count / queue index 0 / end
The ICMP packet with code 1, identifier 5 and
sequence number 6 will be matched.
It will implement action counter and forward to queue 0.

Signed-off-by: Li Zhang <lizh@nvidia.com>
---
 app/test-pmd/cmdline_flow.c | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
index 6263d307ed..6e04d538ea 100644
--- a/app/test-pmd/cmdline_flow.c
+++ b/app/test-pmd/cmdline_flow.c
@@ -143,6 +143,8 @@ enum index {
 	ITEM_ICMP,
 	ITEM_ICMP_TYPE,
 	ITEM_ICMP_CODE,
+	ITEM_ICMP_IDENT,
+	ITEM_ICMP_SEQ,
 	ITEM_UDP,
 	ITEM_UDP_SRC,
 	ITEM_UDP_DST,
@@ -893,6 +895,8 @@ static const enum index item_ipv6[] = {
 static const enum index item_icmp[] = {
 	ITEM_ICMP_TYPE,
 	ITEM_ICMP_CODE,
+	ITEM_ICMP_IDENT,
+	ITEM_ICMP_SEQ,
 	ITEM_NEXT,
 	ZERO,
 };
@@ -2193,6 +2197,20 @@ static const struct token token_list[] = {
 		.args = ARGS(ARGS_ENTRY_HTON(struct rte_flow_item_icmp,
 					     hdr.icmp_code)),
 	},
+	[ITEM_ICMP_IDENT] = {
+		.name = "ident",
+		.help = "ICMP packet identifier",
+		.next = NEXT(item_icmp, NEXT_ENTRY(UNSIGNED), item_param),
+		.args = ARGS(ARGS_ENTRY_HTON(struct rte_flow_item_icmp,
+					     hdr.icmp_ident)),
+	},
+	[ITEM_ICMP_SEQ] = {
+		.name = "seq",
+		.help = "ICMP packet sequence number",
+		.next = NEXT(item_icmp, NEXT_ENTRY(UNSIGNED), item_param),
+		.args = ARGS(ARGS_ENTRY_HTON(struct rte_flow_item_icmp,
+					     hdr.icmp_seq_nb)),
+	},
 	[ITEM_UDP] = {
 		.name = "udp",
 		.help = "match UDP header",
-- 
2.21.0


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [dpdk-dev] [RFC] app/testpmd: distinguish ICMP identifier fields in packet
  2020-09-08 12:56 ` Thomas Monjalon
@ 2020-09-09  3:41   ` Li Zhang
  0 siblings, 0 replies; 9+ messages in thread
From: Li Zhang @ 2020-09-09  3:41 UTC (permalink / raw)
  To: NBU-Contact-Thomas Monjalon
  Cc: Dekel Peled, Ori Kam, Slava Ovsiienko, Matan Azrad, dev,
	Raslan Darawsheh, Jiawei(Jonny) Wang

Thanks! I update it now.

Regards,
Li Zhang

-----Original Message-----
From: Thomas Monjalon <thomas@monjalon.net> 
Sent: Tuesday, September 8, 2020 8:56 PM
To: Li Zhang <lizh@nvidia.com>
Cc: Dekel Peled <dekelp@nvidia.com>; Ori Kam <orika@nvidia.com>; Slava Ovsiienko <viacheslavo@nvidia.com>; Matan Azrad <matan@nvidia.com>; dev@dpdk.org; Raslan Darawsheh <rasland@nvidia.com>
Subject: Re: [RFC] app/testpmd: distinguish ICMP identifier fields in packet

External email: Use caution opening links or attachments


Hi,

lizh <lizh@nvidia.com> wrote:
> Ability to distinguish ICMP identifier fields in packets.
> Dstinguish ICMP sequence number field too.
> Already supports ICMP code and type fields in current version.
> Existing fields in ICMP header contain the required information.
> ICMP header already is supported and no code change in RTE FLOW.
> Extend testpmd CLI to include the fields of ident and sequence number.
> One example:
> flow create 0 ingress pattern eth / ipv4 /
>
>  icmp code is 1 ident is 5 seq is 6 /
>  end actions count / queue index 0 / end
>
> The ICMP packet with code 1, identifier 5 and sequence number 6 will 
> be matched.
> It will implement action counter and forward to queue 0.
>
> Signed-off-by: lizh <lizh@nvidia.com>

Please configure your git environment so that your full name is filled. Then redo the Signed-off so that it appears as:
        Li Zhang <lizh@nvidia.com>

As you are new to DPDK, I suggest reading the guidelines for contributing:
        https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fcore.dpdk.org%2Fcontribute%2F%23send&amp;data=02%7C01%7Clizh%40nvidia.com%7C4d1f647de21844be83a408d853f69ab5%7C43083d15727340c1b7db39efd9ccc17a%7C0%7C0%7C637351665917806609&amp;sdata=dPG6VLa5HejKvwcGlqGKtfLwl%2BNEiybFSc5RUmmJDps%3D&amp;reserved=0

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [dpdk-dev] [RFC v2 1/1] app/testpmd: distinguish ICMP identifier fields in packet
  2020-09-08 10:06 [dpdk-dev] [RFC] app/testpmd: distinguish ICMP identifier fields in packet lizh
  2020-09-08 12:56 ` Thomas Monjalon
  2020-09-09  3:34 ` [dpdk-dev] [RFC v2 1/1] " Li Zhang
@ 2020-09-09  3:49 ` Li Zhang
  2 siblings, 0 replies; 9+ messages in thread
From: Li Zhang @ 2020-09-09  3:49 UTC (permalink / raw)
  To: dekelp, orika, viacheslavo, matan; +Cc: dev, thomas, rasland

Ability to distinguish ICMP identifier fields in packets.
Dstinguish ICMP sequence number field too.
Already supports ICMP code and type fields in current version.
Existing fields in ICMP header contain the required information.
ICMP header already is supported and no code change in RTE FLOW.
Extend testpmd CLI to include the fields of ident and sequence number.
One example:
flow create 0 ingress pattern eth / ipv4 /
 icmp code is 1 ident is 5 seq is 6 /
 end actions count / queue index 0 / end
The ICMP packet with code 1, identifier 5 and
sequence number 6 will be matched.
It will implement action counter and forward to queue 0.

Signed-off-by: Li Zhang <lizh@nvidia.com>
---
 app/test-pmd/cmdline_flow.c | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
index 6263d307ed..6e04d538ea 100644
--- a/app/test-pmd/cmdline_flow.c
+++ b/app/test-pmd/cmdline_flow.c
@@ -143,6 +143,8 @@ enum index {
 	ITEM_ICMP,
 	ITEM_ICMP_TYPE,
 	ITEM_ICMP_CODE,
+	ITEM_ICMP_IDENT,
+	ITEM_ICMP_SEQ,
 	ITEM_UDP,
 	ITEM_UDP_SRC,
 	ITEM_UDP_DST,
@@ -893,6 +895,8 @@ static const enum index item_ipv6[] = {
 static const enum index item_icmp[] = {
 	ITEM_ICMP_TYPE,
 	ITEM_ICMP_CODE,
+	ITEM_ICMP_IDENT,
+	ITEM_ICMP_SEQ,
 	ITEM_NEXT,
 	ZERO,
 };
@@ -2193,6 +2197,20 @@ static const struct token token_list[] = {
 		.args = ARGS(ARGS_ENTRY_HTON(struct rte_flow_item_icmp,
 					     hdr.icmp_code)),
 	},
+	[ITEM_ICMP_IDENT] = {
+		.name = "ident",
+		.help = "ICMP packet identifier",
+		.next = NEXT(item_icmp, NEXT_ENTRY(UNSIGNED), item_param),
+		.args = ARGS(ARGS_ENTRY_HTON(struct rte_flow_item_icmp,
+					     hdr.icmp_ident)),
+	},
+	[ITEM_ICMP_SEQ] = {
+		.name = "seq",
+		.help = "ICMP packet sequence number",
+		.next = NEXT(item_icmp, NEXT_ENTRY(UNSIGNED), item_param),
+		.args = ARGS(ARGS_ENTRY_HTON(struct rte_flow_item_icmp,
+					     hdr.icmp_seq_nb)),
+	},
 	[ITEM_UDP] = {
 		.name = "udp",
 		.help = "match UDP header",
-- 
2.21.0


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [dpdk-dev] [RFC v2 1/1] app/testpmd: distinguish ICMP identifier fields in packet
  2020-09-09  3:34 ` [dpdk-dev] [RFC v2 1/1] " Li Zhang
@ 2020-09-22 15:38   ` Ferruh Yigit
  2020-09-23  2:39     ` Li Zhang
  2020-09-23  9:04   ` Ferruh Yigit
  1 sibling, 1 reply; 9+ messages in thread
From: Ferruh Yigit @ 2020-09-22 15:38 UTC (permalink / raw)
  To: Li Zhang, dekelp, orika, viacheslavo, matan; +Cc: dev, thomas, rasland

On 9/9/2020 4:34 AM, Li Zhang wrote:
> From: lizh <lizh@nvidia.com>
> 
> Ability to distinguish ICMP identifier fields in packets.
> Dstinguish ICMP sequence number field too.
> Already supports ICMP code and type fields in current version.
> Existing fields in ICMP header contain the required information.
> ICMP header already is supported and no code change in RTE FLOW.
> Extend testpmd CLI to include the fields of ident and sequence number.
> One example:
> flow create 0 ingress pattern eth / ipv4 /
>   icmp code is 1 ident is 5 seq is 6 /
>   end actions count / queue index 0 / end
> The ICMP packet with code 1, identifier 5 and
> sequence number 6 will be matched.
> It will implement action counter and forward to queue 0.
> 

Overall looks good. @Ori, any objection?

@Li, is there any PMD implementation planned to use these icmp fields?

> Signed-off-by: Li Zhang <lizh@nvidia.com>
> ---
>   app/test-pmd/cmdline_flow.c | 18 ++++++++++++++++++
>   1 file changed, 18 insertions(+)
> 
> diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
> index 6263d307ed..6e04d538ea 100644
> --- a/app/test-pmd/cmdline_flow.c
> +++ b/app/test-pmd/cmdline_flow.c
> @@ -143,6 +143,8 @@ enum index {
>   	ITEM_ICMP,
>   	ITEM_ICMP_TYPE,
>   	ITEM_ICMP_CODE,
> +	ITEM_ICMP_IDENT,
> +	ITEM_ICMP_SEQ,
>   	ITEM_UDP,
>   	ITEM_UDP_SRC,
>   	ITEM_UDP_DST,
> @@ -893,6 +895,8 @@ static const enum index item_ipv6[] = {
>   static const enum index item_icmp[] = {
>   	ITEM_ICMP_TYPE,
>   	ITEM_ICMP_CODE,
> +	ITEM_ICMP_IDENT,
> +	ITEM_ICMP_SEQ,
>   	ITEM_NEXT,
>   	ZERO,
>   };
> @@ -2193,6 +2197,20 @@ static const struct token token_list[] = {
>   		.args = ARGS(ARGS_ENTRY_HTON(struct rte_flow_item_icmp,
>   					     hdr.icmp_code)),
>   	},
> +	[ITEM_ICMP_IDENT] = {
> +		.name = "ident",
> +		.help = "ICMP packet identifier",
> +		.next = NEXT(item_icmp, NEXT_ENTRY(UNSIGNED), item_param),
> +		.args = ARGS(ARGS_ENTRY_HTON(struct rte_flow_item_icmp,
> +					     hdr.icmp_ident)),
> +	},
> +	[ITEM_ICMP_SEQ] = {
> +		.name = "seq",
> +		.help = "ICMP packet sequence number",
> +		.next = NEXT(item_icmp, NEXT_ENTRY(UNSIGNED), item_param),
> +		.args = ARGS(ARGS_ENTRY_HTON(struct rte_flow_item_icmp,
> +					     hdr.icmp_seq_nb)),
> +	},
>   	[ITEM_UDP] = {
>   		.name = "udp",
>   		.help = "match UDP header",
> 


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [dpdk-dev] [RFC v2 1/1] app/testpmd: distinguish ICMP identifier fields in packet
  2020-09-22 15:38   ` Ferruh Yigit
@ 2020-09-23  2:39     ` Li Zhang
  0 siblings, 0 replies; 9+ messages in thread
From: Li Zhang @ 2020-09-23  2:39 UTC (permalink / raw)
  To: Ferruh Yigit, Dekel Peled, Ori Kam, Slava Ovsiienko, Matan Azrad
  Cc: dev, NBU-Contact-Thomas Monjalon, Raslan Darawsheh

Yes, There is PMD code change to support it.
https://patchwork.dpdk.org/patch/78488/

-----Original Message-----
From: dev <dev-bounces@dpdk.org> On Behalf Of Ferruh Yigit
Sent: Tuesday, September 22, 2020 11:38 PM
To: Li Zhang <lizh@nvidia.com>; Dekel Peled <dekelp@nvidia.com>; Ori Kam <orika@nvidia.com>; Slava Ovsiienko <viacheslavo@nvidia.com>; Matan Azrad <matan@nvidia.com>
Cc: dev@dpdk.org; NBU-Contact-Thomas Monjalon <thomas@monjalon.net>; Raslan Darawsheh <rasland@nvidia.com>
Subject: Re: [dpdk-dev] [RFC v2 1/1] app/testpmd: distinguish ICMP identifier fields in packet

External email: Use caution opening links or attachments


On 9/9/2020 4:34 AM, Li Zhang wrote:
> From: lizh <lizh@nvidia.com>
>
> Ability to distinguish ICMP identifier fields in packets.
> Dstinguish ICMP sequence number field too.
> Already supports ICMP code and type fields in current version.
> Existing fields in ICMP header contain the required information.
> ICMP header already is supported and no code change in RTE FLOW.
> Extend testpmd CLI to include the fields of ident and sequence number.
> One example:
> flow create 0 ingress pattern eth / ipv4 /
>   icmp code is 1 ident is 5 seq is 6 /
>   end actions count / queue index 0 / end The ICMP packet with code 1, 
> identifier 5 and sequence number 6 will be matched.
> It will implement action counter and forward to queue 0.
>

Overall looks good. @Ori, any objection?

@Li, is there any PMD implementation planned to use these icmp fields?

> Signed-off-by: Li Zhang <lizh@nvidia.com>
> ---
>   app/test-pmd/cmdline_flow.c | 18 ++++++++++++++++++
>   1 file changed, 18 insertions(+)
>
> diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
> index 6263d307ed..6e04d538ea 100644
> --- a/app/test-pmd/cmdline_flow.c
> +++ b/app/test-pmd/cmdline_flow.c
> @@ -143,6 +143,8 @@ enum index {
>       ITEM_ICMP,
>       ITEM_ICMP_TYPE,
>       ITEM_ICMP_CODE,
> +     ITEM_ICMP_IDENT,
> +     ITEM_ICMP_SEQ,
>       ITEM_UDP,
>       ITEM_UDP_SRC,
>       ITEM_UDP_DST,
> @@ -893,6 +895,8 @@ static const enum index item_ipv6[] = {
>   static const enum index item_icmp[] = {
>       ITEM_ICMP_TYPE,
>       ITEM_ICMP_CODE,
> +     ITEM_ICMP_IDENT,
> +     ITEM_ICMP_SEQ,
>       ITEM_NEXT,
>       ZERO,
>   };
> @@ -2193,6 +2197,20 @@ static const struct token token_list[] = {
>               .args = ARGS(ARGS_ENTRY_HTON(struct rte_flow_item_icmp,
>                                            hdr.icmp_code)),
>       },
> +     [ITEM_ICMP_IDENT] = {
> +             .name = "ident",
> +             .help = "ICMP packet identifier",
> +             .next = NEXT(item_icmp, NEXT_ENTRY(UNSIGNED), item_param),
> +             .args = ARGS(ARGS_ENTRY_HTON(struct rte_flow_item_icmp,
> +                                          hdr.icmp_ident)),
> +     },
> +     [ITEM_ICMP_SEQ] = {
> +             .name = "seq",
> +             .help = "ICMP packet sequence number",
> +             .next = NEXT(item_icmp, NEXT_ENTRY(UNSIGNED), item_param),
> +             .args = ARGS(ARGS_ENTRY_HTON(struct rte_flow_item_icmp,
> +                                          hdr.icmp_seq_nb)),
> +     },
>       [ITEM_UDP] = {
>               .name = "udp",
>               .help = "match UDP header",
>


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [dpdk-dev] [RFC v2 1/1] app/testpmd: distinguish ICMP identifier fields in packet
  2020-09-09  3:34 ` [dpdk-dev] [RFC v2 1/1] " Li Zhang
  2020-09-22 15:38   ` Ferruh Yigit
@ 2020-09-23  9:04   ` Ferruh Yigit
  2020-09-30 15:30     ` Ferruh Yigit
  1 sibling, 1 reply; 9+ messages in thread
From: Ferruh Yigit @ 2020-09-23  9:04 UTC (permalink / raw)
  To: Li Zhang, dekelp, orika, viacheslavo, matan; +Cc: dev, thomas, rasland

On 9/9/2020 4:34 AM, Li Zhang wrote:
> From: lizh <lizh@nvidia.com>
> 
> Ability to distinguish ICMP identifier fields in packets.
> Dstinguish ICMP sequence number field too.
> Already supports ICMP code and type fields in current version.
> Existing fields in ICMP header contain the required information.
> ICMP header already is supported and no code change in RTE FLOW.
> Extend testpmd CLI to include the fields of ident and sequence number.
> One example:
> flow create 0 ingress pattern eth / ipv4 /
>   icmp code is 1 ident is 5 seq is 6 /
>   end actions count / queue index 0 / end
> The ICMP packet with code 1, identifier 5 and
> sequence number 6 will be matched.
> It will implement action counter and forward to queue 0.
> 
> Signed-off-by: Li Zhang <lizh@nvidia.com> >

Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [dpdk-dev] [RFC v2 1/1] app/testpmd: distinguish ICMP identifier fields in packet
  2020-09-23  9:04   ` Ferruh Yigit
@ 2020-09-30 15:30     ` Ferruh Yigit
  0 siblings, 0 replies; 9+ messages in thread
From: Ferruh Yigit @ 2020-09-30 15:30 UTC (permalink / raw)
  To: Li Zhang, dekelp, orika, viacheslavo, matan; +Cc: dev, thomas, rasland

On 9/23/2020 10:04 AM, Ferruh Yigit wrote:
> On 9/9/2020 4:34 AM, Li Zhang wrote:
>> From: lizh <lizh@nvidia.com>
>>
>> Ability to distinguish ICMP identifier fields in packets.
>> Dstinguish ICMP sequence number field too.
>> Already supports ICMP code and type fields in current version.
>> Existing fields in ICMP header contain the required information.
>> ICMP header already is supported and no code change in RTE FLOW.
>> Extend testpmd CLI to include the fields of ident and sequence number.
>> One example:
>> flow create 0 ingress pattern eth / ipv4 /
>>   icmp code is 1 ident is 5 seq is 6 /
>>   end actions count / queue index 0 / end
>> The ICMP packet with code 1, identifier 5 and
>> sequence number 6 will be matched.
>> It will implement action counter and forward to queue 0.
>>
>> Signed-off-by: Li Zhang <lizh@nvidia.com> >
> 
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
> 

Applied to dpdk-next-net/main, thanks.

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2020-09-30 15:30 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-08 10:06 [dpdk-dev] [RFC] app/testpmd: distinguish ICMP identifier fields in packet lizh
2020-09-08 12:56 ` Thomas Monjalon
2020-09-09  3:41   ` Li Zhang
2020-09-09  3:34 ` [dpdk-dev] [RFC v2 1/1] " Li Zhang
2020-09-22 15:38   ` Ferruh Yigit
2020-09-23  2:39     ` Li Zhang
2020-09-23  9:04   ` Ferruh Yigit
2020-09-30 15:30     ` Ferruh Yigit
2020-09-09  3:49 ` Li Zhang

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git