Re: [dpdk-dev] [PATCH v2] windows/netuio: add Windows NetUIO kernel driver

[Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>]

On Thu, Aug 20, 2020 at 06:32:02PM -0700, Ranjit Menon wrote:
> Hi, Naty
> 
> On 8/20/2020 3:23 PM, Narcisa Ana Maria Vasile wrote:
> >From: Narcisa Vasile <navasile@microsoft.com>
> >
> >The Windows NetUIO kernel driver allows the DPDK userspace
> >application to directly access the hardware.
> >
> >Cc: Harini Ramakrishnan <Harini.Ramakrishnan@microsoft.com>
> >Cc: Omar Cardona <ocardona@microsoft.com>
> >Signed-off-by: Narcisa Vasile <navasile@microsoft.com>
> >---
> >
> I haven't reviewed the code yet, but a few general suggestions and
> observations:
> 
> 1. This code is going into the dpdk-kmods repo, so we don't need the
> four-level deep directory path for the source.
> 
> 2. The code can simply be in the windows/netuio directory (don't
> need 'kernel')
> 
> 3. The 'virt2phys' module that is already in the repo puts the
> build-related files (project files, solution files etc) in the same
> folder as the source files. We should do the same here. We don't
> need the mk/exec-env subfolder for these files. They can be in the
> same directory as the source.
> 
> 4. Remove the .vcxproj.user file from the patch. It is not required.
> 
> 5. The README should be renamed to simply README.rst and it can also
> be in this windows/netuio folder
> 
> 6. The existing README.rst in the windows folder contains
> information on how to build and load kernel modules in Windows. This
> new README can reference the root-level README, if required. (Also
> some of the information in this new README is out-of-date. I'll
> review that separately)
> 
> 
> ranjit m.
> 
Thank you, Ranjit! I've cleaned it up and sent v3.