[dpdk-dev] [PATCH] doc: removed typing mistake

[dpdk-dev] [PATCH] doc: removed typing mistake

[Muhammad Bilal]

Here I have removed 'that' from the sentence to make it grammatically
correct, as it seems to be a typing mistake

Fixes: d0dff9ba445e ("doc: sample application user guide")
Cc: bernard.iremonger@intel.com

Signed-off-by: Muhammad Bilal <m.bilal@emumba.com>
---
 doc/guides/prog_guide/multi_proc_support.rst | 2 +-
 doc/guides/sample_app_ug/multi_process.rst   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/doc/guides/prog_guide/multi_proc_support.rst b/doc/guides/prog_guide/multi_proc_support.rst
index a84083b96..a0d71a81a 100644
--- a/doc/guides/prog_guide/multi_proc_support.rst
+++ b/doc/guides/prog_guide/multi_proc_support.rst
@@ -136,7 +136,7 @@ can use).
 Running Multiple Independent Groups of DPDK Applications
 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 
-In the same way that it is possible to run independent DPDK applications side- by-side on a single system,
+In the same way, it is possible to run independent DPDK applications side- by-side on a single system,
 this can be trivially extended to multi-process groups of DPDK applications running side-by-side.
 In this case, the secondary processes must use the same ``--file-prefix`` parameter
 as the primary process whose shared memory they are connecting to.
diff --git a/doc/guides/sample_app_ug/multi_process.rst b/doc/guides/sample_app_ug/multi_process.rst
index f2a79a639..87c703b83 100644
--- a/doc/guides/sample_app_ug/multi_process.rst
+++ b/doc/guides/sample_app_ug/multi_process.rst
@@ -302,7 +302,7 @@ One additional enhancement in this sample application is that the server process
 This eliminates the need for the client processes to have the portmask parameter passed into them on the command line,
 as is done for the symmetric multi-process application, and therefore eliminates mismatched parameters as a potential source of errors.
 
-In the same way that the server process is designed to be run as a primary process instance only,
+In the same way, the server process is designed to be run as a primary process instance only,
 the client processes are designed to be run as secondary instances only.
 They have no code to attempt to create shared memory objects.
 Instead, handles to all needed rings and memory pools are obtained via calls to rte_ring_lookup() and rte_mempool_lookup().
-- 
2.25.1

Re: [dpdk-dev] [dpdk-stable] [PATCH] doc: removed typing mistake

[David Marchand]

On Wed, Sep 9, 2020 at 11:39 PM Muhammad Bilal <m.bilal@emumba.com> wrote:
>
> Here I have removed 'that' from the sentence to make it grammatically
> correct, as it seems to be a typing mistake
>
> Fixes: d0dff9ba445e ("doc: sample application user guide")
> Cc: bernard.iremonger@intel.com
>
> Signed-off-by: Muhammad Bilal <m.bilal@emumba.com>
> ---
>  doc/guides/prog_guide/multi_proc_support.rst | 2 +-
>  doc/guides/sample_app_ug/multi_process.rst   | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/doc/guides/prog_guide/multi_proc_support.rst b/doc/guides/prog_guide/multi_proc_support.rst
> index a84083b96..a0d71a81a 100644
> --- a/doc/guides/prog_guide/multi_proc_support.rst
> +++ b/doc/guides/prog_guide/multi_proc_support.rst
> @@ -136,7 +136,7 @@ can use).
>  Running Multiple Independent Groups of DPDK Applications
>  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> -In the same way that it is possible to run independent DPDK applications side- by-side on a single system,
> +In the same way, it is possible to run independent DPDK applications side- by-side on a single system,
>  this can be trivially extended to multi-process groups of DPDK applications running side-by-side.
>  In this case, the secondary processes must use the same ``--file-prefix`` parameter
>  as the primary process whose shared memory they are connecting to.
> diff --git a/doc/guides/sample_app_ug/multi_process.rst b/doc/guides/sample_app_ug/multi_process.rst
> index f2a79a639..87c703b83 100644
> --- a/doc/guides/sample_app_ug/multi_process.rst
> +++ b/doc/guides/sample_app_ug/multi_process.rst
> @@ -302,7 +302,7 @@ One additional enhancement in this sample application is that the server process
>  This eliminates the need for the client processes to have the portmask parameter passed into them on the command line,
>  as is done for the symmetric multi-process application, and therefore eliminates mismatched parameters as a potential source of errors.
>
> -In the same way that the server process is designed to be run as a primary process instance only,
> +In the same way, the server process is designed to be run as a primary process instance only,
>  the client processes are designed to be run as secondary instances only.
>  They have no code to attempt to create shared memory objects.
>  Instead, handles to all needed rings and memory pools are obtained via calls to rte_ring_lookup() and rte_mempool_lookup().

Sorry, but I don't see what is wrong with the original form.


-- 
David Marchand

[dpdk-dev] [PATCH] doc: removed typing mistake

[Muhammad Bilal]

There was a duplicate command instruction in the documentation of memif
so I have removed the 1 command from it.

Fixes: cbbbbd3365d2 ("net/memif: enable loopback")
Cc: jmilan.dev@gmail.com

Signed-off-by: Muhammad Bilal <m.bilal@emumba.com>
---
 doc/guides/nics/memif.rst | 1 -
 1 file changed, 1 deletion(-)

diff --git a/doc/guides/nics/memif.rst b/doc/guides/nics/memif.rst
index 08a9fda86..ddeebed25 100644
--- a/doc/guides/nics/memif.rst
+++ b/doc/guides/nics/memif.rst
@@ -289,4 +289,3 @@ Then start the communication::
 Finally we can check port stats to see the traffic::
 
     testpmd> show port stats all
-    testpmd> show port stats all
-- 
2.17.1

Re: [dpdk-dev] [PATCH] doc: removed typing mistake

[Ferruh Yigit]

On 5/29/2020 3:47 PM, Muhammad Bilal wrote:
> There was a duplicate command instruction in the documentation of memif
> so I have removed the 1 command from it.
> 
> Fixes: cbbbbd3365d2 ("net/memif: enable loopback")
> Cc: jmilan.dev@gmail.com
> 
> Signed-off-by: Muhammad Bilal <m.bilal@emumba.com>
> ---
>  doc/guides/nics/memif.rst | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/doc/guides/nics/memif.rst b/doc/guides/nics/memif.rst
> index 08a9fda86..ddeebed25 100644
> --- a/doc/guides/nics/memif.rst
> +++ b/doc/guides/nics/memif.rst
> @@ -289,4 +289,3 @@ Then start the communication::
>  Finally we can check port stats to see the traffic::
>  
>      testpmd> show port stats all
> -    testpmd> show port stats all
> 

Updating patch title as following while merging:
 doc: fix duplicated line in memif guide

Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>

Applied to dpdk-next-net/master, thanks.