From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id A3086A04B5;
Thu, 10 Sep 2020 10:42:43 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id 0607B1BEB3;
Thu, 10 Sep 2020 10:42:43 +0200 (CEST)
Received: from mga17.intel.com (mga17.intel.com [192.55.52.151])
by dpdk.org (Postfix) with ESMTP id 6EDB72BA8
for <dev@dpdk.org>; Thu, 10 Sep 2020 10:42:41 +0200 (CEST)
IronPort-SDR: LEMZ7VrRriTJdMVHEqSSNbJJbIqLgORMHuTpxuJ3rJnd0iopGkUK141dfzDNBvgoQLgaiRmIO6
OsIrFzPrY4Qw==
X-IronPort-AV: E=McAfee;i="6000,8403,9739"; a="138526158"
X-IronPort-AV: E=Sophos;i="5.76,412,1592895600"; d="scan'208";a="138526158"
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga005.jf.intel.com ([10.7.209.41])
by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
10 Sep 2020 01:42:40 -0700
IronPort-SDR: gty6WKXZe0eXtOPC7RcVHUWmBVDp2p2Eocy0ke8FAbuUsFM4Pf720DSZpeCSRwy2QLxphfUqP+
oOm36saL4wIA==
X-IronPort-AV: E=Sophos;i="5.76,412,1592895600"; d="scan'208";a="480807046"
Received: from bricha3-mobl.ger.corp.intel.com ([10.252.5.251])
by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA;
10 Sep 2020 01:42:39 -0700
Date: Thu, 10 Sep 2020 09:42:36 +0100
From: Bruce Richardson <bruce.richardson@intel.com>
To: "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>
Cc: Stephen Hemminger <stephen@networkplumber.org>,
"dev@dpdk.org" <dev@dpdk.org>
Message-ID: <20200910084236.GA1789@bricha3-MOBL.ger.corp.intel.com>
References: <20200907214032.95052-2-cristian.dumitrescu@intel.com>
<20200908201830.74206-1-cristian.dumitrescu@intel.com>
<20200908201830.74206-2-cristian.dumitrescu@intel.com>
<20200909120535.6d32242b@hermes.lan>
<CY4PR11MB1702D882492E2EB5C0ADE130EB260@CY4PR11MB1702.namprd11.prod.outlook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CY4PR11MB1702D882492E2EB5C0ADE130EB260@CY4PR11MB1702.namprd11.prod.outlook.com>
Subject: Re: [dpdk-dev] [PATCH v3 01/41] pipeline: add new SWX pipeline type
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
On Wed, Sep 09, 2020 at 07:52:39PM +0000, Dumitrescu, Cristian wrote:
> Hi Stephen,
>
> > -----Original Message-----
> > From: Stephen Hemminger <stephen@networkplumber.org>
> > Sent: Wednesday, September 9, 2020 8:06 PM
> > To: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>
> > Cc: dev@dpdk.org
> > Subject: Re: [dpdk-dev] [PATCH v3 01/41] pipeline: add new SWX pipeline
> > type
> >
> > On Tue, 8 Sep 2020 21:17:50 +0100
> > Cristian Dumitrescu <cristian.dumitrescu@intel.com> wrote:
> >
> > > +/*
> > > + * Pipeline.
> > > + */
> > > +struct rte_swx_pipeline {
> > > + int build_done;
> > > + int numa_node;
> > > +};
> > > +
> > > +
> >
> > Is int the right type for these.
> > build_done seems like a Boolean
>
> Isn't the difference between int and bool mostly cosmetic?
> AFAIK we don't have a hard rule in DPDK about bool vs. int.
>
> > and numa_node should be unsigned?
>
> All the functions in libnuma use int as the numa_node type, please see: man 3 numa.
>
Yes, we also have -1 in DPDK for an unspecified NUMA node, e.g. where a PCI
device is just attached to the chipset rather than direct to the CPU
socket.
/Bruce