From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2F269A04B5; Thu, 10 Sep 2020 11:23:49 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A8C321BFA2; Thu, 10 Sep 2020 11:23:48 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 382102BA8 for ; Thu, 10 Sep 2020 11:23:47 +0200 (CEST) IronPort-SDR: rFe6VwY/6/Vh9jbYsRqP1Pv9u9V/7G4ZO3MQLTzF2fbKkHfHSg1wP2+qSxqZVZmUysD1x+F4Rx agTi4j6wtOgQ== X-IronPort-AV: E=McAfee;i="6000,8403,9739"; a="138016900" X-IronPort-AV: E=Sophos;i="5.76,412,1592895600"; d="scan'208";a="138016900" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Sep 2020 02:23:46 -0700 IronPort-SDR: 75zRdlpcVJqirnPIzJjGrasTESi3/zTCAoh7Mk4lhSj4AJHOzFmls0CTdQUDsnf4nItW8DRsi1 A5cVSW00fRFw== X-IronPort-AV: E=Sophos;i="5.76,412,1592895600"; d="scan'208";a="480818720" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.5.251]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 10 Sep 2020 02:23:44 -0700 Date: Thu, 10 Sep 2020 10:23:41 +0100 From: Bruce Richardson To: SteveX Yang Cc: dev@dpdk.org, wenzhuo.lu@intel.com, beilei.xing@intel.com, qiming.yang@intel.com Message-ID: <20200910092341.GD1789@bricha3-MOBL.ger.corp.intel.com> References: <20200910022018.8955-1-stevex.yang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200910022018.8955-1-stevex.yang@intel.com> Subject: Re: [dpdk-dev] [PATCH v1] app/test-pmd: fix meson build failed when used latency stats lib X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Sep 10, 2020 at 02:20:18AM +0000, SteveX Yang wrote: > meson build cannot find the header rte_latencystats.h when build DPDK > first time or never installed DPDK lib after build via meson/ninja. > > Because the corresponding header directory isn't included after enabled > RTE_LIBRTE_LATENCY_STATS flag. > > Add the header file location and link library to meson.build of test-pmd > > Signed-off-by: SteveX Yang > --- As before, I think we have a mismatch in old vs new macro names which is why this wasn't caught before. Therefore I suggest we just change testpmd to use the new macro to keep things standardized. [Other alternatives if we want to keep compatibility are to rename the latencystats directory to have an underscore in it, or to override the name (which I'd rather not go for)] > app/test-pmd/meson.build | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/app/test-pmd/meson.build b/app/test-pmd/meson.build > index db0ff02eb..6ee7af750 100644 > --- a/app/test-pmd/meson.build > +++ b/app/test-pmd/meson.build > @@ -9,6 +9,10 @@ if dpdk_conf.has('RTE_LIBRTE_BOND_PMD') > cflags += '-I' + meson.source_root() + '/drivers/net/bonding' > endif > > +if dpdk_conf.has('RTE_LIBRTE_LATENCYSTATS') > + cflags += '-I' + meson.source_root() + '/lib/librte_latencystats' > +endif > + Rather than working with long cflags, just add latencystats as a dependency of testpmd. > sources = files('5tswap.c', > 'cmdline.c', > 'cmdline_flow.c', > -- > 2.17.1 >