From: Bruce Richardson <bruce.richardson@intel.com>
To: Leyi Rong <leyi.rong@intel.com>
Cc: wenzhuo.lu@intel.com, qi.z.zhang@intel.com, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v1 1/2] net/ice: add AVX512 vector path
Date: Thu, 10 Sep 2020 10:32:34 +0100 [thread overview]
Message-ID: <20200910093234.GF1789@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <20200910065504.104217-2-leyi.rong@intel.com>
On Thu, Sep 10, 2020 at 02:55:03PM +0800, Leyi Rong wrote:
> Add AVX512 support for ice PMD. This patch adds ice_rxtx_vec_avx512.c
> to support ice AVX512 vPMD.
>
> This patch aims to enable AVX512 on ice vPMD. Main changes are focus
> on Rx path compared with AVX2 vPMD.
>
> Signed-off-by: Leyi Rong <leyi.rong@intel.com>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
> drivers/net/ice/ice_rxtx.c | 88 ++-
> drivers/net/ice/ice_rxtx.h | 7 +
> drivers/net/ice/ice_rxtx_vec_avx512.c | 824 ++++++++++++++++++++++++++
> drivers/net/ice/meson.build | 13 +
> 4 files changed, 914 insertions(+), 18 deletions(-)
> create mode 100644 drivers/net/ice/ice_rxtx_vec_avx512.c
<snip>
> + if dpdk_conf.has('RTE_MACHINE_CPUFLAG_AVX512F') or not machine_args.contains('-mno-avx512f')
I think you need to split these conditions:
If the cpu flag is set, you just want to unconditionally add the file to
the build list. However, if no-avx512 flag is set, you want to skip the
whole block completely.
> + if cc.has_argument('-mavx512f') and cc.has_argument('-mavx512bw')
> + cflags += ['-DCC_AVX512_SUPPORT']
> + ice_avx512_lib = static_library('ice_avx512_lib',
> + 'ice_rxtx_vec_avx512.c',
> + dependencies: [static_rte_ethdev,
> + static_rte_kvargs, static_rte_hash],
> + include_directories: includes,
> + c_args: [cflags, '-march=skylake-avx512', '-mavx512f'])
> + objs += ice_avx512_lib.extract_objects('ice_rxtx_vec_avx512.c')
> + endif
> + endif
> endif
>
> sources += files('ice_dcf.c',
> --
> 2.17.1
>
next prev parent reply other threads:[~2020-09-10 9:32 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-10 6:55 [dpdk-dev] [PATCH v1 0/2] AVX512 vPMD on ice Leyi Rong
2020-09-10 6:55 ` [dpdk-dev] [PATCH v1 1/2] net/ice: add AVX512 vector path Leyi Rong
2020-09-10 9:32 ` Bruce Richardson [this message]
2020-09-10 6:55 ` [dpdk-dev] [PATCH v1 2/2] net/ice: optimize Tx path on AVX512 vPMD Leyi Rong
2020-09-15 1:17 ` Wang, Haiyue
2020-09-18 3:35 ` [dpdk-dev] [PATCH v2 0/3] AVX512 vPMD on ice Leyi Rong
2020-09-18 3:35 ` [dpdk-dev] [PATCH v2 1/3] net/ice: add AVX512 vector path Leyi Rong
2020-09-18 3:35 ` [dpdk-dev] [PATCH v2 2/3] net/ice: add RSS hash parsing in AVX512 path Leyi Rong
2020-09-18 3:35 ` [dpdk-dev] [PATCH v2 3/3] net/ice: optimize Tx path on AVX512 vPMD Leyi Rong
2020-10-20 10:51 ` [dpdk-dev] [PATCH v3 0/3] AVX512 vPMD on ice Leyi Rong
2020-10-20 10:51 ` [dpdk-dev] [PATCH v3 1/3] net/ice: add AVX512 vector path Leyi Rong
2020-10-20 10:51 ` [dpdk-dev] [PATCH v3 2/3] net/ice: add RSS hash parsing in AVX512 path Leyi Rong
2020-10-20 10:51 ` [dpdk-dev] [PATCH v3 3/3] net/ice: optimize Tx path on AVX512 vPMD Leyi Rong
2020-10-23 4:14 ` [dpdk-dev] [PATCH v4 0/3] AVX512 vPMD on ice Leyi Rong
2020-10-23 4:14 ` [dpdk-dev] [PATCH v4 1/3] net/ice: add AVX512 vector path Leyi Rong
2020-10-25 16:23 ` David Marchand
2020-10-26 7:12 ` Rong, Leyi
2020-10-26 8:09 ` David Marchand
2020-10-27 10:19 ` Bruce Richardson
2020-10-27 10:22 ` Ferruh Yigit
2020-10-27 8:32 ` Ali Alnubani
2020-10-27 8:42 ` Ali Alnubani
2020-10-23 4:14 ` [dpdk-dev] [PATCH v4 2/3] net/ice: add RSS hash parsing in AVX512 path Leyi Rong
2020-10-23 4:14 ` [dpdk-dev] [PATCH v4 3/3] net/ice: optimize Tx path on AVX512 vPMD Leyi Rong
2020-10-23 9:39 ` [dpdk-dev] [PATCH v4 0/3] AVX512 vPMD on ice Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200910093234.GF1789@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=leyi.rong@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).