From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id BCB8CA04B5; Thu, 10 Sep 2020 11:32:41 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A1F051BFA2; Thu, 10 Sep 2020 11:32:41 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 0B5CE1BEB3 for ; Thu, 10 Sep 2020 11:32:39 +0200 (CEST) IronPort-SDR: Pt95mOg8icTd1LcuSPrf9mZOaqcQw+44fmYyhbiil0swkzUS67sKN/+VKQh1EGXE7cemkp7lJB sJlAnwp705Qg== X-IronPort-AV: E=McAfee;i="6000,8403,9739"; a="157779881" X-IronPort-AV: E=Sophos;i="5.76,412,1592895600"; d="scan'208";a="157779881" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Sep 2020 02:32:39 -0700 IronPort-SDR: tyndiZoa6E28JI/GFNoOZfLdVmDwgy78uO33kjuK54AAX99juwoy/AEKDufDOTQDjN1QvXrD/a 6zMHgvtrWieA== X-IronPort-AV: E=Sophos;i="5.76,412,1592895600"; d="scan'208";a="480820841" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.5.251]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 10 Sep 2020 02:32:37 -0700 Date: Thu, 10 Sep 2020 10:32:34 +0100 From: Bruce Richardson To: Leyi Rong Cc: wenzhuo.lu@intel.com, qi.z.zhang@intel.com, dev@dpdk.org Message-ID: <20200910093234.GF1789@bricha3-MOBL.ger.corp.intel.com> References: <20200910065504.104217-1-leyi.rong@intel.com> <20200910065504.104217-2-leyi.rong@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200910065504.104217-2-leyi.rong@intel.com> Subject: Re: [dpdk-dev] [PATCH v1 1/2] net/ice: add AVX512 vector path X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Sep 10, 2020 at 02:55:03PM +0800, Leyi Rong wrote: > Add AVX512 support for ice PMD. This patch adds ice_rxtx_vec_avx512.c > to support ice AVX512 vPMD. > > This patch aims to enable AVX512 on ice vPMD. Main changes are focus > on Rx path compared with AVX2 vPMD. > > Signed-off-by: Leyi Rong > Signed-off-by: Bruce Richardson > --- > drivers/net/ice/ice_rxtx.c | 88 ++- > drivers/net/ice/ice_rxtx.h | 7 + > drivers/net/ice/ice_rxtx_vec_avx512.c | 824 ++++++++++++++++++++++++++ > drivers/net/ice/meson.build | 13 + > 4 files changed, 914 insertions(+), 18 deletions(-) > create mode 100644 drivers/net/ice/ice_rxtx_vec_avx512.c > + if dpdk_conf.has('RTE_MACHINE_CPUFLAG_AVX512F') or not machine_args.contains('-mno-avx512f') I think you need to split these conditions: If the cpu flag is set, you just want to unconditionally add the file to the build list. However, if no-avx512 flag is set, you want to skip the whole block completely. > + if cc.has_argument('-mavx512f') and cc.has_argument('-mavx512bw') > + cflags += ['-DCC_AVX512_SUPPORT'] > + ice_avx512_lib = static_library('ice_avx512_lib', > + 'ice_rxtx_vec_avx512.c', > + dependencies: [static_rte_ethdev, > + static_rte_kvargs, static_rte_hash], > + include_directories: includes, > + c_args: [cflags, '-march=skylake-avx512', '-mavx512f']) > + objs += ice_avx512_lib.extract_objects('ice_rxtx_vec_avx512.c') > + endif > + endif > endif > > sources += files('ice_dcf.c', > -- > 2.17.1 >