From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id 1C42FA04B5;
Thu, 10 Sep 2020 12:56:31 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id 10F521BEB3;
Thu, 10 Sep 2020 12:56:30 +0200 (CEST)
Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com
[67.231.148.174]) by dpdk.org (Postfix) with ESMTP id 6424D1B9B7
for <dev@dpdk.org>; Thu, 10 Sep 2020 12:56:28 +0200 (CEST)
Received: from pps.filterd (m0045849.ppops.net [127.0.0.1])
by mx0a-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id
08AAtuWk019710; Thu, 10 Sep 2020 03:56:22 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;
h=date : from : to :
cc : subject : message-id : references : content-type : in-reply-to :
mime-version; s=pfpt0220; bh=gYH8fBBMOmfcv/qEeW9AA2GACWZvkmrU4+Etr43RwqE=;
b=FTqmpg0SoVvzL2yskWMCC8EEwsP/K86LZLrCpyn1/hlSHOWeGLs0TX9k5o/rnviYPfpV
3lBW6cVfV7NfeEJtiUuXuK6h0aZgt0kGaDaYXTg0VF6UVH0e9i/gY1W5X60YTnB6PhND
5O6AUxeHig0pvbbgBTwp8h3oaWq9CkuhuU6pyJMe3powOD8oSbczlHBu6v9OG50EYZEW
dIN8BzJZz72hSXZvsPMMPGzWLwf5KLHu4rkJ8RVZFRO0sLIe7AZWJ++BaChEK866EfQC
qYjSSOv+RzwKqCPhOHBF/Pj6wp59wXWstQTLiZSQlXa2piaGUQATYs/Obw3s9IMLisKr rA==
Received: from sc-exch02.marvell.com ([199.233.58.182])
by mx0a-0016f401.pphosted.com with ESMTP id 33c81q4d7d-1
(version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT);
Thu, 10 Sep 2020 03:56:22 -0700
Received: from DC5-EXCH01.marvell.com (10.69.176.38) by SC-EXCH02.marvell.com
(10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1497.2;
Thu, 10 Sep 2020 03:56:21 -0700
Received: from SC-EXCH02.marvell.com (10.93.176.82) by DC5-EXCH01.marvell.com
(10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.2;
Thu, 10 Sep 2020 03:56:20 -0700
Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.105)
by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id
15.0.1497.2 via Frontend Transport; Thu, 10 Sep 2020 03:56:20 -0700
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
b=MQxokvdT1mGzMIZB/j3rRlhoV5DOiOUUVih87GI/gSrv4QPXefRNMZVtNkkZ+ar3LQ4IsFMBlwXYNELlfMYN+Jia5qc1kB3AzrlwikaDmyZg2NJ6arW2Q2AJOxcZvWv+W0PFkew2beaQLdQhu9qhhKugCEcTZE7W2uYRzCi8uq9PIQD5HtWp1sxXiOoZIBorgc+OL9VFm0+D/08oLhu/jlh3DtmcZDv13mSHIJcXLP4MtkvtnNUzpHPPCN91uUZ3/1OevS/TFHGsj5SMHUqF3FouexlkKAya1SiTtAawex7iXJZRAqP32VYu5IolgffkzXdqjVXQqW21cCYngEgYQA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector9901;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=gYH8fBBMOmfcv/qEeW9AA2GACWZvkmrU4+Etr43RwqE=;
b=hKiF+yFDwtp2exortng/xfDbX2Fodln/LQBFYuYNcZXBkK4yo362EfV0D9UurX+ARqMAbpLEEYfEs4RpgSvtKhn4hbGi7cTSd+YefD4qy/SthC/8zrTOyHYf50mdWcepf9L42KgdGSFo0XXcPrXZQuYnNhYmDWQk+KZG3+gQQm62OwI8kI0zCLgm55KhuC9ZsEjZk8FsO2V9Ff7VtZ5dpxRtTfkV8AmYifhWAd80nqkgxg6qKh12rtaffezVUR3VvDy9kjygk9Sn0k+XT+GRhLUKeHZyLSuNM6WO7cCjSVe3q3V3DQcLHCk7eWfsZepbnPhlMDXm514zwCwLvyINRA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com;
dkim=pass header.d=marvell.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=gYH8fBBMOmfcv/qEeW9AA2GACWZvkmrU4+Etr43RwqE=;
b=huxKorTwtVXmQfM+kAaM3xYK6BxmcWoBM/9RHi9DNyB0uiyNkR6JIwd2C5nfpqpsN0CXGIkZfw9FLE+cPsm5wIyO2QNkgHsGEwBlQITCcCAZtxuiVM2lnRBuoGR/fmFDx7DQGcLhRztut8nsdj9lbLSl+rNMnaHeNM5BVdExyq0=
Authentication-Results: ashroe.eu; dkim=none (message not signed)
header.d=none;ashroe.eu; dmarc=none action=none header.from=marvell.com;
Received: from BN8PR18MB2386.namprd18.prod.outlook.com (2603:10b6:408:68::25)
by BN8PR18MB2388.namprd18.prod.outlook.com (2603:10b6:408:9f::18)
with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3370.16; Thu, 10 Sep
2020 10:56:18 +0000
Received: from BN8PR18MB2386.namprd18.prod.outlook.com
([fe80::69ba:f95b:c06b:150e]) by BN8PR18MB2386.namprd18.prod.outlook.com
([fe80::69ba:f95b:c06b:150e%4]) with mapi id 15.20.3370.016; Thu, 10 Sep 2020
10:56:18 +0000
Date: Thu, 10 Sep 2020 16:26:06 +0530
From: Nithin Dabilpuram <ndabilpuram@marvell.com>
To: "Kinsella, Ray" <mdr@ashroe.eu>
CC: <ferruh.yigit@intel.com>, <bruce.richardson@intel.com>,
<cristian.dumitrescu@intel.com>, <thomas@monjalon.net>,
<bluca@debian.org>, <jasvinder.singh@intel.com>,
<arybchenko@solarflare.com>, <ray.kinsella@intel.com>,
<nhorman@tuxdriver.com>, <ktraynor@redhat.com>,
<david.marchand@redhat.com>, <dev@dpdk.org>, <jerinj@marvell.com>
Message-ID: <20200910105606.GC25338@outlook.office365.com>
References: <20200909172200.30610-1-ndabilpuram@marvell.com>
<20200910080538.28041-1-ndabilpuram@marvell.com>
<7c4820d7-d3cb-b985-ffa6-f6ed87d1bf07@ashroe.eu>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <7c4820d7-d3cb-b985-ffa6-f6ed87d1bf07@ashroe.eu>
User-Agent: Mutt/1.12.2 (34cd43c) (2019-09-21)
X-ClientProxiedBy: BMXPR01CA0004.INDPRD01.PROD.OUTLOOK.COM
(2603:1096:b00:d::14) To BN8PR18MB2386.namprd18.prod.outlook.com
(2603:10b6:408:68::25)
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from outlook.office365.com (115.113.156.2) by
BMXPR01CA0004.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:d::14) with Microsoft
SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
15.20.3370.16 via Frontend Transport; Thu, 10 Sep 2020 10:56:14 +0000
X-Originating-IP: [115.113.156.2]
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 2a8c30a3-5432-41ec-6e0f-08d855782558
X-MS-TrafficTypeDiagnostic: BN8PR18MB2388:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <BN8PR18MB238831F1668CDE6C944D08C9AF270@BN8PR18MB2388.namprd18.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:172;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: tz1vHk8taw28BqHCsJqz66LjjVhNEvTXR58j9xeUqarTgosIaSXzPlejNZVLI7ljNqwx2x0bAUzvrOv058oYGFoqZtZx9VeF1BYgVALzd96Q50sVPMhKZjR+XwkMoA7W2/r+bpjkFrjMWUq32E1dOCGzvEyda1R8fsGylwznMjeBkScyJLxQT4ddoUbYFHH8JJYpdlWgjrjDRgOHgbV7YvXpr6eReH+xRPuXHyHwxUAR/N5kcTsRD9xcsvydOZX2l3/Pk/z00EYb9LsskZr7IRCJ7VXdBqI+PcJkIXA4k31DIDhuq3Wxs32iC4gSvsK2uf1Ns9Mh9IhpKmuS+I2wVQlFgnaH4oR2dCkjX1BPsAwLXUlK2bT8ISwKZs+zWcvsyt6Nv+qxj17eOk6DpUSI2Q==
X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;
IPV:NLI; SFV:NSPM; H:BN8PR18MB2386.namprd18.prod.outlook.com; PTR:; CAT:NONE;
SFS:(4636009)(376002)(346002)(136003)(39860400002)(396003)(366004)(8936002)(6916009)(4326008)(52116002)(7696005)(9686003)(2906002)(478600001)(7416002)(33656002)(107886003)(86362001)(966005)(83380400001)(55016002)(6666004)(956004)(16526019)(6506007)(53546011)(316002)(26005)(5660300002)(66556008)(66476007)(55236004)(66946007)(1076003)(8676002)(186003);
DIR:OUT; SFP:1101;
X-MS-Exchange-AntiSpam-MessageData: ifq3VUyB7EzBDvTX685kgZiwJJS436LHeL1oeMRlCMAOU1OTgLJQ26T8a1yN0FvE8ZQwxVCwac9DM8rADGb1prbKG0XAs7HzrYrDjisB+N6ipV9Wn6K3HsWq/W/ZpuROgMBGabuyHtBCh5PvPmVcbavfLYBjP88Alftu/BVA6ZrGIyF9STuVkjMpLLfPF5Sb4Ox0bU5shagtEZfAjCvTW7DoARA4whjWDSq3x9BS8zEGDg7IvBcd9eEnBfmxdGDN0yzIZdpnDHf+ltVAKHiU1uMY4Y36CvXrNsmMZ8pGao0dLGL04RxbtqJda2zNLWKr5g1iHwgaj/Ovb5XlngZDmwM1U+22KA+so+kRg9tzyqJd2A3OEAp/pxXiiGO2q/Ol/6JDkOxHISbKpz2fbcrkvBKqXUYKUrfsgkuF2i4RndgyzELUb9woKYZKjzMsJ/FwPtW4A/AfusrSkjHNySf8MQK6vvefF1+w/HtOLtUJR93x0XHyY6YyH3HzJMe7bqncG3KkvaF+6Fh04ws7wPx+3/Z67g3UHyR10oB3EZ19xJbl5CuR7PhfWCahzKO5k8ewZhQu810ePeUY4w0YO3kLYHY4/225CzCz3lMlN/+3S3WVOK2GbMuV7o/w1Apd82dCb2coFd7QlzsJoh3foI9AGg==
X-MS-Exchange-CrossTenant-Network-Message-Id: 2a8c30a3-5432-41ec-6e0f-08d855782558
X-MS-Exchange-CrossTenant-AuthSource: BN8PR18MB2386.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Sep 2020 10:56:18.6402 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: C3/Hp8SZAzeJ6z4PuPppnC4EgiWNottmPLjflmTCPhZ4E4ElztHOT99kIJYxjueeEB6qeFG98dFlXLqr/HmFLA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR18MB2388
X-OriginatorOrg: marvell.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235, 18.0.687
definitions=2020-09-10_02:2020-09-10,
2020-09-10 signatures=0
Subject: Re: [dpdk-dev] [EXT] Re: [PATCH v2] ethdev: mark all traffic
manager API as experimental
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
On Thu, Sep 10, 2020 at 09:30:15AM +0100, Kinsella, Ray wrote:
> External Email
>
> ----------------------------------------------------------------------
> On 10/09/2020 09:05, Nithin Dabilpuram wrote:
> > This patch marks all traffic manager API as experimental as
> > per discussion mentioned in below thread.
> >
> > https://urldefense.proofpoint.com/v2/url?u=https-3A__mails.dpdk.org_archives_dev_2020-2DApril_165364.html&d=DwIDaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=FZ_tPCbgFOh18zwRPO9H0yDx8VW38vuapifdDfc8SFQ&m=NlIUXSsugCPTKBv9qxsaMHOhTuC90TUqLcGg962VVyA&s=DZL_m0a73uef5Qgal1iFqc9dTdAuUd8J6eC0mZOQlFs&e=
> >
> > Signed-off-by: Nithin Dabilpuram <ndabilpuram@marvell.com>
> > ---
> >
> > v2:
> > - Updated commit message.
> >
> > lib/librte_ethdev/rte_ethdev_version.map | 62 ++++++++++++++++----------------
> > lib/librte_ethdev/rte_tm.h | 33 ++++++++++++++++-
> > 2 files changed, 64 insertions(+), 31 deletions(-)
> >
> > diff --git a/lib/librte_ethdev/rte_ethdev_version.map b/lib/librte_ethdev/rte_ethdev_version.map
> > index 1212a17..3da4512 100644
> > --- a/lib/librte_ethdev/rte_ethdev_version.map
> > +++ b/lib/librte_ethdev/rte_ethdev_version.map
> > @@ -135,36 +135,6 @@ DPDK_20.0 {
> > rte_flow_isolate;
> > rte_flow_query;
> > rte_flow_validate;
> > - rte_tm_capabilities_get;
> > - rte_tm_get_number_of_leaf_nodes;
> > - rte_tm_hierarchy_commit;
> > - rte_tm_level_capabilities_get;
> > - rte_tm_mark_ip_dscp;
> > - rte_tm_mark_ip_ecn;
> > - rte_tm_mark_vlan_dei;
> > - rte_tm_node_add;
> > - rte_tm_node_capabilities_get;
> > - rte_tm_node_cman_update;
> > - rte_tm_node_delete;
> > - rte_tm_node_parent_update;
> > - rte_tm_node_resume;
> > - rte_tm_node_shaper_update;
> > - rte_tm_node_shared_shaper_update;
> > - rte_tm_node_shared_wred_context_update;
> > - rte_tm_node_stats_read;
> > - rte_tm_node_stats_update;
> > - rte_tm_node_suspend;
> > - rte_tm_node_type_get;
> > - rte_tm_node_wfq_weight_mode_update;
> > - rte_tm_node_wred_context_update;
> > - rte_tm_shaper_profile_add;
> > - rte_tm_shaper_profile_delete;
> > - rte_tm_shared_shaper_add_update;
> > - rte_tm_shared_shaper_delete;
> > - rte_tm_shared_wred_context_add_update;
> > - rte_tm_shared_wred_context_delete;
> > - rte_tm_wred_profile_add;
> > - rte_tm_wred_profile_delete;
> >
> > local: *;
> > };
> > @@ -241,6 +211,38 @@ EXPERIMENTAL {
> > __rte_ethdev_trace_rx_burst;
> > __rte_ethdev_trace_tx_burst;
> > rte_flow_get_aged_flows;
> > +
> > + # Marked as experimental in 20.11
> > + rte_tm_capabilities_get;
> > + rte_tm_get_number_of_leaf_nodes;
> > + rte_tm_hierarchy_commit;
> > + rte_tm_level_capabilities_get;
> > + rte_tm_mark_ip_dscp;
> > + rte_tm_mark_ip_ecn;
> > + rte_tm_mark_vlan_dei;
> > + rte_tm_node_add;
> > + rte_tm_node_capabilities_get;
> > + rte_tm_node_cman_update;
> > + rte_tm_node_delete;
> > + rte_tm_node_parent_update;
> > + rte_tm_node_resume;
> > + rte_tm_node_shaper_update;
> > + rte_tm_node_shared_shaper_update;
> > + rte_tm_node_shared_wred_context_update;
> > + rte_tm_node_stats_read;
> > + rte_tm_node_stats_update;
> > + rte_tm_node_suspend;
> > + rte_tm_node_type_get;
> > + rte_tm_node_wfq_weight_mode_update;
> > + rte_tm_node_wred_context_update;
> > + rte_tm_shaper_profile_add;
> > + rte_tm_shaper_profile_delete;
> > + rte_tm_shared_shaper_add_update;
> > + rte_tm_shared_shaper_delete;
> > + rte_tm_shared_wred_context_add_update;
> > + rte_tm_shared_wred_context_delete;
> > + rte_tm_wred_profile_add;
> > + rte_tm_wred_profile_delete;
> > };
> [SNIP]
>
> So I will re-interate what I said in April, all of these API have existed since DPDK 17.08.
> I find it hard to believe they are all at imminent risk of changing to degree they _all_ warrant EXPERIMENTAL status.
As discussed earlier and agreed by TM and Ethdev maintainers, __rte_experimental tag was introduced several
releases after TM spec was added and TM spec remained untouched ending up making it stable unintentionally.
Bruce and other maintainers pointed out that we cannot fix it as a "Fixes:" patch in order
to honor ABI commitments, and suggestion was to change the complete spec back to
experimental in next ABI change window and proceed with improvements that make
it stable API in subsequent releases.
>
> Ray K