From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 026C5A04B5; Thu, 10 Sep 2020 13:12:36 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CFAE01BEB3; Thu, 10 Sep 2020 13:12:35 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id DA10D2BA8 for ; Thu, 10 Sep 2020 13:12:34 +0200 (CEST) IronPort-SDR: DlPTc3yqUPg3Ixu4iMow4h1IgpSyPx5KnBWvDUVKuayAEYZ2ImoIEhf5pC2jILAQvMKTq5hPZP wztBjo7vbqvw== X-IronPort-AV: E=McAfee;i="6000,8403,9739"; a="220069232" X-IronPort-AV: E=Sophos;i="5.76,412,1592895600"; d="scan'208";a="220069232" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Sep 2020 04:12:33 -0700 IronPort-SDR: B2anI5nQwPWOLFChFIo2ybKoZg7nrCf2ExJ3aSXUGdNzgUncUmbccwYVzm9SIutRmLykyn39N1 iEhKZ/33GSVw== X-IronPort-AV: E=Sophos;i="5.76,412,1592895600"; d="scan'208";a="480848605" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.5.251]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 10 Sep 2020 04:12:32 -0700 Date: Thu, 10 Sep 2020 12:12:29 +0100 From: Bruce Richardson To: SteveX Yang Cc: dev@dpdk.org, wenzhuo.lu@intel.com, beilei.xing@intel.com, qiming.yang@intel.com Message-ID: <20200910111229.GG1789@bricha3-MOBL.ger.corp.intel.com> References: <20200910015525.59124-1-stevex.yang@intel.com> <20200910091657.GC1789@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200910091657.GC1789@bricha3-MOBL.ger.corp.intel.com> Subject: Re: [dpdk-dev] [PATCH v1] app/test-pmd: fix meson build failed when enabled pmd_bonded X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Sep 10, 2020 at 10:16:57AM +0100, Bruce Richardson wrote: > On Thu, Sep 10, 2020 at 01:55:25AM +0000, SteveX Yang wrote: > > meson build cannot find the header rte_eth_bond.h when build DPDK first > > time or never installed DPDK lib after build via meson/ninja. > > > > Because the corresponding header directory isn't included after enabled > > RTE_LIBRTE_PMD_BOND macro. > > > > Add the header file location and link library to meson.build of test-pmd > > > > Signed-off-by: SteveX Yang > > --- > > While there is a problem here, I think the solution may itself be > incomplete. Since the bonding PMD is always enabled by default, it's > support should always be enabled in testpmd. Therefore, testpmd should be > using the RTE_LIBRTE_BOND_PMD macro internally, not RTE_LIBRTE_PMD_BOND > one. Once that macro is changed, the issue you report becomes generally > visible. > I also think a release note entry about the macro change would be good. Similarly for the latency stats one, depending on the fix chosen.