From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5BDB1A04B5; Thu, 10 Sep 2020 13:23:19 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 411871BFC3; Thu, 10 Sep 2020 13:23:19 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 7963EDE0 for ; Thu, 10 Sep 2020 13:23:17 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 08ABJbkF017650; Thu, 10 Sep 2020 04:23:11 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=date : from : to : cc : subject : message-id : references : content-type : in-reply-to : mime-version; s=pfpt0220; bh=BePmPW7ldHSlojBxINLUrAyE+MaA1nKkS2v8udAKp/Y=; b=F2gSLzGpYR5mtGQkUk8PrUaorqLNZBLuWv363EvXBZ7XGXUcofKnexuv531oooLT91LR YoPgdntTZBrbGwFVONoZw1mHmQf0KqRX+LFqXOF0MC5griYCRUrVRm9wsJs8ixs64qfN 0lNYwOK8FPhx+HwKoD5z9GkXw9Ena1GpYaFgskG8e4Xl+4ErBU24jJoll2Xze7luW3Wu 0wSyf3Vpg0pLuOu9CgFkaF7MgjBFHONU8Ab17ON1mwbM2qMuoWmmwRDeLmqxGoa7+nx+ H1AL6o4RcSemAQMRQu80fXCLNFPYZT0y0yfpgWghGv4DXrw5Wx3NoFrP+zJEi3V78mdD Nw== Received: from sc-exch03.marvell.com ([199.233.58.183]) by mx0b-0016f401.pphosted.com with ESMTP id 33ff7m8v8g-3 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Thu, 10 Sep 2020 04:23:11 -0700 Received: from DC5-EXCH01.marvell.com (10.69.176.38) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 10 Sep 2020 04:23:10 -0700 Received: from SC-EXCH02.marvell.com (10.93.176.82) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 10 Sep 2020 04:23:09 -0700 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.46) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Thu, 10 Sep 2020 04:23:09 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YjRDJEBsC389QJELZsMkuclviNUbUhgh2jO8fJrzqMjeoNb/741j1VX+IjK2rW9UgQGNlVEwgV6X1KnHdj+BaGQIG0Y/DDJxNFh7FXmLa/Jew7yeoL6ximnu4vUMVE5W3Xh2GtvSoH7+yWEanaGF9r3jXXP7K8EQwfPhQ20i3KSTFNX7ZbKAm6y7GkDNE/TWxV0lKiy1lH7eWXnjgIC9sss5Uy5L2AMrnh2BiKZKNebRtZNq8sxNQWKb8Htfb+g3LMAOmtvd3uKld2PFdjCnQ8BiKfFzCzAr49grEKxXY215Nw1/JJkgezy+k7is9iUZg333weN59fs34kYg0pUfAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BePmPW7ldHSlojBxINLUrAyE+MaA1nKkS2v8udAKp/Y=; b=PqAhW9fNgCXJDK0Vrmcj2rtx4lNVnxnU9o7V1mzR+75J4CxDORew3Ey7/prMqw7d7X30o+6PxbY0T9IWXPoy6Jls+CwwVCPk/3d+9On12g7UP6LO33pLN2Sy4FcRh8SKWqYSZNxhIgK6P203PIUyjd/7Rt32m2L1GlKk1WvH8+vmQl4YleXEnwLbZZ9GOK9kaBu11tS8Wu0JaMkA/4pWTHn9BDUmYbUqI2dlkc2rnJcyuOYRTYX01RQmJLNXkG2fqW62NAfZ6EMgyyg7PGyeDXJ3cnm4vdI5fAOLQ1OJkFok77X9TPhRMQHv1qTRMbOAM1fR1Hc+MiGyzXg54ESG+g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BePmPW7ldHSlojBxINLUrAyE+MaA1nKkS2v8udAKp/Y=; b=WHxfEqqCOe5etyWpUlLwa4qFFv32cReyq3clQwiQsVMBD+w1mgHeymkpcYUWW6dcfpYgBZUbEvDqfA3UfJ8d6EAHvoUVio8WCM0qCjoM36hvgM0ART/9Gnc9b+WGt4/yX9zup7c/6hxddZrVVkkmPmpuA/2UlY6ExLDngGM2lIE= Authentication-Results: ashroe.eu; dkim=none (message not signed) header.d=none;ashroe.eu; dmarc=none action=none header.from=marvell.com; Received: from BN8PR18MB2386.namprd18.prod.outlook.com (2603:10b6:408:68::25) by BN6PR18MB1107.namprd18.prod.outlook.com (2603:10b6:404:69::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3348.17; Thu, 10 Sep 2020 11:23:07 +0000 Received: from BN8PR18MB2386.namprd18.prod.outlook.com ([fe80::69ba:f95b:c06b:150e]) by BN8PR18MB2386.namprd18.prod.outlook.com ([fe80::69ba:f95b:c06b:150e%4]) with mapi id 15.20.3370.016; Thu, 10 Sep 2020 11:23:07 +0000 Date: Thu, 10 Sep 2020 16:52:55 +0530 From: Nithin Dabilpuram To: "Kinsella, Ray" CC: , , , , , , , , , , , , Message-ID: <20200910112255.GD25338@outlook.office365.com> References: <20200909172200.30610-1-ndabilpuram@marvell.com> <20200910080538.28041-1-ndabilpuram@marvell.com> <7c4820d7-d3cb-b985-ffa6-f6ed87d1bf07@ashroe.eu> <20200910105606.GC25338@outlook.office365.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.2 (34cd43c) (2019-09-21) X-ClientProxiedBy: BMXPR01CA0040.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:c::26) To BN8PR18MB2386.namprd18.prod.outlook.com (2603:10b6:408:68::25) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from outlook.office365.com (115.113.156.2) by BMXPR01CA0040.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:c::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3370.16 via Frontend Transport; Thu, 10 Sep 2020 11:23:04 +0000 X-Originating-IP: [115.113.156.2] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c2b0e72e-6c95-4073-40df-08d8557be472 X-MS-TrafficTypeDiagnostic: BN6PR18MB1107: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:913; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: H1E/AKRx2Dd9PV1tkZIeFL4kxNxmasuIhQ0Coxa948AFGgg7oPkFBpUx60TQq7b9xgps9CZsT8bf48GbqDzjhyprIk/3vwapeJahCOzA+jD7zO7tP3deyT1qsnLM9Bzumduoqw+NWr3geWtBExc/oB6vITwCag8M4HLYTBRXbA5Xtp6Yc8AmZ2oVCxTcooBesnsT+0v8Nt92Jnh1+BwILuRmeJiIKLj2ZFZh4vvlQDiOUjpnyotcHizKniQYr251z0crrSGewmigSeQ3O9ZjUw8znFm75AwW4vhCvhdJt0XPBbj9KipF0kNKvvr6dWFcyjFkhKD0vXiTEZJzJCB5OmWJO0b7QBZP5Q6dH2YDAHJin0Y5+7z2G/+5xMY/SnKZMSok8jtjVLtXi0C46cN25g== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN8PR18MB2386.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(396003)(346002)(366004)(376002)(39860400002)(5660300002)(8676002)(55016002)(66946007)(1076003)(33656002)(4326008)(66556008)(9686003)(66476007)(6666004)(7416002)(2906002)(478600001)(86362001)(52116002)(83380400001)(55236004)(6506007)(53546011)(16526019)(107886003)(956004)(316002)(966005)(26005)(186003)(7696005)(6916009)(8936002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: geOwOnOuf7ugCneTWPYP/BPzm/Nm5hXLH/Td/JTyXVxyOflxIHdSu4+6CHhASGeh7GaBslAL3GJrBgJehBcDYnUz2k4d7WvqyNJcEt/CY6ELC6RNec8J9sQa80J9QIx3beIBPXtr8EuMtRKtiK9Ac6cBSrHm59xsL4w5g57qfnnWwZcb/4ofPmWAhTmmCCO3KyQTZyq85dxGT9WB09v16D32FLB2Zc5yREuCWlu6plo9h0PHkZRA9noJe3emlU1ZqfOsBS1G6n+soCklDqUIglvMfmN7KPP2rmtndE73hSbmCjZjPNgb4ZquSobCDGDaC1lvHfQu5IKMNs13ze8EHub+W7CraO4ozBNwgufFcWlq2012x2ntB2z2Xj1Q5xj9QeVOCB0hLtScwt4RCaJrTN5dE2aktUcyLV962i3RTOFCsTRcIKFZJHDvIj/Y4ixBE9uZsODLva+g43LMARvgq9yKNjPxdoL1cqI9zFx+odMmNm8v9dyZAGrKkTybABFW3aGcfvUt5WAQQLXHsSaKgAZmuRbyhGZnO2/YAs29XuzTjY22h5MeZjNLlgiOcl/qE6ThpSMpm78NkfhBHTUvvE4aWi0Lf3Ppv3v+tPcJj55qAAB90Lg+StuRHJBsKazYWLg4YPkq/dF8cISBUWDM0g== X-MS-Exchange-CrossTenant-Network-Message-Id: c2b0e72e-6c95-4073-40df-08d8557be472 X-MS-Exchange-CrossTenant-AuthSource: BN8PR18MB2386.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Sep 2020 11:23:07.7185 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 1k57ppz1kUCuTAtnjnzzTr+Cb8C9eBqmcw6wr55Xao2lZcUFnTyGSiXqCcsTWUkI9FrAqSexveFLnPlt/mORPQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR18MB1107 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235, 18.0.687 definitions=2020-09-10_03:2020-09-10, 2020-09-10 signatures=0 Subject: Re: [dpdk-dev] [EXT] Re: [PATCH v2] ethdev: mark all traffic manager API as experimental X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Sep 10, 2020 at 12:01:49PM +0100, Kinsella, Ray wrote: > > > On 10/09/2020 11:56, Nithin Dabilpuram wrote: > > On Thu, Sep 10, 2020 at 09:30:15AM +0100, Kinsella, Ray wrote: > >> External Email > >> > >> ---------------------------------------------------------------------- > >> On 10/09/2020 09:05, Nithin Dabilpuram wrote: > >>> This patch marks all traffic manager API as experimental as > >>> per discussion mentioned in below thread. > >>> > >>> https://urldefense.proofpoint.com/v2/url?u=https-3A__mails.dpdk.org_archives_dev_2020-2DApril_165364.html&d=DwIDaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=FZ_tPCbgFOh18zwRPO9H0yDx8VW38vuapifdDfc8SFQ&m=NlIUXSsugCPTKBv9qxsaMHOhTuC90TUqLcGg962VVyA&s=DZL_m0a73uef5Qgal1iFqc9dTdAuUd8J6eC0mZOQlFs&e= > >>> > >>> Signed-off-by: Nithin Dabilpuram > >>> --- > >>> > >>> v2: > >>> - Updated commit message. > >>> > >>> lib/librte_ethdev/rte_ethdev_version.map | 62 ++++++++++++++++---------------- > >>> lib/librte_ethdev/rte_tm.h | 33 ++++++++++++++++- > >>> 2 files changed, 64 insertions(+), 31 deletions(-) > >>> > >>> diff --git a/lib/librte_ethdev/rte_ethdev_version.map b/lib/librte_ethdev/rte_ethdev_version.map > >>> index 1212a17..3da4512 100644 > >>> --- a/lib/librte_ethdev/rte_ethdev_version.map > >>> +++ b/lib/librte_ethdev/rte_ethdev_version.map > >>> @@ -135,36 +135,6 @@ DPDK_20.0 { > >>> rte_flow_isolate; > >>> rte_flow_query; > >>> rte_flow_validate; > >>> - rte_tm_capabilities_get; > >>> - rte_tm_get_number_of_leaf_nodes; > >>> - rte_tm_hierarchy_commit; > >>> - rte_tm_level_capabilities_get; > >>> - rte_tm_mark_ip_dscp; > >>> - rte_tm_mark_ip_ecn; > >>> - rte_tm_mark_vlan_dei; > >>> - rte_tm_node_add; > >>> - rte_tm_node_capabilities_get; > >>> - rte_tm_node_cman_update; > >>> - rte_tm_node_delete; > >>> - rte_tm_node_parent_update; > >>> - rte_tm_node_resume; > >>> - rte_tm_node_shaper_update; > >>> - rte_tm_node_shared_shaper_update; > >>> - rte_tm_node_shared_wred_context_update; > >>> - rte_tm_node_stats_read; > >>> - rte_tm_node_stats_update; > >>> - rte_tm_node_suspend; > >>> - rte_tm_node_type_get; > >>> - rte_tm_node_wfq_weight_mode_update; > >>> - rte_tm_node_wred_context_update; > >>> - rte_tm_shaper_profile_add; > >>> - rte_tm_shaper_profile_delete; > >>> - rte_tm_shared_shaper_add_update; > >>> - rte_tm_shared_shaper_delete; > >>> - rte_tm_shared_wred_context_add_update; > >>> - rte_tm_shared_wred_context_delete; > >>> - rte_tm_wred_profile_add; > >>> - rte_tm_wred_profile_delete; > >>> > >>> local: *; > >>> }; > >>> @@ -241,6 +211,38 @@ EXPERIMENTAL { > >>> __rte_ethdev_trace_rx_burst; > >>> __rte_ethdev_trace_tx_burst; > >>> rte_flow_get_aged_flows; > >>> + > >>> + # Marked as experimental in 20.11 > >>> + rte_tm_capabilities_get; > >>> + rte_tm_get_number_of_leaf_nodes; > >>> + rte_tm_hierarchy_commit; > >>> + rte_tm_level_capabilities_get; > >>> + rte_tm_mark_ip_dscp; > >>> + rte_tm_mark_ip_ecn; > >>> + rte_tm_mark_vlan_dei; > >>> + rte_tm_node_add; > >>> + rte_tm_node_capabilities_get; > >>> + rte_tm_node_cman_update; > >>> + rte_tm_node_delete; > >>> + rte_tm_node_parent_update; > >>> + rte_tm_node_resume; > >>> + rte_tm_node_shaper_update; > >>> + rte_tm_node_shared_shaper_update; > >>> + rte_tm_node_shared_wred_context_update; > >>> + rte_tm_node_stats_read; > >>> + rte_tm_node_stats_update; > >>> + rte_tm_node_suspend; > >>> + rte_tm_node_type_get; > >>> + rte_tm_node_wfq_weight_mode_update; > >>> + rte_tm_node_wred_context_update; > >>> + rte_tm_shaper_profile_add; > >>> + rte_tm_shaper_profile_delete; > >>> + rte_tm_shared_shaper_add_update; > >>> + rte_tm_shared_shaper_delete; > >>> + rte_tm_shared_wred_context_add_update; > >>> + rte_tm_shared_wred_context_delete; > >>> + rte_tm_wred_profile_add; > >>> + rte_tm_wred_profile_delete; > >>> }; > >> [SNIP] > >> > >> So I will re-interate what I said in April, all of these API have existed since DPDK 17.08. > >> I find it hard to believe they are all at imminent risk of changing to degree they _all_ warrant EXPERIMENTAL status. > > > > As discussed earlier and agreed by TM and Ethdev maintainers, __rte_experimental tag was introduced several > > releases after TM spec was added and TM spec remained untouched ending up making it stable unintentionally. > > We discussed it I agree, but to identify how this happened. > I am not sure we all agreed it was ok to give a blanket EXPERIMENTAL. > > This API has been largely unchanged for 3 years. > How can we justify keeping EXPERIMENTAL without a specific reason? > Can you be more specific about planned changes? Basically the changes atleast which initiated this discussion were #1 Support to configure shaper in pkt mode that helps ratelimiting in PPS(Packets per Sec) as opposed to BPS(Bits per Sec). Needs change to a lot of existing tm param and capability structs. #2 Support dynamic offload flags based Tx offload for tm packet marking. #3 Support TM node color stats that report per tm color(red, green, yellow) pkt stats. All the above three changes though add significant features and doesn't break existing PMD's. > > > > > Bruce and other maintainers pointed out that we cannot fix it as a "Fixes:" patch in order > > to honor ABI commitments, and suggestion was to change the complete spec back to > > experimental in next ABI change window and proceed with improvements that make > > it stable API in subsequent releases. > >> > >> Ray K