From: Bruce Richardson <bruce.richardson@intel.com>
To: Mairtin o Loingsigh <mairtin.oloingsigh@intel.com>
Cc: jasvinder.singh@intel.com, dev@dpdk.org, brendan.ryan@intel.com,
David.Coyle@intel.com, pablo.de.lara.guarch@intel.com
Subject: Re: [dpdk-dev] [PATCH] net: add support for AVX512 when generating CRC
Date: Thu, 10 Sep 2020 13:27:41 +0100 [thread overview]
Message-ID: <20200910122741.GI1789@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <1599739271-16605-1-git-send-email-mairtin.oloingsigh@intel.com>
On Thu, Sep 10, 2020 at 01:01:11PM +0100, Mairtin o Loingsigh wrote:
> This patch enables the generation of CRC using AVX512 instruction
> set when available on the host platform.
>
> Signed-off-by: Mairtin o Loingsigh <mairtin.oloingsigh@intel.com>
> ---
>
> v1:
> * Initial version, with AVX512 support for CRC32 Ethernet only
> (requires further updates)
> * AVX512 support for CRC16-CCITT and final implementation of
> CRC32 Ethernet will be added in v2
> ---
> doc/guides/rel_notes/release_20_11.rst | 4 +
> lib/librte_net/net_crc_avx.h | 331 ++++++++++++++++++++++++++++++++
> lib/librte_net/rte_net_crc.c | 23 ++-
> lib/librte_net/rte_net_crc.h | 1 +
> 4 files changed, 358 insertions(+), 1 deletions(-)
> create mode 100644 lib/librte_net/net_crc_avx.h
>
<snip>
> --- a/lib/librte_net/rte_net_crc.c
> +++ b/lib/librte_net/rte_net_crc.c
> @@ -10,12 +10,18 @@
> #include <rte_common.h>
> #include <rte_net_crc.h>
>
> -#if defined(RTE_ARCH_X86_64) && defined(RTE_MACHINE_CPUFLAG_PCLMULQDQ)
> +#if defined(RTE_ARCH_X86_64) && defined(RTE_MACHINE_CPUFLAG_PCLMULQDQ) \
> + && defined(RTE_MACHINE_CPUFLAG_AVX512F)
> +#define X86_64_AVX512F_PCLMULQDQ 1
> +#elif defined(RTE_ARCH_X86_64) && defined(RTE_MACHINE_CPUFLAG_PCLMULQDQ)
This all seems to be build-time selection of path. Can you perhaps
investigate adding runtime selection instead, so that this can be used from
distro packages, or DPDK compiled on older systems but used on newer.
See also patchset: http://patches.dpdk.org/project/dpdk/list/?series=11831
which is relevant to this too.
/Bruce
next prev parent reply other threads:[~2020-09-10 12:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-10 12:01 Mairtin o Loingsigh
2020-09-10 12:27 ` Bruce Richardson [this message]
2020-09-10 12:52 ` O'loingsigh, Mairtin
2020-09-29 15:45 ` O'loingsigh, Mairtin
2020-09-11 9:57 ` De Lara Guarch, Pablo
2020-09-29 15:47 ` O'loingsigh, Mairtin
2020-09-29 15:12 ` [dpdk-dev] [PATCH v2 0/2] net: add CRC run-time checks and AVX512/VPCLMULQDQ based CRC Mairtin o Loingsigh
2020-09-29 15:41 ` O'loingsigh, Mairtin
2020-09-29 15:12 ` [dpdk-dev] [PATCH v2 1/2] net: add run-time architecture specific CRC selection Mairtin o Loingsigh
2020-09-29 15:12 ` [dpdk-dev] [PATCH v2 2/2] net: add support for AVX512/VPCLMULQDQ based CRC Mairtin o Loingsigh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200910122741.GI1789@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=David.Coyle@intel.com \
--cc=brendan.ryan@intel.com \
--cc=dev@dpdk.org \
--cc=jasvinder.singh@intel.com \
--cc=mairtin.oloingsigh@intel.com \
--cc=pablo.de.lara.guarch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).