From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B773EA04B5; Fri, 11 Sep 2020 10:35:44 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1018A1C10A; Fri, 11 Sep 2020 10:35:38 +0200 (CEST) Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-eopbgr40057.outbound.protection.outlook.com [40.107.4.57]) by dpdk.org (Postfix) with ESMTP id AF1991C0D4; Fri, 11 Sep 2020 10:35:35 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dDtLchpA2l2RFERhc/q7wQ2V/e6qQVTik019+7z7WnMZ+t028P/JAh29T30Oza0SDiEkmfaO6+Vc90lQCsWKcZ54ai/gN++UDdJumZ+hn2wz5SwQ24TsCKdQPXESjOxDyTdV1z4PY2N3jjoNKdalqfA+x/kdZ3PPOu1oBtz7E4M9Pos7LeuJYLktM/QUNVHQm88CWZg7XHBWh7kOhhFtKSFC3N0q36Y47hIJjRdRaU/eIFVGRScayTau4ufeBIAo9p2vEPzl2d3mslO6NulvGSlDL9o+yftwfODjf5UsILzUU5FzyNpsvcjMnHQjqR3Z1oLXIoI1+6Nx+0K7adeX3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EvWCyDpz9zTtQBdb+PVRepHgeFeC4MjPNLnHm7JFm9o=; b=ZfgFyNASuyKki44bpL1GZRWO9kW2xB60PikpfY2p+8ZkZc5eUl7qfVnIkqZu8CEyqxIUujFRzBuZ6qm4lkW7nelCGtJRnpQmtL/IPdvv1Z0dPEPFLlT/id6lwp2gcmWi+voyOVScL+nIVTdc1vmN9OvxFFXi35Lnd6EksOIxFy+5E/UcX+5blhvj2qkGZie44Qn0FvtgTNlQMkWIge4zVBZ8XIlfzUD6Y/VQlw1eLANwQTANuwYZf2SUcKHSa///2dCLaN9c6FGC4Q21DKH0GxWFinn9xm4LLmCL1tg2RldQsyiSlkYGFHlZcwzNHuc+Nsfj+y6Bl3m3XBXCUM++3w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EvWCyDpz9zTtQBdb+PVRepHgeFeC4MjPNLnHm7JFm9o=; b=D9tAnzbP0f3F8yQUiEXLo2OdARotNc0KERAvZd7LPXVledvrR+HLMsIC8cpbHeHDnhUIDg0Qp4dWcze5CYgly1x6+8uxu5NM7rBOMFyU7QQd51/hMOcudNslfa0H/kRre9n/6suLmYJ5vk4ugMjwy30UMojjf2ZjGee52fR7jk4= Authentication-Results: dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=none action=none header.from=oss.nxp.com; Received: from VI1PR04MB5837.eurprd04.prod.outlook.com (2603:10a6:803:ec::28) by VI1PR04MB6973.eurprd04.prod.outlook.com (2603:10a6:803:13d::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3370.16; Fri, 11 Sep 2020 08:35:35 +0000 Received: from VI1PR04MB5837.eurprd04.prod.outlook.com ([fe80::cc01:9fe2:2544:8a4b]) by VI1PR04MB5837.eurprd04.prod.outlook.com ([fe80::cc01:9fe2:2544:8a4b%7]) with mapi id 15.20.3348.019; Fri, 11 Sep 2020 08:35:34 +0000 From: "Sachin Saxena (OSS)" To: dev@dpdk.org, ferruh.yigit@intel.com Cc: stable@dpdk.org Date: Fri, 11 Sep 2020 14:05:13 +0530 Message-Id: <20200911083520.24020-2-sachin.saxena@oss.nxp.com> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200911083520.24020-1-sachin.saxena@oss.nxp.com> References: <20200911083520.24020-1-sachin.saxena@oss.nxp.com> Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: SG2PR04CA0178.apcprd04.prod.outlook.com (2603:1096:4:14::16) To VI1PR04MB5837.eurprd04.prod.outlook.com (2603:10a6:803:ec::28) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from lsv03161.swis.in-blr01.nxp.com (14.142.151.118) by SG2PR04CA0178.apcprd04.prod.outlook.com (2603:1096:4:14::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.20.3370.16 via Frontend Transport; Fri, 11 Sep 2020 08:35:33 +0000 X-Mailer: git-send-email 2.28.0 X-Originating-IP: [14.142.151.118] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: f8b3f0cb-7fcd-4f3e-a192-08d8562da6bb X-MS-TrafficTypeDiagnostic: VI1PR04MB6973: X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:370; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: P0jkj9ebTGPw9ZPtfzeeJ25zKFUw6ifULz6Q8tm4eNs/DuhO+qWbNlw6FV2qOb1D+WKgbd2SQKZKmDRo3iKjfd+7Z11mOu2fjrqdcBYrt7uC3+PnDBjuMMo9tm6dRNbGOM15dsubz4Q+mKOC+vCesnQFw85K7dVY1czpVtUY4Rjeb80uWll5U77zYRKQH8SymZ+/801liFwBC2Sxyq9CQvNIzR6I/hiwAJQc9C8/y1xXG7o2fme5Fp3ezik7VRLM8GdyEXQlV7jbUEoXuHXy0mplNh7ImE0utc+uVA8FNbuPEAm5Vjxzudvxy7LSSK/JkF6IuATM3ViwG1OKYsZ3Hn+F6r/GS7zx4E8mP3Q5rrQdFkJ45KMIOphn82lptPoX X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR04MB5837.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(376002)(136003)(396003)(39860400002)(366004)(52116002)(86362001)(4326008)(1076003)(66556008)(66946007)(2906002)(66476007)(8936002)(5660300002)(83380400001)(316002)(8676002)(2616005)(956004)(6512007)(16526019)(186003)(6486002)(1006002)(6666004)(26005)(6506007)(478600001)(55236004)(110426005); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: UWSwLe+UbuWFnV3vG+WuSeUskemHjxnxT3cKCxccSOygeIi33Q/FLxWY/3CQJrvoZ4RVnPuGoJW9lrZQnGogsDVAaT3BmuT85exmW+FyC1MFz9pzZtbFyMybIKfp67b++YTziy/MtL9wxuTM3UVu3IGvJo+mYMILNCjgjOvDsX+QGYxsfZgqggJRkXR2tGObQOkAF54kqfHf6rUr7UMTvXfo25SMkBnvSkqtVtWQfbj1XpydRmNJqLvA2Y/rDLH15Tni8LTecJDSsTMcduT6tuHJ9pVHWBy/iRB/6kkyJmaSxh1o9UJK5daHmUUcZRku/FUWmthmz3LJ38OAxmjyZoSGvWG9FDL9nrQcJZWL9r/76RBSQvcQiOm+ozQ4JUyFCLCt/GLirtHpVqfrEJ+kLEhbo90m2ZCrVbLQEIuDtxngMvifsezMxv2UAFY1ec0SccmLnGn2Fn6oWHqgoUKwEUNrdAHKUe439D1nQOYUyWm3iqzn3PYaL5FDQ+WiUUYvQO2gJu5ezF9eSOOls76MpzZhYe1KdVfaMYG/wmbv/yyT994lszTLZyHjimUc98wkJK9UWRZ6IlP5YbAehXWvOmzdBMX57hv78v/Ilw407aR5bK7KT/oGMoHLA+JSEheNSZHmX39K/ba0dFahJNS2ag== X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: f8b3f0cb-7fcd-4f3e-a192-08d8562da6bb X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5837.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Sep 2020 08:35:34.8493 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: J7D/VtuuLcQSjzHNWQEQ6IwU5RUPl5QRUqkDAj7ALyPLvepmySfVaL8sAFi+BSx4O/8I940C/OThdSGPW9VNtw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6973 Subject: [dpdk-dev] [PATCH v2 1/8] bus/fslmc: fix atomic queues on nxp lx2 platform X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Youri Querry Traffic was stalling after few packet while running l2fwd-event in atomic mode on LX2 platform. It was due to wrong dca setting while enqueuing packets to EQCR. This patch fixes the issue by writing correct dca setting. Fixes: 1b49352f41be ("bus/fslmc: rename portal pi index to consumer index") Cc: stable@dpdk.org Signed-off-by: Youri Querry Signed-off-by: Rohit Raj --- drivers/bus/fslmc/qbman/qbman_portal.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/bus/fslmc/qbman/qbman_portal.c b/drivers/bus/fslmc/qbman/qbman_portal.c index 0a2af7be4..77c9d508c 100644 --- a/drivers/bus/fslmc/qbman/qbman_portal.c +++ b/drivers/bus/fslmc/qbman/qbman_portal.c @@ -1201,6 +1201,8 @@ static int qbman_swp_enqueue_multiple_mem_back(struct qbman_swp *s, QBMAN_CENA_SWP_EQCR(eqcr_pi & half_mask)); memcpy(&p[1], &cl[1], 28); memcpy(&p[8], &fd[i], sizeof(*fd)); + p[0] = cl[0] | s->eqcr.pi_vb; + if (flags && (flags[i] & QBMAN_ENQUEUE_FLAG_DCA)) { struct qbman_eq_desc *d = (struct qbman_eq_desc *)p; @@ -1208,7 +1210,6 @@ static int qbman_swp_enqueue_multiple_mem_back(struct qbman_swp *s, ((flags[i]) & QBMAN_EQCR_DCA_IDXMASK); } eqcr_pi++; - p[0] = cl[0] | s->eqcr.pi_vb; if (!(eqcr_pi & half_mask)) s->eqcr.pi_vb ^= QB_VALID_BIT; -- 2.28.0