DPDK patches and discussions
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: David Marchand <david.marchand@redhat.com>
Cc: SteveX Yang <stevex.yang@intel.com>, dev <dev@dpdk.org>,
	Wenzhuo Lu <wenzhuo.lu@intel.com>,
	Beilei Xing <beilei.xing@intel.com>,
	Qiming Yang <qiming.yang@intel.com>,
	Kevin Traynor <ktraynor@redhat.com>,
	Luca Boccassi <bluca@debian.org>,
	Thomas Monjalon <thomas@monjalon.net>,
	Ciara Power <ciara.power@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2] app/test-pmd: fix meson build failed when enabled pmd_bonded
Date: Fri, 11 Sep 2020 15:45:39 +0100
Message-ID: <20200911144539.GC732@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <CAJFAV8x6L1VJHd3drtj1ECt7QqqeR+xEF_sC+CUdwxFgxA5OUw@mail.gmail.com>

On Fri, Sep 11, 2020 at 01:32:15PM +0200, David Marchand wrote:
> On Fri, Sep 11, 2020 at 9:43 AM David Marchand
> <david.marchand@redhat.com> wrote:
> >
> > On Fri, Sep 11, 2020 at 8:15 AM SteveX Yang <stevex.yang@intel.com> wrote:
> > >
> > > The depended pmd bond is missing for test-pmd. Add the pmd_bond to deps,
> > > and replace the relative MACRO name with new RTE_LIBRTE_BOND_PMD.
> >
> > meson changed the name of the driver define (when compared to make).
> 
> It is likely we have other similar issues.
> I excluded the doc, since we have pending patches.
> 
> *Disclaimer* My scripting might be buggy.
> 
> $ git grep -h DIRS-..CONFIG_RTE_ v20.08 -- drivers/*/Makefile |sed -e
> 's#DIRS-$(CONFIG_\(.*\)).*$#\1#' |sort > make.tokens
> $ for meson in drivers/*/meson.build; do dir=$(dirname $meson);
> format=$(git grep 'config_flag_fmt =' $meson |cut -d \' -f 2); for drv
> in $dir/*; do drvname=$(basename $drv |tr '[a-z]' '[A-Z]'); echo
> $format |sed -e "s/@0@/$drvname/"; done; done |sort > meson.tokens
> 
> $ for token in $(diff -u make.tokens meson.tokens |sed -n
> 's/^-\(RTE_LIBRTE.*\)/\1/p'); do output=$(git grep -l "$token\>" --
> :^doc/) || continue; echo $token $output; done
> RTE_LIBRTE_PMD_AESNI_GCM app/test/test_cryptodev.c
> RTE_LIBRTE_PMD_AESNI_MB app/test/test_cryptodev.c
> app/test/test_cryptodev_hash_test_vectors.h
> RTE_LIBRTE_PMD_BOND app/test-pmd/cmdline.c app/test-pmd/parameters.c
> RTE_LIBRTE_PMD_CAAM_JR app/test/test_cryptodev.c
> RTE_LIBRTE_PMD_CCP app/test/test_cryptodev.c
> RTE_LIBRTE_PMD_CRYPTO_SCHEDULER app/test-crypto-perf/main.c
> app/test/meson.build app/test/test_cryptodev.c
> examples/l2fwd-crypto/main.c
> RTE_LIBRTE_PMD_DPAA2_EVENTDEV drivers/bus/fslmc/portal/dpaa2_hw_dpio.c
> RTE_LIBRTE_PMD_DPAA2_SEC app/test/test_cryptodev.c
> RTE_LIBRTE_PMD_DPAA_SEC app/test/test_cryptodev.c
> RTE_LIBRTE_PMD_KASUMI app/test/test_cryptodev.c
> RTE_LIBRTE_PMD_MVSAM_CRYPTO app/test/test_cryptodev.c
> RTE_LIBRTE_PMD_NITROX app/test/test_cryptodev.c
> RTE_LIBRTE_PMD_NULL app/test/test_cryptodev.c
> RTE_LIBRTE_PMD_OCTEONTX2_CRYPTO app/test/test_cryptodev.c
> app/test/test_cryptodev_asym.c
> RTE_LIBRTE_PMD_OCTEONTX_CRYPTO app/test/test_cryptodev.c
> app/test/test_cryptodev_asym.c
> RTE_LIBRTE_PMD_OPENSSL app/test/test_cryptodev.c app/test/test_cryptodev_asym.c
> RTE_LIBRTE_PMD_RING app/test/test_eal_flags.c
> RTE_LIBRTE_PMD_SNOW3G app/test/test_cryptodev.c
> RTE_LIBRTE_PMD_VIRTIO_CRYPTO app/test/test_cryptodev.c
> RTE_LIBRTE_PMD_ZUC app/test/test_cryptodev.c
> RTE_LIBRTE_SFC_EFX_PMD config/arm/meson.build
> 
> Can this be looked at?
> Thanks.
> 
Sure. What do you think we should do for these, do we just document the
change in the documentation, or should we keep strict compatibility by
adding legacy defines?

I don't particularly like keeping the old defines around, since they are
inconsistent in naming, but since we didn't announce a deprecation of the
old values perhaps we should add them in.

Thoughts?

/Bruce

  reply	other threads:[~2020-09-11 14:45 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-10  1:55 [dpdk-dev] [PATCH v1] " SteveX Yang
2020-09-10  9:16 ` Bruce Richardson
2020-09-10 11:12   ` Bruce Richardson
2020-09-11  5:58 ` [dpdk-dev] [PATCH v2] " SteveX Yang
2020-09-11  7:23   ` Yang, Qiming
2020-09-11  7:43   ` David Marchand
2020-09-11  8:36     ` Bruce Richardson
     [not found]       ` <DM6PR11MB436292727A47B651746AB246F9240@DM6PR11MB4362.namprd11.prod.outlook.com>
2020-09-11  9:40         ` Bruce Richardson
     [not found]           ` <DM6PR11MB4362CF8D42FE275B79B84978F9230@DM6PR11MB4362.namprd11.prod.outlook.com>
2020-09-14  8:33             ` Bruce Richardson
2020-09-14 16:24             ` Bruce Richardson
2020-09-11 11:32     ` David Marchand
2020-09-11 14:45       ` Bruce Richardson [this message]
2020-09-14  8:46         ` David Marchand
2020-09-16 16:46       ` Richardson, Bruce
2020-09-15  2:24   ` [dpdk-dev] [PATCH v3] " SteveX Yang
2020-09-30 16:29     ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200911144539.GC732@bricha3-MOBL.ger.corp.intel.com \
    --to=bruce.richardson@intel.com \
    --cc=beilei.xing@intel.com \
    --cc=bluca@debian.org \
    --cc=ciara.power@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=ktraynor@redhat.com \
    --cc=qiming.yang@intel.com \
    --cc=stevex.yang@intel.com \
    --cc=thomas@monjalon.net \
    --cc=wenzhuo.lu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git