From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B9ACBA04B6; Fri, 11 Sep 2020 16:45:49 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0B8091BFCD; Fri, 11 Sep 2020 16:45:49 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id BF7BE1B9B7 for ; Fri, 11 Sep 2020 16:45:46 +0200 (CEST) IronPort-SDR: rhU9Bmas/hUSVAy6qKb+WiVAIlglyoSxp+o+6ajX/VNIJQHx8AhYNB3HuME8PbXWzV6voiMzEt CgkB0XctTndA== X-IronPort-AV: E=McAfee;i="6000,8403,9740"; a="146459655" X-IronPort-AV: E=Sophos;i="5.76,415,1592895600"; d="scan'208";a="146459655" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Sep 2020 07:45:45 -0700 IronPort-SDR: rG09pVDx+djxoG1sQGXkHmgueOfjnj2mi0GkdwLfygNkS1d1r93DqKC8cgFmaoVPCF+sxJTEuD 3et6aozsFhlQ== X-IronPort-AV: E=Sophos;i="5.76,415,1592895600"; d="scan'208";a="450009288" Received: from bricha3-mobl.ger.corp.intel.com ([10.251.81.59]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 11 Sep 2020 07:45:43 -0700 Date: Fri, 11 Sep 2020 15:45:39 +0100 From: Bruce Richardson To: David Marchand Cc: SteveX Yang , dev , Wenzhuo Lu , Beilei Xing , Qiming Yang , Kevin Traynor , Luca Boccassi , Thomas Monjalon , Ciara Power Message-ID: <20200911144539.GC732@bricha3-MOBL.ger.corp.intel.com> References: <20200910015525.59124-1-stevex.yang@intel.com> <20200911055811.16474-1-stevex.yang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [dpdk-dev] [PATCH v2] app/test-pmd: fix meson build failed when enabled pmd_bonded X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Sep 11, 2020 at 01:32:15PM +0200, David Marchand wrote: > On Fri, Sep 11, 2020 at 9:43 AM David Marchand > wrote: > > > > On Fri, Sep 11, 2020 at 8:15 AM SteveX Yang wrote: > > > > > > The depended pmd bond is missing for test-pmd. Add the pmd_bond to deps, > > > and replace the relative MACRO name with new RTE_LIBRTE_BOND_PMD. > > > > meson changed the name of the driver define (when compared to make). > > It is likely we have other similar issues. > I excluded the doc, since we have pending patches. > > *Disclaimer* My scripting might be buggy. > > $ git grep -h DIRS-..CONFIG_RTE_ v20.08 -- drivers/*/Makefile |sed -e > 's#DIRS-$(CONFIG_\(.*\)).*$#\1#' |sort > make.tokens > $ for meson in drivers/*/meson.build; do dir=$(dirname $meson); > format=$(git grep 'config_flag_fmt =' $meson |cut -d \' -f 2); for drv > in $dir/*; do drvname=$(basename $drv |tr '[a-z]' '[A-Z]'); echo > $format |sed -e "s/@0@/$drvname/"; done; done |sort > meson.tokens > > $ for token in $(diff -u make.tokens meson.tokens |sed -n > 's/^-\(RTE_LIBRTE.*\)/\1/p'); do output=$(git grep -l "$token\>" -- > :^doc/) || continue; echo $token $output; done > RTE_LIBRTE_PMD_AESNI_GCM app/test/test_cryptodev.c > RTE_LIBRTE_PMD_AESNI_MB app/test/test_cryptodev.c > app/test/test_cryptodev_hash_test_vectors.h > RTE_LIBRTE_PMD_BOND app/test-pmd/cmdline.c app/test-pmd/parameters.c > RTE_LIBRTE_PMD_CAAM_JR app/test/test_cryptodev.c > RTE_LIBRTE_PMD_CCP app/test/test_cryptodev.c > RTE_LIBRTE_PMD_CRYPTO_SCHEDULER app/test-crypto-perf/main.c > app/test/meson.build app/test/test_cryptodev.c > examples/l2fwd-crypto/main.c > RTE_LIBRTE_PMD_DPAA2_EVENTDEV drivers/bus/fslmc/portal/dpaa2_hw_dpio.c > RTE_LIBRTE_PMD_DPAA2_SEC app/test/test_cryptodev.c > RTE_LIBRTE_PMD_DPAA_SEC app/test/test_cryptodev.c > RTE_LIBRTE_PMD_KASUMI app/test/test_cryptodev.c > RTE_LIBRTE_PMD_MVSAM_CRYPTO app/test/test_cryptodev.c > RTE_LIBRTE_PMD_NITROX app/test/test_cryptodev.c > RTE_LIBRTE_PMD_NULL app/test/test_cryptodev.c > RTE_LIBRTE_PMD_OCTEONTX2_CRYPTO app/test/test_cryptodev.c > app/test/test_cryptodev_asym.c > RTE_LIBRTE_PMD_OCTEONTX_CRYPTO app/test/test_cryptodev.c > app/test/test_cryptodev_asym.c > RTE_LIBRTE_PMD_OPENSSL app/test/test_cryptodev.c app/test/test_cryptodev_asym.c > RTE_LIBRTE_PMD_RING app/test/test_eal_flags.c > RTE_LIBRTE_PMD_SNOW3G app/test/test_cryptodev.c > RTE_LIBRTE_PMD_VIRTIO_CRYPTO app/test/test_cryptodev.c > RTE_LIBRTE_PMD_ZUC app/test/test_cryptodev.c > RTE_LIBRTE_SFC_EFX_PMD config/arm/meson.build > > Can this be looked at? > Thanks. > Sure. What do you think we should do for these, do we just document the change in the documentation, or should we keep strict compatibility by adding legacy defines? I don't particularly like keeping the old defines around, since they are inconsistent in naming, but since we didn't announce a deprecation of the old values perhaps we should add them in. Thoughts? /Bruce