From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id 3D6A9A04C0;
Fri, 11 Sep 2020 18:04:03 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id A9A0A1C0DA;
Fri, 11 Sep 2020 18:03:52 +0200 (CEST)
Received: from mga06.intel.com (mga06.intel.com [134.134.136.31])
by dpdk.org (Postfix) with ESMTP id 7979CDE0
for <dev@dpdk.org>; Fri, 11 Sep 2020 18:03:49 +0200 (CEST)
IronPort-SDR: 4Lf5F5EUab+aekVDwJ4F3dmzeXjJHrhHTspPZ1ikyAMCJlmOcchsPkbhED/qjphz7mgyH8XFDn
IEPMytAFr77g==
X-IronPort-AV: E=McAfee;i="6000,8403,9741"; a="220343456"
X-IronPort-AV: E=Sophos;i="5.76,416,1592895600"; d="scan'208";a="220343456"
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga002.jf.intel.com ([10.7.209.21])
by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
11 Sep 2020 09:03:44 -0700
IronPort-SDR: aRkR6zAKGWkDqWx8yqQhPqt5YROxUcp9GPhWyZWhSab1l0CDqGLCLKf0c+6SxH3bsWWZOwxbmb
s3JVHtjiY4YA==
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.76,416,1592895600"; d="scan'208";a="318321524"
Received: from silpixa00400466.ir.intel.com ([10.237.213.195])
by orsmga002.jf.intel.com with ESMTP; 11 Sep 2020 09:03:42 -0700
From: Conor Walsh <conor.walsh@intel.com>
To: dev@dpdk.org
Cc: david.marchand@redhat.com, ray.kinsella@intel.com, nhorman@tuxdriver.com,
aconole@redhat.com, maicolgabriel@hotmail.com, thomas@monjalon.net,
bruce.richardson@intel.com, Conor Walsh <conor.walsh@intel.com>
Date: Fri, 11 Sep 2020 16:03:29 +0000
Message-Id: <20200911160332.256343-2-conor.walsh@intel.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20200911160332.256343-1-conor.walsh@intel.com>
References: <20200910142121.3995680-1-conor.walsh@intel.com>
<20200911160332.256343-1-conor.walsh@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Subject: [dpdk-dev] [PATCH v3 1/4] devtools: bug fix for gen-abi.sh
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
This patch fixes a bug with the gen-abi.sh script in devtools.
When ran on an install directory the script would try to generate
.dump files from directories as well as the .so files which is
not correct.
Example error: abidw: gcc/lib/librte_net.so.21.0.p is not a regular file
To rectify this the regex that finds the appropriate .so files has been
changed and the file test has been removed.
This change was tested with the ABI_CHECK Travis checks in DPDK 20.08.
Travis build:
https://travis-ci.com/github/conorwalsh-intel/dpdk/jobs/382812849
Signed-off-by: Conor Walsh <conor.walsh@intel.com>
---
devtools/gen-abi.sh | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/devtools/gen-abi.sh b/devtools/gen-abi.sh
index c44b0e228..da6fe0556 100755
--- a/devtools/gen-abi.sh
+++ b/devtools/gen-abi.sh
@@ -16,11 +16,7 @@ fi
dumpdir=$installdir/dump
rm -rf $dumpdir
mkdir -p $dumpdir
-for f in $(find $installdir -name "*.so.*"); do
- if test -L $f; then
- continue
- fi
-
+for f in $(find $installdir -name "*.so"); do
libname=$(basename $f)
abidw --out-file $dumpdir/${libname%.so*}.dump $f
done
--
2.25.1