From: Guinan Sun <guinanx.sun@intel.com> To: dev@dpdk.org Cc: Jeff Guo <jia.guo@intel.com>, Beilei Xing <beilei.xing@intel.com>, Guinan Sun <guinanx.sun@intel.com>, stable@dpdk.org, Galazka Krzysztof <krzysztof.galazka@intel.com> Subject: [dpdk-dev] [PATCH v2 6/7] net/i40e/base: fix PHY config param when enabling EEE Date: Sat, 12 Sep 2020 03:00:38 +0000 Message-ID: <20200912030039.55273-7-guinanx.sun@intel.com> (raw) In-Reply-To: <20200912030039.55273-1-guinanx.sun@intel.com> The i40e_enable_eee function did not copy phy_type_ext field from current PHY configuration retrieved with Get PHY Abilities AQ. It caused a misconfiguration of the PHY on devices supporting 2.5 and 5G speeds and prevented establishing link when only those speeds were selected for advertisement. Fixes: c61bcb0fe1b0 ("net/i40e/base: support Energy Efficient Ethernet") Cc: stable@dpdk.org Signed-off-by: Galazka Krzysztof <krzysztof.galazka@intel.com> Signed-off-by: Guinan Sun <guinanx.sun@intel.com> --- drivers/net/i40e/base/i40e_common.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/i40e/base/i40e_common.c b/drivers/net/i40e/base/i40e_common.c index 3be944e84..8e3db0756 100644 --- a/drivers/net/i40e/base/i40e_common.c +++ b/drivers/net/i40e/base/i40e_common.c @@ -6449,6 +6449,7 @@ enum i40e_status_code i40e_enable_eee(struct i40e_hw *hw, bool enable) /* Cache current configuration */ config.phy_type = abilities.phy_type; + config.phy_type_ext = abilities.phy_type_ext; config.link_speed = abilities.link_speed; config.abilities = abilities.abilities | I40E_AQ_PHY_ENABLE_ATOMIC_LINK; -- 2.17.1
next prev parent reply other threads:[~2020-09-12 3:20 UTC|newest] Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-09-05 2:49 [dpdk-dev] [PATCH 0/9] update i40e base code Guinan Sun 2020-09-05 2:49 ` [dpdk-dev] [PATCH 1/9] net/i40e/base: add VLAN field for input set Guinan Sun 2020-09-07 11:09 ` Ferruh Yigit 2020-09-05 2:49 ` [dpdk-dev] [PATCH 2/9] net/i40e/base: update FW API version Guinan Sun 2020-09-07 11:10 ` Ferruh Yigit 2020-09-05 2:49 ` [dpdk-dev] [PATCH 3/9] net/i40e/base: enable pipe monitor thresholds Guinan Sun 2020-09-07 11:11 ` Ferruh Yigit 2020-09-05 2:49 ` [dpdk-dev] [PATCH 4/9] net/i40e/base: fix missing function header arguments Guinan Sun 2020-09-08 8:03 ` Yang, Qiming 2020-09-05 2:49 ` [dpdk-dev] [PATCH 5/9] net/i40e/base: add support for minimum rollback revision Guinan Sun 2020-09-05 2:49 ` [dpdk-dev] [PATCH 6/9] net/i40e/base: fix Rx only for unicast promisc on VLAN Guinan Sun 2020-09-05 2:49 ` [dpdk-dev] [PATCH 7/9] net/i40e/base: add EEE LPI status check for X722 adapters Guinan Sun 2020-09-05 2:49 ` [dpdk-dev] [PATCH 8/9] net/i40e/base: fix PHY config param when enabling EEE Guinan Sun 2020-09-05 2:49 ` [dpdk-dev] [PATCH 9/9] net/i40e/base: update version Guinan Sun 2020-09-07 6:27 ` [dpdk-dev] [PATCH 0/9] update i40e base code Zhang, Qi Z 2020-09-12 3:00 ` [dpdk-dev] [PATCH v2 0/7] " Guinan Sun 2020-09-12 3:00 ` [dpdk-dev] [PATCH v2 1/7] net/i40e/base: update FW API version Guinan Sun 2020-09-12 3:00 ` [dpdk-dev] [PATCH v2 2/7] net/i40e/base: fix missing function header arguments Guinan Sun 2020-09-12 3:00 ` [dpdk-dev] [PATCH v2 3/7] net/i40e/base: add support for minimum rollback revision Guinan Sun 2020-09-12 3:00 ` [dpdk-dev] [PATCH v2 4/7] net/i40e/base: fix Rx only for unicast promisc on VLAN Guinan Sun 2020-09-12 3:00 ` [dpdk-dev] [PATCH v2 5/7] net/i40e/base: add EEE LPI status check for X722 adapters Guinan Sun 2020-09-12 3:00 ` Guinan Sun [this message] 2020-09-12 3:00 ` [dpdk-dev] [PATCH v2 7/7] net/i40e/base: update version Guinan Sun 2020-09-13 1:56 ` [dpdk-dev] [PATCH v2 0/7] update i40e base code Zhang, Qi Z
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200912030039.55273-7-guinanx.sun@intel.com \ --to=guinanx.sun@intel.com \ --cc=beilei.xing@intel.com \ --cc=dev@dpdk.org \ --cc=jia.guo@intel.com \ --cc=krzysztof.galazka@intel.com \ --cc=stable@dpdk.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git