From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 66712A04C7; Mon, 14 Sep 2020 22:48:43 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3E595FFA; Mon, 14 Sep 2020 22:48:42 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 34AFAE07 for ; Mon, 14 Sep 2020 22:48:40 +0200 (CEST) IronPort-SDR: Uo4LqxCNug1L1SRgDBmE9WHHwbyNqiub+EsHDNkE5nY5s8ZW8DfRVyh8iNbcejfX5HBVPlh9TB g0Rz3+DrOLbw== X-IronPort-AV: E=McAfee;i="6000,8403,9744"; a="158443355" X-IronPort-AV: E=Sophos;i="5.76,427,1592895600"; d="scan'208";a="158443355" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Sep 2020 13:48:38 -0700 IronPort-SDR: zvjUNzrmdGwfynUHl9Angyyb6bMK9zoq1p3jlxHyBZY50Q3yu6Omrx0qzYrlYCalcUTEJOtN/s mLWFvcWfMwVA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,427,1592895600"; d="scan'208";a="319194050" Received: from irvmail001.ir.intel.com ([163.33.26.43]) by orsmga002.jf.intel.com with ESMTP; 14 Sep 2020 13:48:37 -0700 Received: from sivswdev09.ir.intel.com (sivswdev09.ir.intel.com [10.237.217.48]) by irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id 08EKmbFk023138; Mon, 14 Sep 2020 21:48:37 +0100 Received: from sivswdev09.ir.intel.com (localhost [127.0.0.1]) by sivswdev09.ir.intel.com with ESMTP id 08EKmbP0004385; Mon, 14 Sep 2020 21:48:37 +0100 Received: (from lma25@localhost) by sivswdev09.ir.intel.com with LOCAL id 08EKmaeE004381; Mon, 14 Sep 2020 21:48:36 +0100 Date: Mon, 14 Sep 2020 21:48:36 +0100 From: "Liang, Ma" To: Stephen Hemminger Cc: dev@dpdk.org, david.hunt@intel.com, anatoly.burakov@intel.com Message-ID: <20200914204836.GB13240@sivswdev09.ir.intel.com> References: <1597141666-20621-1-git-send-email-liang.j.ma@intel.com> <1599214740-3927-1-git-send-email-liang.j.ma@intel.com> <20200904092320.4eacddd1@hermes.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200904092320.4eacddd1@hermes.lan> Subject: Re: [dpdk-dev] [PATCH v3 1/6] eal: add power management intrinsics X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Stephen, Agree. v4 will address this. Regards Liang On 04 Sep 09:23, Stephen Hemminger wrote: > On Fri, 4 Sep 2020 11:18:55 +0100 > Liang Ma wrote: > > > + * > > + * @return > > + * Architecture-dependent return value. > > + */ > > +static inline int rte_power_monitor(const volatile void *p, > > + const uint64_t expected_value, const uint64_t value_mask, > > + const uint32_t state, const uint64_t tsc_timestamp); > > Since this is generic code, and you are defining the function. > You should have it return -ENOTSUPPORTED or -EINVAL.