DPDK patches and discussions
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: yang_y_yi  <yang_y_yi@163.com>
Cc: "Jiayu Hu" <jiayu.hu@intel.com>,
	yangyi01@inspur.com, thomas@monjalon.net, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v5 2/2] gro: add VXLAN UDP GRO support
Date: Tue, 15 Sep 2020 21:19:15 -0700	[thread overview]
Message-ID: <20200915211915.5df88d8b@hermes.lan> (raw)
In-Reply-To: <36eaaf64.21fb.17494dff30d.Coremail.yang_y_yi@163.com>

On Wed, 16 Sep 2020 11:05:38 +0800 (CST)
yang_y_yi  <yang_y_yi@163.com> wrote:

> No, next_proto_id of inner IP header can clearly identify it is a UDP packet even if it is a no-udp-header ip fragment.

Yes GRO will know its UDP, but it will have no port information (in this packet).
GRO can only safely combine packets from the same flow. Since there is no port in
this packet, it is not sufficient to identify the inner flow.

  reply	other threads:[~2020-09-16  4:19 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-10  9:29 [dpdk-dev] [PATCH v5 0/2] gro: add UDP GRO and " yang_y_yi
2020-09-10  9:29 ` [dpdk-dev] [PATCH v5 1/2] gro: add " yang_y_yi
2020-09-10  9:29 ` [dpdk-dev] [PATCH v5 2/2] gro: add VXLAN " yang_y_yi
     [not found]   ` <20200911042416.GA46174@NPG_DPDK_VIRTIO_jiayuhu_15.sh.intel.com>
     [not found]     ` <1623572b.1b82.1748a63b63f.Coremail.yang_y_yi@163.com>
2020-09-14  4:21       ` Jiayu Hu
2020-09-14  7:11         ` yang_y_yi
2020-09-14  8:26         ` yang_y_yi
2020-09-14  8:50           ` Hu, Jiayu
2020-09-14  9:14             ` yang_y_yi
2020-09-16  2:54               ` Jiayu Hu
2020-09-16  3:05                 ` yang_y_yi
2020-09-16  4:19                   ` Stephen Hemminger [this message]
2020-09-17  2:06                   ` Hu, Jiayu
2020-09-17  2:21                     ` yang_y_yi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200915211915.5df88d8b@hermes.lan \
    --to=stephen@networkplumber.org \
    --cc=dev@dpdk.org \
    --cc=jiayu.hu@intel.com \
    --cc=thomas@monjalon.net \
    --cc=yang_y_yi@163.com \
    --cc=yangyi01@inspur.com \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).