From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 24202A04C7; Wed, 16 Sep 2020 06:19:27 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E41461C115; Wed, 16 Sep 2020 06:19:25 +0200 (CEST) Received: from mail-pg1-f193.google.com (mail-pg1-f193.google.com [209.85.215.193]) by dpdk.org (Postfix) with ESMTP id 8BFA81C113 for ; Wed, 16 Sep 2020 06:19:24 +0200 (CEST) Received: by mail-pg1-f193.google.com with SMTP id 7so3136871pgm.11 for ; Tue, 15 Sep 2020 21:19:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Ruqj/FeUvMkMiicDXo2AHZFsEIj8we+w+Mfz+0wHgjk=; b=aVEW6N8pgC1P/r/ZG6vF0JIilRxz0PaAHyCMZf4SakQ9gvdSsPaCjVEzrSgc7tzXul wcjTi+FvqEXpBHjLy/E2dZc1hpdmYDrbo/yo0Lck8/6mzlRYPykrTj83kkV7Pfn5brrK JffCVG0eZmg+PSdc15t098uJczbqVoqvUyKnehXLGDMO0+xTyuq8lvZthW/N54e1E9v/ Hv6QD1TbaJHxik5gFJJ/My29GMAHvVHAa60cQ7+RSCJdUTez6x7aecQmtk50a1OrgKGx d5dHazbogVvrEiFZYntgq3xCv1kCXyBGLs4NBRdv8YtQ3z3a+UvyufyP5T/+E4IZOgVN HLYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Ruqj/FeUvMkMiicDXo2AHZFsEIj8we+w+Mfz+0wHgjk=; b=olxsXp9QUeEMrJ6mN4vPxaIzzYIwRHPqkN0aKQvdKCpsjMI+DVN+1SjqRm94vUp5nO 3pUdfmJ8odgpLLB1j63ojE7E10+MSZHWs/g7NqAmr/dBszYY76mbAPgsmllLMxf6UMwG gi4Ks4/D5wG5bm9xGHbR/+Jf3IvJCGCanxW0IgTQiHNBzhVJfkwi+EQHHXwv/DFrSPAg T/xtNL0afa3XGluBpSINPhRvxu6F9XHhIXeQ2IFtV8pE0qgjfZgeqoOlPLM3DWaQ7mg3 Pr3T5PgqTmZrwTjgOvpOnKyicnZwopHmphr7+jHUEqWaQpbPxq0VRmJs+F808Ld2P9jV OXyw== X-Gm-Message-State: AOAM531XLMsuRhWklkuOgW2Kr7m4HdTKi3p3VgSC4egjlxT6ZevFoB4T 0TSNnY0akLJPBP2C6wmMa/vPTQ== X-Google-Smtp-Source: ABdhPJzbi2gRC1vxzwvAggi+Ci9VE/9muYferjJvGp7b0RVkG4OlZU6Ut0voGT16iUaBJNxeZZc/UA== X-Received: by 2002:aa7:9a0e:0:b029:142:2501:35e5 with SMTP id w14-20020aa79a0e0000b0290142250135e5mr4772245pfj.69.1600229963530; Tue, 15 Sep 2020 21:19:23 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id q190sm16285662pfq.99.2020.09.15.21.19.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Sep 2020 21:19:23 -0700 (PDT) Date: Tue, 15 Sep 2020 21:19:15 -0700 From: Stephen Hemminger To: yang_y_yi Cc: "Jiayu Hu" , yangyi01@inspur.com, thomas@monjalon.net, dev@dpdk.org Message-ID: <20200915211915.5df88d8b@hermes.lan> In-Reply-To: <36eaaf64.21fb.17494dff30d.Coremail.yang_y_yi@163.com> References: <20200910092914.120452-1-yang_y_yi@163.com> <20200910092914.120452-3-yang_y_yi@163.com> <20200911042416.GA46174@NPG_DPDK_VIRTIO_jiayuhu_15.sh.intel.com> <1623572b.1b82.1748a63b63f.Coremail.yang_y_yi@163.com> <20200914042126.GA15258@NPG_DPDK_VIRTIO_jiayuhu_15.sh.intel.com> <20ddfcd3.5b19.1748bb90144.Coremail.yang_y_yi@163.com> <662209b31e344cfb8994a5b5cdcb0375@intel.com> <778c4739.666a.1748be56189.Coremail.yang_y_yi@163.com> <20200916025424.GA90702@NPG_DPDK_VIRTIO_jiayuhu_15.sh.intel.com> <36eaaf64.21fb.17494dff30d.Coremail.yang_y_yi@163.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v5 2/2] gro: add VXLAN UDP GRO support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, 16 Sep 2020 11:05:38 +0800 (CST) yang_y_yi wrote: > No, next_proto_id of inner IP header can clearly identify it is a UDP packet even if it is a no-udp-header ip fragment. Yes GRO will know its UDP, but it will have no port information (in this packet). GRO can only safely combine packets from the same flow. Since there is no port in this packet, it is not sufficient to identify the inner flow.