From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5A650A04C7; Wed, 16 Sep 2020 06:29:25 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D4F2D1C12F; Wed, 16 Sep 2020 06:29:03 +0200 (CEST) Received: from mail-pf1-f225.google.com (mail-pf1-f225.google.com [209.85.210.225]) by dpdk.org (Postfix) with ESMTP id 23E4E1C11C for ; Wed, 16 Sep 2020 06:28:59 +0200 (CEST) Received: by mail-pf1-f225.google.com with SMTP id d9so3229755pfd.3 for ; Tue, 15 Sep 2020 21:28:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=CS04DoLHTL3t6sQobrmt3yXTjAVQhPUEWSJjB3PNXEQ=; b=A/r3ewbWBljeW6CktlCfKStXRKdoeJH6mvVN7AZaRa8JI+iplue7p7N0ddcLmx3RTs 25NikE15JYu/rxwkQjJgzqJTx3+PFW6K77e5NQu+Tlg+DDNORqV9MEE1TPodyVY7w1VF Bx965UoQokZZxYi47veLvU+VIWek3a1TTgwy0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=CS04DoLHTL3t6sQobrmt3yXTjAVQhPUEWSJjB3PNXEQ=; b=atrgdahWN6qxcyVz08NP+2P6roCvUr/Oma/LXGBDPp60J1H05CdQLPCbUgjxU3n9K7 udQXMFlUS9WRmD2228Eudsi3uxk/RunsohxBfUZEAw54N0F2wDUQOMjxeI4+eJ0aBXGi rPjbrJOApdmRMUoTjeBuSZQvV4g5dRIBMKWZ7STuk97j7qVxJbHdcSnoj8svgEs/v+vE E19y5p4+2eGckIXF13auYEz1vyzIkD8EGpgck3bFFYbDovizuLFzup1Dxg+EtkotquU5 J85we5/1amABh3HQ67eRAn0V1sMGv5oAkAjdFHaUBZ39slAdPU1CBlmkJt1+6aVa7pJE A+xg== X-Gm-Message-State: AOAM533HATaSq0vfBMy5NrAuNeDOSg87H7yNpZ1vlf/K5xLNhJcsDkoj T9xEitVHC3k1237qsqUXBI3eeyXm63SwqnqrFEVfeYUcMys0yXnfJad5FueClurODX8zSRhzq38 231ddsq3nEtrkSjmXu/byqAadNRmG8cDQpGcQZY0A9Vp3kARJuKJp7Cr4RXibRdKxKFXZTVYBlU UR3A== X-Google-Smtp-Source: ABdhPJwO6zJR8qIQv9hmMPPoiRv/tF0IQt/vuVvTmtpeMB+9VXruYeteWTt9zCeNr3QQmHzamfrN1rScE4OP X-Received: by 2002:a63:170d:: with SMTP id x13mr16665792pgl.195.1600230538062; Tue, 15 Sep 2020 21:28:58 -0700 (PDT) Received: from localhost.localdomain ([192.19.223.252]) by smtp-relay.gmail.com with ESMTPS id hk6sm132636pjb.6.2020.09.15.21.28.57 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 15 Sep 2020 21:28:58 -0700 (PDT) X-Relaying-Domain: broadcom.com From: Ajit Khaparde To: dev@dpdk.org Cc: Kishore Padmanabha , Mike Baucom Date: Tue, 15 Sep 2020 21:28:29 -0700 Message-Id: <20200916042851.32914-4-ajit.khaparde@broadcom.com> X-Mailer: git-send-email 2.21.1 (Apple Git-122.3) In-Reply-To: <20200916042851.32914-1-ajit.khaparde@broadcom.com> References: <20200911015603.88359-1-ajit.khaparde@broadcom.com> <20200916042851.32914-1-ajit.khaparde@broadcom.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH v2 03/25] net/bnxt: reject flow offload with invalid MAC X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Kishore Padmanabha Reject offload flows that have broadcast or multicast ethernet addresses. Signed-off-by: Kishore Padmanabha Reviewed-by: Mike Baucom Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/tf_ulp/ulp_rte_parser.c | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/drivers/net/bnxt/tf_ulp/ulp_rte_parser.c b/drivers/net/bnxt/tf_ulp/ulp_rte_parser.c index fcb7c4430..c0339e6ab 100644 --- a/drivers/net/bnxt/tf_ulp/ulp_rte_parser.c +++ b/drivers/net/bnxt/tf_ulp/ulp_rte_parser.c @@ -603,6 +603,19 @@ ulp_rte_l2_proto_type_update(struct ulp_rte_parser_params *param, } } +/* Internal Function to identify broadcast or multicast packets */ +static int32_t +ulp_rte_parser_is_bcmc_addr(const struct rte_ether_addr *eth_addr) +{ + if (rte_is_multicast_ether_addr(eth_addr) || + rte_is_broadcast_ether_addr(eth_addr)) { + BNXT_TF_DBG(DEBUG, + "No support for bcast or mcast addr offload\n"); + return 1; + } + return 0; +} + /* Function to handle the parsing of RTE Flow item Ethernet Header. */ int32_t ulp_rte_eth_hdr_handler(const struct rte_flow_item *item, @@ -625,10 +638,18 @@ ulp_rte_eth_hdr_handler(const struct rte_flow_item *item, field = ulp_rte_parser_fld_copy(¶ms->hdr_field[idx], eth_spec->dst.addr_bytes, size); + /* Todo: work around to avoid multicast and broadcast addr */ + if (ulp_rte_parser_is_bcmc_addr(ð_spec->dst)) + return BNXT_TF_RC_PARSE_ERR; + size = sizeof(eth_spec->src.addr_bytes); field = ulp_rte_parser_fld_copy(field, eth_spec->src.addr_bytes, size); + /* Todo: work around to avoid multicast and broadcast addr */ + if (ulp_rte_parser_is_bcmc_addr(ð_spec->src)) + return BNXT_TF_RC_PARSE_ERR; + field = ulp_rte_parser_fld_copy(field, ð_spec->type, sizeof(eth_spec->type)); -- 2.21.1 (Apple Git-122.3)