From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 732F1A04C7; Wed, 16 Sep 2020 06:30:14 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D665E1C1A3; Wed, 16 Sep 2020 06:29:11 +0200 (CEST) Received: from mail-pl1-f228.google.com (mail-pl1-f228.google.com [209.85.214.228]) by dpdk.org (Postfix) with ESMTP id 9E2A21C190 for <dev@dpdk.org>; Wed, 16 Sep 2020 06:29:07 +0200 (CEST) Received: by mail-pl1-f228.google.com with SMTP id m15so2488945pls.8 for <dev@dpdk.org>; Tue, 15 Sep 2020 21:29:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=jc7fYhoCcKIMxNHBRJQAoCPsDdMHnFoEVasYgDnOk1M=; b=aVr7BeITIEJXWCpp9JlK2AtPNUfvtbsggpL6RStTqOMNYtKzuIr2mhchgIK/oYTxXh jI8SRb6bjNMwVIsir/kQ9WwoPHSlxs2B3W6FEu2k9QIdVB9fmrx+lUeFLl1ZKMZSCTBB MPHXdedZEeJ/hxUXqI7uCQk4YlgBqnlL/46nM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=jc7fYhoCcKIMxNHBRJQAoCPsDdMHnFoEVasYgDnOk1M=; b=Qs0L3Wm+DEa5Ropd9ouR3jui8+Nl8BVrU5wbvCPf2IxyGLl2rz2NuB0fPhiu55vlYc K1nYSBPxBW+nDvQPMAAbSQhPZVNzVPu4xvED+xBWdW92ZmUThWgdaQ0zJcKvDpRU5a1f 0aRNMs7aFqHcrT4PxN3KHpUmr7XuR6KMuTVnjNNyj4+h3N41dCB78GCGkzPvojhEXF2e s10a8TaJlH6NaBmaVp08MCA0fnJ8RdRwkmog3dJY4HkW6eM28ll/S712qeCekQjyM5Op AaOWOQW3Mstw1j0VdUsVx9wjegnL7lK8ARDkRthWKqGNC3BBdjmXkrUqqHjhHqL/J2pq WbUg== X-Gm-Message-State: AOAM532QpjzOu+eP34X1LRPqbnQJSCWvjuJ9a5PtO+0kKiAMpN/G313M qJ3lS+FGaONKdRfN228dCB81jS7+eBSZzCFxS0vgGUsMZKSd0KM+PIDorNIs2TojUfpcf04eoTc 9T82ixASEjfmBgexngyT9U4hTtBO8lbjZ58IwPX62XrFAfo7reRrn0sePOL/jL6D8VcH2UOEbom mKwg== X-Google-Smtp-Source: ABdhPJy43z4aYYL0OoTANIRkH9SJN1H17B1qss9/Dex3qf+SoPtX9Mh5+6n2AGxk4uxDJrwnQV3+DnMtMGZE X-Received: by 2002:a17:90a:1992:: with SMTP id 18mr2299328pji.143.1600230546764; Tue, 15 Sep 2020 21:29:06 -0700 (PDT) Received: from localhost.localdomain ([192.19.223.252]) by smtp-relay.gmail.com with ESMTPS id hk6sm132636pjb.6.2020.09.15.21.29.06 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 15 Sep 2020 21:29:06 -0700 (PDT) X-Relaying-Domain: broadcom.com From: Ajit Khaparde <ajit.khaparde@broadcom.com> To: dev@dpdk.org Cc: Shahaji Bhosle <sbhosle@broadcom.com>, Mike Baucom <michael.baucom@broadcom.com> Date: Tue, 15 Sep 2020 21:28:33 -0700 Message-Id: <20200916042851.32914-8-ajit.khaparde@broadcom.com> X-Mailer: git-send-email 2.21.1 (Apple Git-122.3) In-Reply-To: <20200916042851.32914-1-ajit.khaparde@broadcom.com> References: <20200911015603.88359-1-ajit.khaparde@broadcom.com> <20200916042851.32914-1-ajit.khaparde@broadcom.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH v2 07/25] net/bnxt: add null pointer check for resource manager X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> From: Shahaji Bhosle <sbhosle@broadcom.com> Verify the resource manager has been allocated prior to using it. This can avoid potential segmentation faults. Signed-off-by: Shahaji Bhosle <sbhosle@broadcom.com> Reviewed-by: Mike Baucom <michael.baucom@broadcom.com> Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com> --- drivers/net/bnxt/tf_core/tf_rm.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/drivers/net/bnxt/tf_core/tf_rm.c b/drivers/net/bnxt/tf_core/tf_rm.c index 9aec954db..66a33583b 100644 --- a/drivers/net/bnxt/tf_core/tf_rm.c +++ b/drivers/net/bnxt/tf_core/tf_rm.c @@ -706,6 +706,8 @@ tf_rm_allocate(struct tf_rm_allocate_parms *parms) TF_CHECK_PARMS2(parms, parms->rm_db); rm_db = (struct tf_rm_new_db *)parms->rm_db; + if (!rm_db->db) + return -EINVAL; cfg_type = rm_db->db[parms->db_index].cfg_type; /* Bail out if not controlled by RM */ @@ -772,6 +774,8 @@ tf_rm_free(struct tf_rm_free_parms *parms) TF_CHECK_PARMS2(parms, parms->rm_db); rm_db = (struct tf_rm_new_db *)parms->rm_db; + if (!rm_db->db) + return -EINVAL; cfg_type = rm_db->db[parms->db_index].cfg_type; /* Bail out if not controlled by RM */ @@ -817,6 +821,8 @@ tf_rm_is_allocated(struct tf_rm_is_allocated_parms *parms) TF_CHECK_PARMS2(parms, parms->rm_db); rm_db = (struct tf_rm_new_db *)parms->rm_db; + if (!rm_db->db) + return -EINVAL; cfg_type = rm_db->db[parms->db_index].cfg_type; /* Bail out if not controlled by RM */ @@ -860,6 +866,8 @@ tf_rm_get_info(struct tf_rm_get_alloc_info_parms *parms) TF_CHECK_PARMS2(parms, parms->rm_db); rm_db = (struct tf_rm_new_db *)parms->rm_db; + if (!rm_db->db) + return -EINVAL; cfg_type = rm_db->db[parms->db_index].cfg_type; /* Bail out if not controlled by HCAPI */ @@ -883,6 +891,8 @@ tf_rm_get_hcapi_type(struct tf_rm_get_hcapi_parms *parms) TF_CHECK_PARMS2(parms, parms->rm_db); rm_db = (struct tf_rm_new_db *)parms->rm_db; + if (!rm_db->db) + return -EINVAL; cfg_type = rm_db->db[parms->db_index].cfg_type; /* Bail out if not controlled by HCAPI */ @@ -905,6 +915,8 @@ tf_rm_get_inuse_count(struct tf_rm_get_inuse_count_parms *parms) TF_CHECK_PARMS2(parms, parms->rm_db); rm_db = (struct tf_rm_new_db *)parms->rm_db; + if (!rm_db->db) + return -EINVAL; cfg_type = rm_db->db[parms->db_index].cfg_type; /* Bail out if not controlled by RM */ @@ -937,6 +949,8 @@ tf_rm_check_indexes_in_range(struct tf_rm_check_indexes_in_range_parms *parms) TF_CHECK_PARMS2(parms, parms->rm_db); rm_db = (struct tf_rm_new_db *)parms->rm_db; + if (!rm_db->db) + return -EINVAL; cfg_type = rm_db->db[parms->db_index].cfg_type; /* Bail out if not controlled by RM */ -- 2.21.1 (Apple Git-122.3)