From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CB607A04B6; Thu, 17 Sep 2020 07:33:33 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CBBD71D5A3; Thu, 17 Sep 2020 07:31:21 +0200 (CEST) Received: from mail-lj1-f169.google.com (mail-lj1-f169.google.com [209.85.208.169]) by dpdk.org (Postfix) with ESMTP id EB40E1D583 for ; Thu, 17 Sep 2020 07:31:13 +0200 (CEST) Received: by mail-lj1-f169.google.com with SMTP id k25so917920ljk.0 for ; Wed, 16 Sep 2020 22:31:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=fMRSWuDUq8h4HkN7vPjeZ8tPid29yrJTNMESmMIIVqA=; b=JlTUDOdUyQ/IyZMW6HoOgFSNCSUFzTEy0cFOz6RnnOrik+LY/Y/swUGsj9UQsR5BXL cgutPHEJFV9ABWrmzsnKPx+S5tWBxP4kVvERCbi7qrAiro3JDtRiqnicBepC6tSasETL VauNfPbRlxx1v+POjluXE3Bn8/QNhBddMjqci138aR29gD4L8eeCvzrbRGC3ggHw/cn7 VjfxqEVdMd0RfjtW55CmFVlRTI54P4T7B7FYbxVMHGoGJ92NM/cKlbhL76xaS3CIMHUt RisTINiiAyGpXjrTPiTOs7C2PUJ8PZhGQ1rm3Lg4e0aT5RRdXyeg2QJX9dg4SRYzNUO2 VgvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=fMRSWuDUq8h4HkN7vPjeZ8tPid29yrJTNMESmMIIVqA=; b=UweOMneYOAa9t14BwLbsnt4lcKEiRIsOWPBTZfYWx+FHzNuf6FZnu3HJo/a0jAQ3ZU tmPL2q13wp2/+T+I7s6LqJZuL+1c0wammLYSxaExkI2lWpaN6h9LxT/DvBIrpbV3E8l+ TjgyjcLTxtRtTH72kb30NMI0YFgrUggzcJHqLV/O1BRCNLiWL4c4+XZEIkxYN03smRD5 y/v7FSLy0twI1DCJtTEtuCBBSVeCZyGObKkjMrGkt9oASuZn9u2augM8I8LxwDtkUObc H/QwC2mOcBQ1fBGxwXeVPwdgxJ36gpvZHQ9v0a8vR9kYRQxm+jRe5i1hz0qdwr9WVJQH X/uA== X-Gm-Message-State: AOAM533hI1ytgWInnaepXxa8BdvgyLnv+JsxgOznOih+UJgduut1lBfB eYDOWI/01Gr6iFaT6XWUtmyXXJ5hA20rjQW+ X-Google-Smtp-Source: ABdhPJyUqauF9LtB3mAUraieLOnjx7aBBvg8cJldEQW7qn4SkGmw6ka8T91M2/M0SVIK6zsZx974Zw== X-Received: by 2002:a2e:8705:: with SMTP id m5mr8918019lji.459.1600320673244; Wed, 16 Sep 2020 22:31:13 -0700 (PDT) Received: from mkPC.semihalf.local (193-106-246-138.noc.fibertech.net.pl. [193.106.246.138]) by smtp.gmail.com with ESMTPSA id j3sm5033686lfb.185.2020.09.16.22.31.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Sep 2020 22:31:12 -0700 (PDT) From: Michal Krawczyk To: dev@dpdk.org Cc: gtzalik@amazon.com, igorch@amazon.com, Michal Krawczyk , Marcin Wojtas , Evgeny Schemeilin Date: Thu, 17 Sep 2020 07:30:32 +0200 Message-Id: <20200917053035.1889989-18-mk@semihalf.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200917053035.1889989-1-mk@semihalf.com> References: <20200917053035.1889989-1-mk@semihalf.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH 17/20] net/ena/base: simplify loop copying Rx descs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Checking for the cdesc not being NULL doesn't have any sense if the idx argument is not 0, so it can be skipped, as the error won't be detected anyway. To simplify that, only the 'i' value is being verified and the code is breaking from the infinite loop in case when all descriptors were copied into the buffer. Signed-off-by: Michal Krawczyk Reviewed-by: Igor Chauskin Reviewed-by: Guy Tzalik --- drivers/net/ena/base/ena_eth_com.c | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers/net/ena/base/ena_eth_com.c b/drivers/net/ena/base/ena_eth_com.c index 766643f47b..a35d92fbd3 100644 --- a/drivers/net/ena/base/ena_eth_com.c +++ b/drivers/net/ena/base/ena_eth_com.c @@ -557,10 +557,15 @@ int ena_com_rx_pkt(struct ena_com_io_cq *io_cq, ena_rx_ctx->pkt_offset = cdesc->offset; do { - ena_buf->len = cdesc->length; - ena_buf->req_id = cdesc->req_id; - ena_buf++; - } while ((++i < nb_hw_desc) && (cdesc = ena_com_rx_cdesc_idx_to_ptr(io_cq, cdesc_idx + i))); + ena_buf[i].len = cdesc->length; + ena_buf[i].req_id = cdesc->req_id; + + if (++i >= nb_hw_desc) + break; + + cdesc = ena_com_rx_cdesc_idx_to_ptr(io_cq, cdesc_idx + i); + + } while (1); /* Update SQ head ptr */ io_sq->next_to_comp += nb_hw_desc; -- 2.25.1