From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 622A0A04C0; Thu, 17 Sep 2020 19:02:14 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AD3F21C1AD; Thu, 17 Sep 2020 19:02:13 +0200 (CEST) Received: from mail-pl1-f194.google.com (mail-pl1-f194.google.com [209.85.214.194]) by dpdk.org (Postfix) with ESMTP id 153091C10C for ; Thu, 17 Sep 2020 19:02:11 +0200 (CEST) Received: by mail-pl1-f194.google.com with SMTP id k13so1460574plk.3 for ; Thu, 17 Sep 2020 10:02:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=pio7yPng3h9pMLN4eQISyY48cAjXgBDOpkOoX+ilAWM=; b=OiRCbsObs+bjPz3As9BSUgiBlUs9cZw2Pvjy5Z2S8F+yawfI6C+3EA8wyUQdJinQFr jg82MNXh9eMpXo+76TNKvSWH/iX3Pn7OwngqHQMjPjBQrWjdFq1CEkR1PNHGF5vnqqKo Ej6PiQ8LrTPU8GFWAZUQzFAYRLbk+5togDoKhFENxchWTjtpTEAvgLdeon+AA7TYXLcx /yo/+dNd27SnklO1/ruCh1aGzLgQw2LE59+wDTrnoHGbzA0q9G5flqAzhJ044IiTWviJ R9+ZatPw6/JWQ/WgzQtA6pYrhaaATZuC1f73zAK5ZsSqexuJ3GCl+LH5UTLkOUmzvfPV 1/FA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=pio7yPng3h9pMLN4eQISyY48cAjXgBDOpkOoX+ilAWM=; b=YvcAk+s5+oF5t5OXT5JH3zm2gRwU9Hxg71UCpK3vrEHWsoBas0zsGXKWPfUksJJQql NLjJc+4sC9yEMe35VcrrVGGxBpzytKvGhRzoJRRur3yNQQbNLcnzbckZMeCBeQU7ILMD pm4pll9OTqW1Z3tguPH+NxIpCCVy3CuLZs22Gu4Msu+BG9IvMgV5Q6Uj4S/4adwDSnDz nd0wIjjrLrO9PHe2HhJsGiMPWtOA1cbRhvyMcpqTfBu+w257G0qKEcA0gUuo6g/qzbQn rXoyGDLEfngX2dXQHw+VK9nIkRZYHTg3DbNKtzlTYsMeR9Sc7b35xi84KslY4MtaVhH/ 3HqQ== X-Gm-Message-State: AOAM533r6BRAvlKcxXD35nfBBAuqI9SK50TUZc3dO9SV770eJJRdsY11 SF4PElXZmkDzAAHuJpsX134MfA== X-Google-Smtp-Source: ABdhPJyUt4w22E1nJNnr07G8oQMZzkvAZ4vLSwtKR8xRKOLMOYBwj6GSJlFHcIT+fdMVynr+2d7Tyg== X-Received: by 2002:a17:90a:bd8b:: with SMTP id z11mr9569018pjr.2.1600362130967; Thu, 17 Sep 2020 10:02:10 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id o17sm150764pgb.46.2020.09.17.10.02.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Sep 2020 10:02:10 -0700 (PDT) Date: Thu, 17 Sep 2020 10:02:02 -0700 From: Stephen Hemminger To: Michal Krawczyk Cc: dev@dpdk.org, gtzalik@amazon.com, igorch@amazon.com Message-ID: <20200917100202.52455f14@hermes.lan> In-Reply-To: <20200917053035.1889989-1-mk@semihalf.com> References: <20200917053035.1889989-1-mk@semihalf.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 00/20] Upgrade HAL and add ENI metrics support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, 17 Sep 2020 07:30:15 +0200 Michal Krawczyk wrote: > Hi, > > this patchset contains upgrade of the of the HAL, which, beside some fixes, also > adds possibility for reading ENI metrics from the device. > > Those are further exposed to the DPDK applicaiton using xstats. > > As it's an extra call to the admin queue during a PMD runtime, for multithread > safet the locks had to be added around those functions. > > Michal Krawczyk (20): > net/ena/base: use min/max macros with type conversion > net/ena/base: specify operations of rte_delay > net/ena/base: support 'resource busy' admin status > net/ena/base: exponential delay in polling functions > net/ena/base: fix release of wait event > net/ena/base: remove MMIOWB_NOT_DEFINED ifdef > net/ena/base: rework setup of accelerated LLQ mode > net/ena/base: add ENI stats > net/ena/base: split RSS function and hash getters > net/ena/base: do not use hardcoded RSS key buffer size > net/ena/base: check for RSS key configuration support > net/ena/base: minor style adjustments > net/ena/base: add missing unlikely > net/ena/base: store admin stats as u64 > net/ena/base: add check for meta desc being NULL > net/ena/base: convert values to u32 before shifting > net/ena/base: simplify loop copying Rx descs > net/ena/base: update generation date and commit > net/ena: lock dynamic usages of the admin queue > net/ena: expose ENI stats as additional xstats > > drivers/net/ena/base/ena_com.c | 137 ++++++++++++------ > drivers/net/ena/base/ena_com.h | 57 ++++++-- > .../net/ena/base/ena_defs/ena_admin_defs.h | 56 ++++++- > .../net/ena/base/ena_defs/ena_eth_io_defs.h | 3 +- > drivers/net/ena/base/ena_defs/ena_gen_info.h | 5 +- > drivers/net/ena/base/ena_defs/ena_regs_defs.h | 3 +- > drivers/net/ena/base/ena_eth_com.c | 34 +++-- > drivers/net/ena/base/ena_eth_com.h | 2 +- > drivers/net/ena/base/ena_plat_dpdk.h | 19 ++- > drivers/net/ena/ena_ethdev.c | 86 ++++++++++- > drivers/net/ena/ena_ethdev.h | 34 +++++ > 11 files changed, 344 insertions(+), 92 deletions(-) > Looks good Reviewed-by: Stephen Hemminger