DPDK patches and discussions
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: Kevin Laatz <kevin.laatz@intel.com>
Cc: dev@dpdk.org, marcinx.baran@intel.com, pawelx.modrak@intel.com
Subject: Re: [dpdk-dev] [PATCH] examples/ioat: fix stats print
Date: Thu, 17 Sep 2020 12:34:23 +0100
Message-ID: <20200917113423.GF1568@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <20200917110221.205960-1-kevin.laatz@intel.com>

On Thu, Sep 17, 2020 at 12:02:21PM +0100, Kevin Laatz wrote:
> Currently some of the status string at the top of the stats output is being
> cut off. To fix this, the status string array size has been increased.
> 
> Bugzilla ID: 536
> Fixes: 632bcd9b5d4f ("examples/ioat: print statistics")
> 
> Signed-off-by: Kevin Laatz <kevin.laatz@intel.com>
> ---
>  examples/ioat/ioatfwd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/examples/ioat/ioatfwd.c b/examples/ioat/ioatfwd.c
> index 43a19843ee..8a8c81edfb 100644
> --- a/examples/ioat/ioatfwd.c
> +++ b/examples/ioat/ioatfwd.c
> @@ -168,7 +168,7 @@ print_stats(char *prgname)
>  	struct rte_rawdev_xstats_name *names_xstats;
>  	uint64_t *xstats;
>  	unsigned int *ids_xstats, nb_xstats;
> -	char status_string[120]; /* to print at the top of the output */
> +	char status_string[140]; /* to print at the top of the output */
>  	int status_strlen;
>  	int ret;
>
This seems a rather small increment - normally if a string is too small I'd
bump it up by a serious amount. 255 might be a good value here.

Also, to avoid the display looking strange in case of future truncation
(which is not very likely with a size of 255 if you increment to that), the
final '\n' should be included in the printf rather than in the string
to be printed.

Regards,
/Bruce

  reply	other threads:[~2020-09-17 11:34 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-17 11:02 Kevin Laatz
2020-09-17 11:34 ` Bruce Richardson [this message]
2020-09-17 13:07 ` [dpdk-dev] [PATCH v2] " Kevin Laatz
2020-09-17 13:21   ` Bruce Richardson
2020-10-08 12:44     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200917113423.GF1568@bricha3-MOBL.ger.corp.intel.com \
    --to=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=kevin.laatz@intel.com \
    --cc=marcinx.baran@intel.com \
    --cc=pawelx.modrak@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git