From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 85993A04C8; Fri, 18 Sep 2020 10:33:33 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 91AC51D918; Fri, 18 Sep 2020 10:33:32 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id B9CA51D917 for ; Fri, 18 Sep 2020 10:33:30 +0200 (CEST) IronPort-SDR: qDExhDb4qLDIMUwGgM0VzXMD1ohdQ9haIzebjkpzjfx/LoLrn0v91RgQavZ3FTgT8gf017XOVp oW+uWm9Li3Tw== X-IronPort-AV: E=McAfee;i="6000,8403,9747"; a="244724125" X-IronPort-AV: E=Sophos;i="5.77,274,1596524400"; d="scan'208";a="244724125" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Sep 2020 01:33:28 -0700 IronPort-SDR: 8/1ITGAlHJ0imy6270a6CcsZ1sffFzQlF1tQS1CkJi4QW6g+e/fSXw6zi/1bJkaP9Kh302k6b+ fslul4YI07Zg== X-IronPort-AV: E=Sophos;i="5.77,274,1596524400"; d="scan'208";a="508781431" Received: from bricha3-mobl.ger.corp.intel.com ([10.249.147.177]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 18 Sep 2020 01:33:23 -0700 Date: Fri, 18 Sep 2020 09:33:19 +0100 From: Bruce Richardson To: Stephen Hemminger Cc: Olivier Matz , Dmitry Kozlyuk , dev@dpdk.org, Dmitry Malloy , Narcisa Ana Maria Vasile , Fady Bader , Tal Shnaiderman , "Kadam, Pallavi" , Ray Kinsella , Neil Horman Message-ID: <20200918083319.GA1583@bricha3-MOBL.ger.corp.intel.com> References: <20200620210511.13134-1-dmitry.kozliuk@gmail.com> <20200730210652.14568-1-dmitry.kozliuk@gmail.com> <20200730210652.14568-2-dmitry.kozliuk@gmail.com> <20200917133443.GR21395@platinum> <20200917100548.37f7cfb0@hermes.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200917100548.37f7cfb0@hermes.lan> Subject: Re: [dpdk-dev] [PATCH v2 1/7] cmdline: make implementation opaque X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Sep 17, 2020 at 10:05:48AM -0700, Stephen Hemminger wrote: > On Thu, 17 Sep 2020 15:34:43 +0200 > Olivier Matz wrote: > > > Hi Dmitry, > > > > On Fri, Jul 31, 2020 at 12:06:45AM +0300, Dmitry Kozlyuk wrote: > > > struct cmdline exposes platform-specific members it contains, most > > > notably struct termios that is only available on Unix. Make the > > > structure opaque. > > > > > > Remove tests checking struct cmdline content as meaningless. > > > > > > Add cmdline_get_rdline() to access history buffer. > > > The new function is currently used only in tests. > > > > > > Signed-off-by: Dmitry Kozlyuk > > > > First, please forgive me for the very late feedback. It is all the more > > problematic because I think this patch introduces an ABI breakage, that > > should have been announced. > > Since 20.11 is a API/ABI breaking release, I think breaking ABI > is okay without announcement. What matters more is if that API would > need to be impacted. API changes need some announcement. This is something that we need to get a clear decision from technical board on, I think, since there are some other proposed ABI changes in patches that were not pre-announced, e.g. changing the lpm structure.