From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 85153A04C8; Fri, 18 Sep 2020 14:11:52 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1262E1DA09; Fri, 18 Sep 2020 14:11:52 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id E09F71DA06 for ; Fri, 18 Sep 2020 14:11:49 +0200 (CEST) IronPort-SDR: nNccJIhWpHSeW98wZ/nLPB4JEWhnyOexxju88DtXBYVPRfG296EsZwbx9YAIaIeV+LKSba9BSV alD5GchMSylw== X-IronPort-AV: E=McAfee;i="6000,8403,9747"; a="160842560" X-IronPort-AV: E=Sophos;i="5.77,274,1596524400"; d="scan'208";a="160842560" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Sep 2020 05:11:48 -0700 IronPort-SDR: m9v00Nc2J15axYEXMcvuxGrUpswIbIMu7p8QVrCinJwhSdSNZ/ZHJI7M6ga4ecLZUKc2o9YXbA eC5qH9xiGliQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,274,1596524400"; d="scan'208";a="410271184" Received: from silpixa00400466.ir.intel.com ([10.237.213.195]) by fmsmga001.fm.intel.com with ESMTP; 18 Sep 2020 05:11:46 -0700 From: Conor Walsh To: dev@dpdk.org Cc: david.marchand@redhat.com, ray.kinsella@intel.com, nhorman@tuxdriver.com, aconole@redhat.com, maicolgabriel@hotmail.com, thomas@monjalon.net, bruce.richardson@intel.com, anatoly.burakov@intel.com, Conor Walsh Date: Fri, 18 Sep 2020 12:11:33 +0000 Message-Id: <20200918121137.1370883-1-conor.walsh@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200911160332.256343-1-conor.walsh@intel.com> References: <20200911160332.256343-1-conor.walsh@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH v4 0/4] abi breakage checks for meson X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" This patchset allows developers to check ABI breakages during build time. Currently checking that the DPDK ABI has not changed before up-streaming code is not intuitive. The current method, requires the contributor to use either the test-build.sh and test-meson-build.sh tools, along side some environmental variables to test their changes. Contributors in many cases are either unaware or unable to do this themselves, leading to a potentially serious situation where they are unknowingly up-streaming code that breaks the ABI. These breakages are then caught by Travis, but it is more efficient if this is caught locally before up-streaming. --- v4: - Reworked both Python scripts to use more native Python functions and modules. - Python scripts are now in line with how other Python scripts in DPDK are structured. v3: - Fix for bug which now allows meson < 0.48.0 to be used - Various coding style changes throughout - Minor bug fixes to the various meson.build files v2: Spelling mistake, corrected spelling of environmental Conor Walsh (4): devtools: bug fix for gen-abi.sh devtools: add generation of compressed abi dump archives buildtools: add script to setup abi checks for meson build: add abi breakage checks to meson buildtools/abi-setup.py | 141 +++++++++++++++++++++++++++++++++++ buildtools/meson.build | 18 +++++ config/meson.build | 15 ++++ devtools/gen-abi-tarball.py | 142 ++++++++++++++++++++++++++++++++++++ devtools/gen-abi.sh | 6 +- drivers/meson.build | 14 ++++ lib/meson.build | 14 ++++ meson_options.txt | 2 + 8 files changed, 347 insertions(+), 5 deletions(-) create mode 100755 buildtools/abi-setup.py create mode 100755 devtools/gen-abi-tarball.py -- 2.25.1