From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E842EA04C8; Sat, 19 Sep 2020 00:11:28 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 224881DB2E; Sat, 19 Sep 2020 00:11:28 +0200 (CEST) Received: from mail-pg1-f194.google.com (mail-pg1-f194.google.com [209.85.215.194]) by dpdk.org (Postfix) with ESMTP id E49841DB22 for ; Sat, 19 Sep 2020 00:11:26 +0200 (CEST) Received: by mail-pg1-f194.google.com with SMTP id k14so4250595pgi.9 for ; Fri, 18 Sep 2020 15:11:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=+4WkkIT7O2m0X3iUGKYafpsKjwwgJhIcocCKdZAxJ84=; b=v1YuyjZ69ZsAf839b648ExXs+5fnhRpubofh9j94HBIMw9bYF8BqtE1NAaXNAfr2i0 pELRk6XBMVOe/G5Dn5sAEjq5yWRxHnKI99H1WnVzqontDA3xTBw9cXkhtKyzvBz824LG HMNcz4NiEn4diR/xqwigbQa/19XfQli3JvwOWwKk4x2jmKWnPIfl6VeDWc0QqxPB98Go c8x801BIo8Kq0LCQoTz/KjMENk93vU6FBuOYLVutpq547W2Of3vVMDg627ZBe9g9Y9XP jRorR4ZJZdJ9Iq8546BFauFGkA7+wxk733/ETalJPwjw3+CSiqXSjDmmimfP9wd8uws3 WzwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=+4WkkIT7O2m0X3iUGKYafpsKjwwgJhIcocCKdZAxJ84=; b=iBQA1N/2LrwQhRE23WOKk8oE5l7mLvBPsYq34eKBeIVyhbnl0q3ZMQWW9DtQHTgQ4v FEnx1G3hB6xNDIqS1aTDY6byYk9IArx79tFpPKyWe8UZrRD84oAsSqq61DE7zpvdcruy IxKyiQyqE+u72GkuPh2H2sZSIi8UDLBA7zADnHbqnMiwU/Wcb+TxKRHKu2WJJInsKxJ+ iG8Arxy9h3o7uqH0Q+PCpfORbu6WpunNNHIS928vV7xh24j/HOMGpP+e2wB3ymj9LyEh 0GLscpVj7ORRJsFSlhVq1fKiC8dYyabVcTFmvVQ0CJi8HgSzccMPUaB+pW04c0rRTDfU sc3Q== X-Gm-Message-State: AOAM531Jl6WpLvSmcgDB7DcJn/RhngGzqULcF9Gop6zKzrhEgVmAhOCO Tu0VNNv0r9ncOjcT1yaTwTeBZw== X-Google-Smtp-Source: ABdhPJxm/zzCZloWttGw0TFnZPdn/xeonyW8NdyzWetB5ti5HSZK8MVchYQCzDHNig/0bQhEBVy2Tw== X-Received: by 2002:a63:d65:: with SMTP id 37mr4589681pgn.139.1600467085917; Fri, 18 Sep 2020 15:11:25 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id l21sm3842458pjq.54.2020.09.18.15.11.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Sep 2020 15:11:25 -0700 (PDT) Date: Fri, 18 Sep 2020 15:11:17 -0700 From: Stephen Hemminger To: Chengchang Tang Cc: , , , , , , Message-ID: <20200918151117.59037ea6@hermes.lan> In-Reply-To: <975a84de-1455-737d-25a0-cc5f37cf31d8@huawei.com> References: <1592483709-7076-1-git-send-email-tangchengchang@huawei.com> <1599296854-56620-1-git-send-email-tangchengchang@huawei.com> <1599296854-56620-4-git-send-email-tangchengchang@huawei.com> <20200905095859.743243bb@hermes.lan> <975a84de-1455-737d-25a0-cc5f37cf31d8@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v4 3/5] app/procinfo: add Rx buffer size to --show-port X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, 7 Sep 2020 17:14:48 +0800 Chengchang Tang wrote: > On 2020/9/6 0:59, Stephen Hemminger wrote: > > On Sat, 5 Sep 2020 17:07:32 +0800 > > Chengchang Tang wrote: > > > >> printf("\t -- queue %d rx scatter %d" > >> " descriptors %d" > >> + " rx buffer size %d" > >> " offloads 0x%"PRIx64 > >> " mempool socket %d\n", > >> j, > >> queue_info.scattered_rx, > >> queue_info.nb_desc, > >> + queue_info.rx_buf_size, > >> queue_info.conf.offloads, > >> queue_info.mp->socket_id); > >> } > > > > These should be using %u and need space after " for PRIx64 > > Why not: > > printf("\t -- queue %u rx scatter %u" > > " descriptors %u" > > " rx buffer size %u" > > " offloads %#" PRIx64 > > " mempool socket %d\n", > > > > OK, I will fix these in next version. > > Thanks NAK, these is superseded by. Please look at the new improved procinfo still stuck in patchwork https://patchwork.dpdk.org/patch/74960/ Let's put the buffer size there.