DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH 1/4] net/qede: fix build with gcc 11
@ 2020-09-21 13:38 Ferruh Yigit
  2020-09-21 13:38 ` [dpdk-dev] [PATCH 2/4] raw/dpaa2: " Ferruh Yigit
                   ` (3 more replies)
  0 siblings, 4 replies; 14+ messages in thread
From: Ferruh Yigit @ 2020-09-21 13:38 UTC (permalink / raw)
  To: Rasesh Mody, Shahed Shaikh; +Cc: dev, Ferruh Yigit

Error observed with gcc 11 under development
gcc (GCC) 11.0.0 20200920 (experimental)

build error:
../drivers/net/qede/qede_main.c: In function ‘qed_get_current_link’:
../drivers/net/qede/qede_main.c:587:17:
	warning: this ‘if’ clause does not guard...
                 [-Wmisleading-indentation]
  587 |                 if (!ptt)
      |                 ^~
../drivers/net/qede/qede_main.c:590:25:
	note: ...this statement, but the latter is misleadingly indented
              as if it were guarded by the ‘if’
  590 |                         qed_fill_link(hwfn, ptt, if_link);
      |                         ^~~~~~~~~~~~~

Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
I am not clear what the exact intention of the original code is,
compiler warning is about wrong indentation of 'qed_fill_link(..)', I
have updated the code to keep the behavior same but fix the indentation.
Please send a proper fix if the existing behavior needs to be updated.
---
 drivers/net/qede/qede_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/qede/qede_main.c b/drivers/net/qede/qede_main.c
index aecb98261..0f82568d3 100644
--- a/drivers/net/qede/qede_main.c
+++ b/drivers/net/qede/qede_main.c
@@ -587,7 +587,7 @@ qed_get_current_link(struct ecore_dev *edev, struct qed_link_output *if_link)
 		if (!ptt)
 			DP_NOTICE(hwfn, true, "Failed to fill link; No PTT\n");
 
-			qed_fill_link(hwfn, ptt, if_link);
+		qed_fill_link(hwfn, ptt, if_link);
 
 		if (ptt)
 			ecore_ptt_release(hwfn, ptt);
-- 
2.26.2


^ permalink raw reply	[flat|nested] 14+ messages in thread

* [dpdk-dev] [PATCH 2/4] raw/dpaa2: fix build with gcc 11
  2020-09-21 13:38 [dpdk-dev] [PATCH 1/4] net/qede: fix build with gcc 11 Ferruh Yigit
@ 2020-09-21 13:38 ` Ferruh Yigit
       [not found]   ` <CAJFAV8wAio=NF2eMMx9URkNinht2sPtBrE9k1c0uD+_GJcM4aw@mail.gmail.com>
  2020-09-21 13:38 ` [dpdk-dev] [PATCH 3/4] app/testpmd: " Ferruh Yigit
                   ` (2 subsequent siblings)
  3 siblings, 1 reply; 14+ messages in thread
From: Ferruh Yigit @ 2020-09-21 13:38 UTC (permalink / raw)
  To: Nipun Gupta; +Cc: dev, Ferruh Yigit

Error observed with gcc 11 under development
gcc (GCC) 11.0.0 20200920 (experimental)

build error:
../drivers/raw/dpaa2_qdma/dpaa2_qdma.c: In function ‘rte_qdma_reset’:
../drivers/raw/dpaa2_qdma/dpaa2_qdma.c:454:17:
	warning: this ‘if’ clause does not guard...
	[-Wmisleading-indentation]
  454 |         if (qdma_vqs[i].in_use && (qdma_vqs[i].num_enqueues !=
      |         ^~
../drivers/raw/dpaa2_qdma/dpaa2_qdma.c:457:25:
	note: ...this statement, but the latter is misleadingly indented
	as if it were guarded by the ‘if’
  457 |                         return -EBUSY;
      |                         ^~~~~~

Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
 drivers/raw/dpaa2_qdma/dpaa2_qdma.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/raw/dpaa2_qdma/dpaa2_qdma.c b/drivers/raw/dpaa2_qdma/dpaa2_qdma.c
index 0b9c4e3d7..2cba71c63 100644
--- a/drivers/raw/dpaa2_qdma/dpaa2_qdma.c
+++ b/drivers/raw/dpaa2_qdma/dpaa2_qdma.c
@@ -452,9 +452,10 @@ rte_qdma_reset(void)
 	/* In case there are pending jobs on any VQ, return -EBUSY */
 	for (i = 0; i < qdma_dev.max_vqs; i++) {
 		if (qdma_vqs[i].in_use && (qdma_vqs[i].num_enqueues !=
-		    qdma_vqs[i].num_dequeues))
+			    qdma_vqs[i].num_dequeues)) {
 			DPAA2_QDMA_ERR("Jobs are still pending on VQ: %d", i);
 			return -EBUSY;
+		}
 	}
 
 	/* Reset HW queues */
-- 
2.26.2


^ permalink raw reply	[flat|nested] 14+ messages in thread

* [dpdk-dev] [PATCH 3/4] app/testpmd: fix build with gcc 11
  2020-09-21 13:38 [dpdk-dev] [PATCH 1/4] net/qede: fix build with gcc 11 Ferruh Yigit
  2020-09-21 13:38 ` [dpdk-dev] [PATCH 2/4] raw/dpaa2: " Ferruh Yigit
@ 2020-09-21 13:38 ` Ferruh Yigit
  2020-09-24  9:31   ` David Marchand
                     ` (2 more replies)
  2020-09-21 13:38 ` [dpdk-dev] [PATCH 4/4] pmdinfogen: " Ferruh Yigit
  2020-09-25  4:27 ` [dpdk-dev] [EXT] [PATCH 1/4] net/qede: " Rasesh Mody
  3 siblings, 3 replies; 14+ messages in thread
From: Ferruh Yigit @ 2020-09-21 13:38 UTC (permalink / raw)
  To: Wenzhuo Lu, Beilei Xing, Bernard Iremonger; +Cc: dev, Ferruh Yigit

Error observed with gcc 11 under development
gcc (GCC) 11.0.0 20200920 (experimental)

../app/test-pmd/config.c:1777:61:
	warning: argument 3 of type ‘const uint32_t[n]’
	{aka ‘const unsigned int[n]’} declared as a variable length
	array [-Wvla-parameter]
 1777 | port_flow_list(portid_t port_id, uint32_t n,
 			const uint32_t group[n])
      |                 ~~~~~~~~~~~~~~~^~~~~~~~
In file included from ../app/test-pmd/config.c:53:
../app/test-pmd/testpmd.h:764:67:
	note: previously declared as a pointer ‘const uint32_t *’
	{aka ‘const unsigned int *’}
  764 | void port_flow_list(portid_t port_id, uint32_t n,
  				const uint32_t *group);
      |                         ~~~~~~~~~~~~~~~~^~~~~

Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
 app/test-pmd/config.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
index b6eb2a57a..380f3b5f6 100644
--- a/app/test-pmd/config.c
+++ b/app/test-pmd/config.c
@@ -1774,7 +1774,7 @@ port_flow_aged(portid_t port_id, uint8_t destroy)
 
 /** List flow rules. */
 void
-port_flow_list(portid_t port_id, uint32_t n, const uint32_t group[n])
+port_flow_list(portid_t port_id, uint32_t n, const uint32_t *group)
 {
 	struct rte_port *port;
 	struct port_flow *pf;
-- 
2.26.2


^ permalink raw reply	[flat|nested] 14+ messages in thread

* [dpdk-dev] [PATCH 4/4] pmdinfogen: fix build with gcc 11
  2020-09-21 13:38 [dpdk-dev] [PATCH 1/4] net/qede: fix build with gcc 11 Ferruh Yigit
  2020-09-21 13:38 ` [dpdk-dev] [PATCH 2/4] raw/dpaa2: " Ferruh Yigit
  2020-09-21 13:38 ` [dpdk-dev] [PATCH 3/4] app/testpmd: " Ferruh Yigit
@ 2020-09-21 13:38 ` Ferruh Yigit
  2020-09-24  9:32   ` David Marchand
  2020-09-25  4:27 ` [dpdk-dev] [EXT] [PATCH 1/4] net/qede: " Rasesh Mody
  3 siblings, 1 reply; 14+ messages in thread
From: Ferruh Yigit @ 2020-09-21 13:38 UTC (permalink / raw)
  To: Neil Horman; +Cc: dev, Ferruh Yigit

Error observed with gcc 11 under development
gcc (GCC) 11.0.0 20200920 (experimental)

build error:
In file included from ../buildtools/pmdinfogen/pmdinfogen.c:17:
../buildtools/pmdinfogen/pmdinfogen.c: In function ‘parse_elf’:
../buildtools/pmdinfogen/pmdinfogen.h:78:1:
	warning: this ‘else’ clause does not guard...
	[-Wmisleading-indentation]
   78 | else \
      | ^~~~
../buildtools/pmdinfogen/pmdinfogen.h:83:35:
	note: in expansion of macro ‘CONVERT_NATIVE’
   83 | #define TO_NATIVE(fend, width, x) CONVERT_NATIVE(fend, width, x)
      |                                   ^~~~~~~~~~~~~~
../buildtools/pmdinfogen/pmdinfogen.c:152:28:
	note: in expansion of macro ‘TO_NATIVE’
  152 |         hdr->e_type      = TO_NATIVE(endian, 16, hdr->e_type);
      |                            ^~~~~~~~~
../buildtools/pmdinfogen/pmdinfogen.h:80:9:
	note: ...this statement, but the latter is misleadingly indented
	as if it were guarded by the ‘else’
   80 |         ___x; \
      |         ^~~~

Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
 buildtools/pmdinfogen/pmdinfogen.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/buildtools/pmdinfogen/pmdinfogen.h b/buildtools/pmdinfogen/pmdinfogen.h
index 93930e454..38fd3ddcc 100644
--- a/buildtools/pmdinfogen/pmdinfogen.h
+++ b/buildtools/pmdinfogen/pmdinfogen.h
@@ -77,7 +77,7 @@ if ((fend) == ELFDATA2LSB) \
 	___x = le##width##toh(x); \
 else \
 	___x = be##width##toh(x); \
-	___x; \
+___x; \
 })
 
 #define TO_NATIVE(fend, width, x) CONVERT_NATIVE(fend, width, x)
-- 
2.26.2


^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [dpdk-dev] [PATCH 3/4] app/testpmd: fix build with gcc 11
  2020-09-21 13:38 ` [dpdk-dev] [PATCH 3/4] app/testpmd: " Ferruh Yigit
@ 2020-09-24  9:31   ` David Marchand
  2020-10-04  8:57     ` Asaf Penso
  2020-09-24 11:01   ` Phil Yang
  2020-10-08 10:48   ` David Marchand
  2 siblings, 1 reply; 14+ messages in thread
From: David Marchand @ 2020-09-24  9:31 UTC (permalink / raw)
  To: Ferruh Yigit
  Cc: Wenzhuo Lu, Beilei Xing, Bernard Iremonger, dev, Adrien Mazarguil

On Mon, Sep 21, 2020 at 3:39 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>
> Error observed with gcc 11 under development
> gcc (GCC) 11.0.0 20200920 (experimental)
>
> ../app/test-pmd/config.c:1777:61:
>         warning: argument 3 of type ‘const uint32_t[n]’
>         {aka ‘const unsigned int[n]’} declared as a variable length
>         array [-Wvla-parameter]
>  1777 | port_flow_list(portid_t port_id, uint32_t n,
>                         const uint32_t group[n])
>       |                 ~~~~~~~~~~~~~~~^~~~~~~~
> In file included from ../app/test-pmd/config.c:53:
> ../app/test-pmd/testpmd.h:764:67:
>         note: previously declared as a pointer ‘const uint32_t *’
>         {aka ‘const unsigned int *’}
>   764 | void port_flow_list(portid_t port_id, uint32_t n,
>                                 const uint32_t *group);
>       |                         ~~~~~~~~~~~~~~~~^~~~~
>

It won't hurt to backport this.

Fixes: 938a184a1870 ("app/testpmd: implement basic support for flow API")
Cc: stable@dpdk.org

> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
>  app/test-pmd/config.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
> index b6eb2a57a..380f3b5f6 100644
> --- a/app/test-pmd/config.c
> +++ b/app/test-pmd/config.c
> @@ -1774,7 +1774,7 @@ port_flow_aged(portid_t port_id, uint8_t destroy)
>
>  /** List flow rules. */
>  void
> -port_flow_list(portid_t port_id, uint32_t n, const uint32_t group[n])
> +port_flow_list(portid_t port_id, uint32_t n, const uint32_t *group)
>  {
>         struct rte_port *port;
>         struct port_flow *pf;
> --
> 2.26.2
>

Reviewed-by: David Marchand <david.marchand@redhat.com>

-- 
David Marchand


^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [dpdk-dev] [PATCH 4/4] pmdinfogen: fix build with gcc 11
  2020-09-21 13:38 ` [dpdk-dev] [PATCH 4/4] pmdinfogen: " Ferruh Yigit
@ 2020-09-24  9:32   ` David Marchand
  2020-10-08 10:48     ` David Marchand
  0 siblings, 1 reply; 14+ messages in thread
From: David Marchand @ 2020-09-24  9:32 UTC (permalink / raw)
  To: Ferruh Yigit; +Cc: Neil Horman, dev

On Mon, Sep 21, 2020 at 3:39 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>
> Error observed with gcc 11 under development
> gcc (GCC) 11.0.0 20200920 (experimental)
>
> build error:
> In file included from ../buildtools/pmdinfogen/pmdinfogen.c:17:
> ../buildtools/pmdinfogen/pmdinfogen.c: In function ‘parse_elf’:
> ../buildtools/pmdinfogen/pmdinfogen.h:78:1:
>         warning: this ‘else’ clause does not guard...
>         [-Wmisleading-indentation]
>    78 | else \
>       | ^~~~
> ../buildtools/pmdinfogen/pmdinfogen.h:83:35:
>         note: in expansion of macro ‘CONVERT_NATIVE’
>    83 | #define TO_NATIVE(fend, width, x) CONVERT_NATIVE(fend, width, x)
>       |                                   ^~~~~~~~~~~~~~
> ../buildtools/pmdinfogen/pmdinfogen.c:152:28:
>         note: in expansion of macro ‘TO_NATIVE’
>   152 |         hdr->e_type      = TO_NATIVE(endian, 16, hdr->e_type);
>       |                            ^~~~~~~~~
> ../buildtools/pmdinfogen/pmdinfogen.h:80:9:
>         note: ...this statement, but the latter is misleadingly indented
>         as if it were guarded by the ‘else’
>    80 |         ___x; \
>       |         ^~~~
>


Fixes: 98b0fdb0ffc6 ("pmdinfogen: add buildtools and pmdinfogen utility")
Cc: stable@dpdk.org

> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
>  buildtools/pmdinfogen/pmdinfogen.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/buildtools/pmdinfogen/pmdinfogen.h b/buildtools/pmdinfogen/pmdinfogen.h
> index 93930e454..38fd3ddcc 100644
> --- a/buildtools/pmdinfogen/pmdinfogen.h
> +++ b/buildtools/pmdinfogen/pmdinfogen.h
> @@ -77,7 +77,7 @@ if ((fend) == ELFDATA2LSB) \
>         ___x = le##width##toh(x); \
>  else \
>         ___x = be##width##toh(x); \
> -       ___x; \
> +___x; \
>  })
>
>  #define TO_NATIVE(fend, width, x) CONVERT_NATIVE(fend, width, x)
> --
> 2.26.2
>

Reviewed-by: David Marchand <david.marchand@redhat.com>


-- 
David Marchand


^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [dpdk-dev] [PATCH 3/4] app/testpmd: fix build with gcc 11
  2020-09-21 13:38 ` [dpdk-dev] [PATCH 3/4] app/testpmd: " Ferruh Yigit
  2020-09-24  9:31   ` David Marchand
@ 2020-09-24 11:01   ` Phil Yang
  2020-10-08 10:48   ` David Marchand
  2 siblings, 0 replies; 14+ messages in thread
From: Phil Yang @ 2020-09-24 11:01 UTC (permalink / raw)
  To: Ferruh Yigit, Wenzhuo Lu, Beilei Xing, Bernard Iremonger; +Cc: dev, nd

<snip>

> Subject: [dpdk-dev] [PATCH 3/4] app/testpmd: fix build with gcc 11
> 
> Error observed with gcc 11 under development
> gcc (GCC) 11.0.0 20200920 (experimental)
> 
> ../app/test-pmd/config.c:1777:61:
> 	warning: argument 3 of type ‘const uint32_t[n]’
> 	{aka ‘const unsigned int[n]’} declared as a variable length
> 	array [-Wvla-parameter]
>  1777 | port_flow_list(portid_t port_id, uint32_t n,
>  			const uint32_t group[n])
>       |                 ~~~~~~~~~~~~~~~^~~~~~~~
> In file included from ../app/test-pmd/config.c:53:
> ../app/test-pmd/testpmd.h:764:67:
> 	note: previously declared as a pointer ‘const uint32_t *’
> 	{aka ‘const unsigned int *’}
>   764 | void port_flow_list(portid_t port_id, uint32_t n,
>   				const uint32_t *group);
>       |                         ~~~~~~~~~~~~~~~~^~~~~
> 
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>


Verified with gcc version 11.0.0 20200920 (experimental).
Reviewed-by: Phil Yang <phil.yang@arm.com>


> ---
>  app/test-pmd/config.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
> index b6eb2a57a..380f3b5f6 100644
> --- a/app/test-pmd/config.c
> +++ b/app/test-pmd/config.c
> @@ -1774,7 +1774,7 @@ port_flow_aged(portid_t port_id, uint8_t destroy)
> 
>  /** List flow rules. */
>  void
> -port_flow_list(portid_t port_id, uint32_t n, const uint32_t group[n])
> +port_flow_list(portid_t port_id, uint32_t n, const uint32_t *group)
>  {
>  	struct rte_port *port;
>  	struct port_flow *pf;
> --
> 2.26.2


^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [dpdk-dev] [EXT] [PATCH 1/4] net/qede: fix build with gcc 11
  2020-09-21 13:38 [dpdk-dev] [PATCH 1/4] net/qede: fix build with gcc 11 Ferruh Yigit
                   ` (2 preceding siblings ...)
  2020-09-21 13:38 ` [dpdk-dev] [PATCH 4/4] pmdinfogen: " Ferruh Yigit
@ 2020-09-25  4:27 ` Rasesh Mody
  2020-10-06 12:38   ` David Marchand
  3 siblings, 1 reply; 14+ messages in thread
From: Rasesh Mody @ 2020-09-25  4:27 UTC (permalink / raw)
  To: Ferruh Yigit, Shahed Shaikh; +Cc: dev

Hi Ferruh,

>From: Ferruh Yigit <ferruh.yigit@intel.com>
>Sent: Monday, September 21, 2020 6:38 AM
>
>Error observed with gcc 11 under development gcc (GCC) 11.0.0 20200920
>(experimental)
>
>build error:
>../drivers/net/qede/qede_main.c: In function ‘qed_get_current_link’:
>../drivers/net/qede/qede_main.c:587:17:
>	warning: this ‘if’ clause does not guard...
>                 [-Wmisleading-indentation]
>  587 |                 if (!ptt)
>      |                 ^~
>../drivers/net/qede/qede_main.c:590:25:
>	note: ...this statement, but the latter is misleadingly indented
>              as if it were guarded by the ‘if’
>  590 |                         qed_fill_link(hwfn, ptt, if_link);
>      |                         ^~~~~~~~~~~~~
>
>Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>---
>I am not clear what the exact intention of the original code is, compiler
>warning is about wrong indentation of 'qed_fill_link(..)', I have updated the
>code to keep the behavior same but fix the indentation.
>Please send a proper fix if the existing behavior needs to be updated.

The existing behavior needs to be fixed, I'll send a proper fix for 20.11.

Thanks!
-Rasesh


^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [dpdk-dev] [PATCH 3/4] app/testpmd: fix build with gcc 11
  2020-09-24  9:31   ` David Marchand
@ 2020-10-04  8:57     ` Asaf Penso
  0 siblings, 0 replies; 14+ messages in thread
From: Asaf Penso @ 2020-10-04  8:57 UTC (permalink / raw)
  To: David Marchand, Ferruh Yigit
  Cc: Wenzhuo Lu, Beilei Xing, Bernard Iremonger, dev,
	NBU-Contact-Thomas Monjalon, NBU-Contact-Adrien Mazarguil

>-----Original Message-----
>From: dev <dev-bounces@dpdk.org> On Behalf Of David Marchand
>Sent: Thursday, September 24, 2020 12:31 PM
>To: Ferruh Yigit <ferruh.yigit@intel.com>
>Cc: Wenzhuo Lu <wenzhuo.lu@intel.com>; Beilei Xing
><beilei.xing@intel.com>; Bernard Iremonger
><bernard.iremonger@intel.com>; dev <dev@dpdk.org>; NBU-Contact-Adrien
>Mazarguil <adrien.mazarguil@6wind.com>
>Subject: Re: [dpdk-dev] [PATCH 3/4] app/testpmd: fix build with gcc 11
>
>On Mon, Sep 21, 2020 at 3:39 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>>
>> Error observed with gcc 11 under development gcc (GCC) 11.0.0 20200920
>> (experimental)
>>
>> ../app/test-pmd/config.c:1777:61:
>>         warning: argument 3 of type ‘const uint32_t[n]’
>>         {aka ‘const unsigned int[n]’} declared as a variable length
>>         array [-Wvla-parameter]
>>  1777 | port_flow_list(portid_t port_id, uint32_t n,
>>                         const uint32_t group[n])
>>       |                 ~~~~~~~~~~~~~~~^~~~~~~~
>> In file included from ../app/test-pmd/config.c:53:
>> ../app/test-pmd/testpmd.h:764:67:
>>         note: previously declared as a pointer ‘const uint32_t *’
>>         {aka ‘const unsigned int *’}
>>   764 | void port_flow_list(portid_t port_id, uint32_t n,
>>                                 const uint32_t *group);
>>       |                         ~~~~~~~~~~~~~~~~^~~~~
>>
>
>It won't hurt to backport this.
>
>Fixes: 938a184a1870 ("app/testpmd: implement basic support for flow API")
>Cc: stable@dpdk.org
>
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>> ---
>>  app/test-pmd/config.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index
>> b6eb2a57a..380f3b5f6 100644
>> --- a/app/test-pmd/config.c
>> +++ b/app/test-pmd/config.c
>> @@ -1774,7 +1774,7 @@ port_flow_aged(portid_t port_id, uint8_t
>> destroy)
>>
>>  /** List flow rules. */
>>  void
>> -port_flow_list(portid_t port_id, uint32_t n, const uint32_t group[n])
>> +port_flow_list(portid_t port_id, uint32_t n, const uint32_t *group)
>>  {
>>         struct rte_port *port;
>>         struct port_flow *pf;
>> --
>> 2.26.2
>>
>
>Reviewed-by: David Marchand <david.marchand@redhat.com>
>
>--
>David Marchand


Reviewed-by: Asaf Penso <asafp@nvidia.com>

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [dpdk-dev] [EXT] [PATCH 1/4] net/qede: fix build with gcc 11
  2020-09-25  4:27 ` [dpdk-dev] [EXT] [PATCH 1/4] net/qede: " Rasesh Mody
@ 2020-10-06 12:38   ` David Marchand
  0 siblings, 0 replies; 14+ messages in thread
From: David Marchand @ 2020-10-06 12:38 UTC (permalink / raw)
  To: Rasesh Mody, Ferruh Yigit; +Cc: Shahed Shaikh, dev

On Fri, Sep 25, 2020 at 6:28 AM Rasesh Mody <rmody@marvell.com> wrote:
> >From: Ferruh Yigit <ferruh.yigit@intel.com>
> >Sent: Monday, September 21, 2020 6:38 AM
> >
> >Error observed with gcc 11 under development gcc (GCC) 11.0.0 20200920
> >(experimental)
> >
> >build error:
> >../drivers/net/qede/qede_main.c: In function ‘qed_get_current_link’:
> >../drivers/net/qede/qede_main.c:587:17:
> >       warning: this ‘if’ clause does not guard...
> >                 [-Wmisleading-indentation]
> >  587 |                 if (!ptt)
> >      |                 ^~
> >../drivers/net/qede/qede_main.c:590:25:
> >       note: ...this statement, but the latter is misleadingly indented
> >              as if it were guarded by the ‘if’
> >  590 |                         qed_fill_link(hwfn, ptt, if_link);
> >      |                         ^~~~~~~~~~~~~
> >
> >Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> >---
> >I am not clear what the exact intention of the original code is, compiler
> >warning is about wrong indentation of 'qed_fill_link(..)', I have updated the
> >code to keep the behavior same but fix the indentation.
> >Please send a proper fix if the existing behavior needs to be updated.
>
> The existing behavior needs to be fixed, I'll send a proper fix for 20.11.

I suppose this is fixed with:
https://patchwork.dpdk.org/patch/79562/

I'll mark Ferruh patch as rejected.


-- 
David Marchand


^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [dpdk-dev] [PATCH 2/4] raw/dpaa2: fix build with gcc 11
       [not found]       ` <AM5PR0401MB2593386BAB0C09ABE92F9D65E60B0@AM5PR0401MB2593.eurprd04.prod.outlook.com>
@ 2020-10-08 10:40         ` David Marchand
  2020-10-08 11:29           ` Ferruh Yigit
  0 siblings, 1 reply; 14+ messages in thread
From: David Marchand @ 2020-10-08 10:40 UTC (permalink / raw)
  To: Nipun Gupta, Yigit, Ferruh; +Cc: Hemant Agrawal, dev

On Thu, Oct 8, 2020 at 11:08 AM Nipun Gupta <nipun.gupta@nxp.com> wrote:
>
> Hi David,
>
> https://patchwork.dpdk.org/patch/76983/ - this patch have same changes?
> Please check and let me know what shall be done.

Ok, I'll mark Ferruh patch as rejected.
Thank you.

-- 
David Marchand


^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [dpdk-dev] [PATCH 3/4] app/testpmd: fix build with gcc 11
  2020-09-21 13:38 ` [dpdk-dev] [PATCH 3/4] app/testpmd: " Ferruh Yigit
  2020-09-24  9:31   ` David Marchand
  2020-09-24 11:01   ` Phil Yang
@ 2020-10-08 10:48   ` David Marchand
  2 siblings, 0 replies; 14+ messages in thread
From: David Marchand @ 2020-10-08 10:48 UTC (permalink / raw)
  To: Ferruh Yigit; +Cc: Wenzhuo Lu, Beilei Xing, Bernard Iremonger, dev

On Mon, Sep 21, 2020 at 3:39 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>
> Error observed with gcc 11 under development
> gcc (GCC) 11.0.0 20200920 (experimental)
>
> ../app/test-pmd/config.c:1777:61:
>         warning: argument 3 of type ‘const uint32_t[n]’
>         {aka ‘const unsigned int[n]’} declared as a variable length
>         array [-Wvla-parameter]
>  1777 | port_flow_list(portid_t port_id, uint32_t n,
>                         const uint32_t group[n])
>       |                 ~~~~~~~~~~~~~~~^~~~~~~~
> In file included from ../app/test-pmd/config.c:53:
> ../app/test-pmd/testpmd.h:764:67:
>         note: previously declared as a pointer ‘const uint32_t *’
>         {aka ‘const unsigned int *’}
>   764 | void port_flow_list(portid_t port_id, uint32_t n,
>                                 const uint32_t *group);
>       |                         ~~~~~~~~~~~~~~~~^~~~~
>

Fixes: 938a184a1870 ("app/testpmd: implement basic support for flow API")
Cc: stable@dpdk.org

> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
Reviewed-by: David Marchand <david.marchand@redhat.com>
Reviewed-by: Phil Yang <phil.yang@arm.com>
Reviewed-by: Asaf Penso <asafp@nvidia.com>

Applied, thanks.


-- 
David Marchand


^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [dpdk-dev] [PATCH 4/4] pmdinfogen: fix build with gcc 11
  2020-09-24  9:32   ` David Marchand
@ 2020-10-08 10:48     ` David Marchand
  0 siblings, 0 replies; 14+ messages in thread
From: David Marchand @ 2020-10-08 10:48 UTC (permalink / raw)
  To: Ferruh Yigit; +Cc: Neil Horman, dev

On Thu, Sep 24, 2020 at 11:32 AM David Marchand
<david.marchand@redhat.com> wrote:
> On Mon, Sep 21, 2020 at 3:39 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
> >
> > Error observed with gcc 11 under development
> > gcc (GCC) 11.0.0 20200920 (experimental)
> >
> > build error:
> > In file included from ../buildtools/pmdinfogen/pmdinfogen.c:17:
> > ../buildtools/pmdinfogen/pmdinfogen.c: In function ‘parse_elf’:
> > ../buildtools/pmdinfogen/pmdinfogen.h:78:1:
> >         warning: this ‘else’ clause does not guard...
> >         [-Wmisleading-indentation]
> >    78 | else \
> >       | ^~~~
> > ../buildtools/pmdinfogen/pmdinfogen.h:83:35:
> >         note: in expansion of macro ‘CONVERT_NATIVE’
> >    83 | #define TO_NATIVE(fend, width, x) CONVERT_NATIVE(fend, width, x)
> >       |                                   ^~~~~~~~~~~~~~
> > ../buildtools/pmdinfogen/pmdinfogen.c:152:28:
> >         note: in expansion of macro ‘TO_NATIVE’
> >   152 |         hdr->e_type      = TO_NATIVE(endian, 16, hdr->e_type);
> >       |                            ^~~~~~~~~
> > ../buildtools/pmdinfogen/pmdinfogen.h:80:9:
> >         note: ...this statement, but the latter is misleadingly indented
> >         as if it were guarded by the ‘else’
> >    80 |         ___x; \
> >       |         ^~~~
> >
>
>
> Fixes: 98b0fdb0ffc6 ("pmdinfogen: add buildtools and pmdinfogen utility")
> Cc: stable@dpdk.org
>
> > Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> Reviewed-by: David Marchand <david.marchand@redhat.com>

Applied, thanks.


-- 
David Marchand


^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [dpdk-dev] [PATCH 2/4] raw/dpaa2: fix build with gcc 11
  2020-10-08 10:40         ` David Marchand
@ 2020-10-08 11:29           ` Ferruh Yigit
  0 siblings, 0 replies; 14+ messages in thread
From: Ferruh Yigit @ 2020-10-08 11:29 UTC (permalink / raw)
  To: David Marchand, Nipun Gupta; +Cc: Hemant Agrawal, dev

On 10/8/2020 11:40 AM, David Marchand wrote:
> On Thu, Oct 8, 2020 at 11:08 AM Nipun Gupta <nipun.gupta@nxp.com> wrote:
>>
>> Hi David,
>>
>> https://patchwork.dpdk.org/patch/76983/ - this patch have same changes?
>> Please check and let me know what shall be done.
> 
> Ok, I'll mark Ferruh patch as rejected.
 >

Yes looks like fixing same thing, good for me.

^ permalink raw reply	[flat|nested] 14+ messages in thread

end of thread, other threads:[~2020-10-08 11:29 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-21 13:38 [dpdk-dev] [PATCH 1/4] net/qede: fix build with gcc 11 Ferruh Yigit
2020-09-21 13:38 ` [dpdk-dev] [PATCH 2/4] raw/dpaa2: " Ferruh Yigit
     [not found]   ` <CAJFAV8wAio=NF2eMMx9URkNinht2sPtBrE9k1c0uD+_GJcM4aw@mail.gmail.com>
     [not found]     ` <CAJFAV8y9zFUAKoqhQxobdQDVPAOny4ie+Cm1fHneEX6g6zdtjw@mail.gmail.com>
     [not found]       ` <AM5PR0401MB2593386BAB0C09ABE92F9D65E60B0@AM5PR0401MB2593.eurprd04.prod.outlook.com>
2020-10-08 10:40         ` David Marchand
2020-10-08 11:29           ` Ferruh Yigit
2020-09-21 13:38 ` [dpdk-dev] [PATCH 3/4] app/testpmd: " Ferruh Yigit
2020-09-24  9:31   ` David Marchand
2020-10-04  8:57     ` Asaf Penso
2020-09-24 11:01   ` Phil Yang
2020-10-08 10:48   ` David Marchand
2020-09-21 13:38 ` [dpdk-dev] [PATCH 4/4] pmdinfogen: " Ferruh Yigit
2020-09-24  9:32   ` David Marchand
2020-10-08 10:48     ` David Marchand
2020-09-25  4:27 ` [dpdk-dev] [EXT] [PATCH 1/4] net/qede: " Rasesh Mody
2020-10-06 12:38   ` David Marchand

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git