From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6E87EA04B0; Tue, 22 Sep 2020 14:04:38 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A6DFA1DB20; Tue, 22 Sep 2020 14:03:51 +0200 (CEST) Received: from incedge.chinasoftinc.com (unknown [114.113.233.8]) by dpdk.org (Postfix) with ESMTP id 46E001DADA for <dev@dpdk.org>; Tue, 22 Sep 2020 14:03:43 +0200 (CEST) X-ASG-Debug-ID: 1600776222-149d111bae1ab900001-TfluYd Received: from mail.chinasoftinc.com (inccas002.ito.icss [10.168.0.52]) by incedge.chinasoftinc.com with ESMTP id uGuj2Gp6paBlHJUX (version=TLSv1 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 22 Sep 2020 20:03:42 +0800 (CST) X-Barracuda-Envelope-From: huwei013@chinasoftinc.com X-Barracuda-RBL-Trusted-Forwarder: 10.168.0.52 X-ASG-Whitelist: Client Received: from localhost.localdomain (120.133.139.157) by INCCAS002.ito.icss (10.168.0.60) with Microsoft SMTP Server id 14.3.487.0; Tue, 22 Sep 2020 20:03:41 +0800 From: "Wei Hu (Xavier)" <huwei013@chinasoftinc.com> X-Barracuda-RBL-Trusted-Forwarder: 10.168.0.60 To: <dev@dpdk.org> CC: <xavier.huwei@huawei.com> Date: Tue, 22 Sep 2020 20:03:20 +0800 X-ASG-Orig-Subj: [PATCH v2 08/17] net/hns3: add break to exit loop when err stat item found Message-ID: <20200922120329.21185-9-huwei013@chinasoftinc.com> X-Mailer: git-send-email 2.9.5 In-Reply-To: <20200922120329.21185-1-huwei013@chinasoftinc.com> References: <20200922085401.12272-1-huwei013@chinasoftinc.com> <20200922120329.21185-1-huwei013@chinasoftinc.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [120.133.139.157] X-Barracuda-Connect: inccas002.ito.icss[10.168.0.52] X-Barracuda-Start-Time: 1600776222 X-Barracuda-Encrypted: ECDHE-RSA-AES256-SHA X-Barracuda-URL: https://incspam.chinasofti.com:443/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at chinasoftinc.com X-Barracuda-Scan-Msg-Size: 1006 Subject: [dpdk-dev] [PATCH v2 08/17] net/hns3: add break to exit loop when err stat item found X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> From: Hongbo Zheng <zhenghongbo3@huawei.com> This patch solves the redundant operation during traversal. In the internal function named hns3_error_int_stats_add for adding error statistics, because only one statistical item will be found in the for loop statement, a break can be executed after finding the error statistical item without traversing the remaining table entries. Signed-off-by: Hongbo Zheng <zhenghongbo3@huawei.com> Signed-off-by: Wei Hu (Xavier) <xavier.huwei@huawei.com> --- drivers/net/hns3/hns3_stats.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/hns3/hns3_stats.c b/drivers/net/hns3/hns3_stats.c index 067673c..e8846b9 100644 --- a/drivers/net/hns3/hns3_stats.c +++ b/drivers/net/hns3/hns3_stats.c @@ -703,6 +703,7 @@ hns3_error_int_stats_add(struct hns3_adapter *hns, const char *err) addr = (char *)&pf->abn_int_stats + hns3_error_int_stats_strings[i].offset; *(uint64_t *)addr += 1; + break; } } } -- 2.9.5