From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3FC52A04B5; Tue, 22 Sep 2020 19:24:53 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9B6931D5F4; Tue, 22 Sep 2020 19:24:52 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 3AC381D453; Tue, 22 Sep 2020 19:24:51 +0200 (CEST) IronPort-SDR: 0UXk/2IgJ95ScMEFg0EiT+nJd/4MI7bL5mg2bTgfJOo21Bguin+GQbQyGSbUSBj1J6dM28B4j3 0L5JGpNaIcUw== X-IronPort-AV: E=McAfee;i="6000,8403,9752"; a="140678632" X-IronPort-AV: E=Sophos;i="5.77,291,1596524400"; d="scan'208";a="140678632" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Sep 2020 10:24:50 -0700 IronPort-SDR: hpyoptvnIhcUXhxtnv2mfGrRM1xBtQyoFqm5X/Mx2oKklB4793kJLBSnMOdhtuokjI8ekzHq/X bSGImLyjDuiA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,291,1596524400"; d="scan'208";a="290467707" Received: from silpixa00399838.ir.intel.com ([10.237.213.224]) by fmsmga007.fm.intel.com with ESMTP; 22 Sep 2020 10:24:49 -0700 From: Kevin Laatz To: dev@dpdk.org Cc: ferruh.yigit@intel.com, bruce.richardson@intel.com, Kevin Laatz , stable@dpdk.org Date: Tue, 22 Sep 2020 18:20:15 +0100 Message-Id: <20200922172015.266698-1-kevin.laatz@intel.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH] net/ring: fix unchecked return value X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add a check for the return value of the sscanf call in parse_internal_args(), returning an error if we don't get the expected result. Coverity issue: 362049 Fixes: 96cb19521147 ("net/ring: use EAL APIs in PMD specific API") Cc: stable@dpdk.org Signed-off-by: Kevin Laatz --- drivers/net/ring/rte_eth_ring.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ring/rte_eth_ring.c b/drivers/net/ring/rte_eth_ring.c index 40fe1ca4ba..62060e46ce 100644 --- a/drivers/net/ring/rte_eth_ring.c +++ b/drivers/net/ring/rte_eth_ring.c @@ -539,7 +539,8 @@ parse_internal_args(const char *key __rte_unused, const char *value, struct ring_internal_args **internal_args = data; void *args; - sscanf(value, "%p", &args); + if (sscanf(value, "%p", &args) != 1) + return -1; *internal_args = args; -- 2.25.1