From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 03333A04B1; Wed, 23 Sep 2020 15:59:09 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 597D51D8EB; Wed, 23 Sep 2020 15:59:09 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id CCA491D8CF for ; Wed, 23 Sep 2020 15:59:03 +0200 (CEST) IronPort-SDR: YSmiT1OnE8YA0DzcdtzupKaaYn6U9k5msfyY1PLqJrM5dpHVEcYeFn45H3Y4PDW0S8k64ZdCTZ +06hw7SqBmWg== X-IronPort-AV: E=McAfee;i="6000,8403,9752"; a="245727785" X-IronPort-AV: E=Sophos;i="5.77,293,1596524400"; d="scan'208";a="245727785" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Sep 2020 06:59:02 -0700 IronPort-SDR: EMM6FajpDEeIG5b0bC76lGBhiHCFzSI/ScLbdumvNYpgsKY1G8+u7UOisX5K6M7YWVz5zzT3c6 ov8IR4doxajA== X-IronPort-AV: E=Sophos;i="5.77,293,1596524400"; d="scan'208";a="454925297" Received: from bricha3-mobl.ger.corp.intel.com ([10.213.7.171]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 23 Sep 2020 06:58:58 -0700 Date: Wed, 23 Sep 2020 14:58:54 +0100 From: Bruce Richardson To: Juraj =?utf-8?Q?Linke=C5=A1?= Cc: Ruifeng.Wang@arm.com, Honnappa.Nagarahalli@arm.com, Phil.Yang@arm.com, vcchunga@amazon.com, Dharmik.Thakkar@arm.com, jerinjacobk@gmail.com, hemant.agrawal@nxp.com, dev@dpdk.org Message-ID: <20200923135854.GB1760@bricha3-MOBL.ger.corp.intel.com> References: <1600867161-15673-1-git-send-email-juraj.linkes@pantheon.tech> <1600867161-15673-3-git-send-email-juraj.linkes@pantheon.tech> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1600867161-15673-3-git-send-email-juraj.linkes@pantheon.tech> Subject: Re: [dpdk-dev] [RFC PATCH 2/2] build: disable drivers from file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Sep 23, 2020 at 03:19:21PM +0200, Juraj Linkeš wrote: > Add the capability to specify which drivers will NOT be build in a file. > > Signed-off-by: Juraj Linkeš > --- > .../arm/{ => armada}/arm64_armada_linux_gcc | 2 +- > config/arm/armada/meson.build | 31 +++++++++++++++++++ > drivers/meson.build | 13 +++++--- > 3 files changed, 41 insertions(+), 5 deletions(-) > rename config/arm/{ => armada}/arm64_armada_linux_gcc (93%) > create mode 100644 config/arm/armada/meson.build > > diff --git a/config/arm/arm64_armada_linux_gcc b/config/arm/armada/arm64_armada_linux_gcc > similarity index 93% > rename from config/arm/arm64_armada_linux_gcc > rename to config/arm/armada/arm64_armada_linux_gcc > index fa40c0398..8b4b5c8ad 100644 > --- a/config/arm/arm64_armada_linux_gcc > +++ b/config/arm/armada/arm64_armada_linux_gcc > @@ -14,4 +14,4 @@ cpu = 'armv8-a' > endian = 'little' > > [properties] > -implementor_id = '0x56' > +machine = 'armada' > diff --git a/config/arm/armada/meson.build b/config/arm/armada/meson.build > new file mode 100644 > index 000000000..22fdce5fe > --- /dev/null > +++ b/config/arm/armada/meson.build > @@ -0,0 +1,31 @@ > +flags = { > + 'common': [ > + ['RTE_CACHE_LINE_SIZE', 64], > + ['RTE_MACHINE', '"armv8a"'], > + ['CONFIG_RTE_LIBRTE_DPAA_BUS=n', false], > + ['CONFIG_RTE_LIBRTE_COMMON_DPAAX=n', false], > + ['CONFIG_RTE_LIBRTE_FSLMC_BUS=n', false], > + ['CONFIG_RTE_LIBRTE_DPAA2_MEMPOOL=n', false], > + ['CONFIG_RTE_LIBRTE_DPAA2_PMD=n', false], > + ['CONFIG_RTE_LIBRTE_DPAA_BUS=n', false], > + ['CONFIG_RTE_LIBRTE_DPAA_MEMPOOL=n', false], > + ['CONFIG_RTE_LIBRTE_DPAA_PMD=n', false], > + ['CONFIG_RTE_LIBRTE_PMD_DPAA_EVENTDEV=n', false], > + ['CONFIG_RTE_LIBRTE_PMD_DPAA_SEC=n', false], > + ['CONFIG_RTE_LIBRTE_PMD_CAAM_JR=n', false], > + ['CONFIG_RTE_LIBRTE_PMD_DPAA2_EVENTDEV=n', false], > + ['CONFIG_RTE_LIBRTE_PMD_DPAA2_SEC=n', false], > + ['CONFIG_RTE_LIBRTE_PMD_DPAA2_CMDIF_RAWDEV=n', false], > + ['CONFIG_RTE_LIBRTE_PMD_DPAA2_QDMA_RAWDEV=n', false], > + ['CONFIG_RTE_LIBRTE_PFE_PMD=n', false], > + ['CONFIG_RTE_LIBRTE_ENETC_PMD=n', false], > + ['CONFIG_RTE_EAL_NUMA_AWARE_HUGEPAGES=n', false], > + ['CONFIG_RTE_LIBRTE_VHOST_NUMA=n', false] > + ], Rather than setting a list of flags like this make-style, why not have a disabled-drivers setting, and add that to any user-provided ones? It would save making any changes to the drivers/meson.build file, and therefore be a lot cleaner. It would also allow using wildcards etc. to disable whole classes of drivers