From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 7A8FBA04B1;
	Thu, 24 Sep 2020 00:02:51 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 19B911DB48;
	Thu, 24 Sep 2020 00:02:51 +0200 (CEST)
Received: from mail-pg1-f195.google.com (mail-pg1-f195.google.com
 [209.85.215.195]) by dpdk.org (Postfix) with ESMTP id 814121DB47
 for <dev@dpdk.org>; Thu, 24 Sep 2020 00:02:49 +0200 (CEST)
Received: by mail-pg1-f195.google.com with SMTP id u24so581843pgi.1
 for <dev@dpdk.org>; Wed, 23 Sep 2020 15:02:49 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=networkplumber-org.20150623.gappssmtp.com; s=20150623;
 h=date:from:to:cc:subject:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=Cj18CAgdNK0VCHSLfxqKXGEYIVdLQ9cM51dYsrH3roc=;
 b=dpwv+BuXmikKc2P6/S5BnjP7fOmq0/7DRBncrjOowz/8jSburMr/igSr7891D2IIec
 bmr/JcfNT4o+eRY8+osZ2V9GBQM3zErupP/l60tA5g7ZJS0EkRLjtipSEb/KyH95p693
 WnLVJeXMDTZhuudAlf+KwP58keTme7umhheuGLKBR5nCBnz2UtYDOLhXksm1b13yE0t4
 Mt8tCknteaE5WC5Tdh7tHU47SCsnusKF/H1T/Y4tr94EY/YRMC0j39c3jLXerO9/xa8f
 C4/3iFA8FWplquKPzxEmONCcjQbFGbkds+kjwHjpXIeZzA68EnKM5zExr/6rAa6CKtVA
 AB0w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=Cj18CAgdNK0VCHSLfxqKXGEYIVdLQ9cM51dYsrH3roc=;
 b=lZ0Cw0o3tHeoH08xV3R/J9iwnRdnrH0rFP+AX/Z+KtPM/btH84ltjTXDuPNri/fum5
 1ig9idctFn6pXHh1QFoGBL/7FQhjvqLRKVmROdL9ULDCeJrdCdRsUe/QxY+m5IWpIxcT
 /EF/tiPXQ255XaiT7IyvB4DomSA/UO9dOaMAURDahSwZG0lCN1YMHBB9MdH3+UZ7iNVN
 EqffnbDuHd2DsdOM8mU+4YRlVnmp2fZKBaxExfP2TE4C2sj3j9uJU7r0tJq36Yv6lWP0
 l9lRJphFBlbRPwYHIAvI/nudsJluX0G5/fL04rTXrRikam9nxHtztjiNCdDsvdITY8KR
 lBvQ==
X-Gm-Message-State: AOAM530Ew0kIwigcmULPeXyL5s9WuxLIyc0LFTqNMov5OMMwuXaFO/Np
 eE8UEDVIIJKrZkr2S9mR4wCRnQ==
X-Google-Smtp-Source: ABdhPJyL48XwKtI6fQrwEne7/HgVroYvEC8MuFuQBWq8PsuhpdLiYzXQPpkBo+uBevMhcO8Di1MoQw==
X-Received: by 2002:a65:6855:: with SMTP id q21mr1478159pgt.115.1600898568642; 
 Wed, 23 Sep 2020 15:02:48 -0700 (PDT)
Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127])
 by smtp.gmail.com with ESMTPSA id j19sm593444pfi.51.2020.09.23.15.02.46
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Wed, 23 Sep 2020 15:02:48 -0700 (PDT)
Date: Wed, 23 Sep 2020 15:02:38 -0700
From: Stephen Hemminger <stephen@networkplumber.org>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: Ferruh Yigit <ferruh.yigit@intel.com>, dev@dpdk.org,
 arybchenko@solarflare.com, "John W. Linville" <linville@tuxdriver.com>,
 Ciara Loftus <ciara.loftus@intel.com>, Qi Zhang <qi.z.zhang@intel.com>,
 Shepard Siegel <shepard.siegel@atomicrules.com>, Ed Czeck
 <ed.czeck@atomicrules.com>, John Miller <john.miller@atomicrules.com>, Igor
 Russkikh <igor.russkikh@aquantia.com>, Pavel Belous
 <pavel.belous@aquantia.com>, Steven Webster <steven.webster@windriver.com>,
 Matt Peters <matt.peters@windriver.com>, Somalapuram Amaranath
 <asomalap@amd.com>, Rasesh Mody <rmody@marvell.com>, Shahed Shaikh
 <shshaikh@marvell.com>, Ajit Khaparde <ajit.khaparde@broadcom.com>, Somnath
 Kotur <somnath.kotur@broadcom.com>, Chas Williams <chas3@att.com>, "Wei Hu
 (Xavier)" <xavier.huwei@huawei.com>, Rahul Lakkireddy
 <rahul.lakkireddy@chelsio.com>, Hemant Agrawal <hemant.agrawal@nxp.com>,
 Sachin Saxena <sachin.saxena@nxp.com>, Wei Zhao <wei.zhao1@intel.com>, Jeff
 Guo <jia.guo@intel.com>, Marcin Wojtas <mw@semihalf.com>, Michal Krawczyk
 <mk@semihalf.com>, Guy Tzalik <gtzalik@amazon.com>, Evgeny Schemeilin
 <evgenys@amazon.com>, Igor Chauskin <igorch@amazon.com>, Gagandeep Singh
 <g.singh@nxp.com>, John Daley <johndale@cisco.com>, Hyong Youb Kim
 <hyonkim@cisco.com>, Gaetan Rivet <grive@u256.net>, Xiao Wang
 <xiao.w.wang@intel.com>, Ziyang Xuan <xuanziyang2@huawei.com>, Xiaoyun Wang
 <cloud.wangxiaoyun@huawei.com>, Guoyang Zhou <zhouguoyang@huawei.com>, "Min
 Hu (Connor)" <humin29@huawei.com>, Yisen Zhuang <yisen.zhuang@huawei.com>,
 Beilei Xing <beilei.xing@intel.com>, Jingjing Wu <jingjing.wu@intel.com>,
 Qiming Yang <qiming.yang@intel.com>, Alfredo Cardigliano
 <cardigliano@ntop.org>, Rosen Xu <rosen.xu@intel.com>, Shijith Thotton
 <sthotton@marvell.com>, Srisivasubramanian Srinivasan
 <srinivasan@marvell.com>, Jakub Grajciar <jgrajcia@cisco.com>, Matan Azrad
 <matan@mellanox.com>, Shahaf Shuler <shahafs@mellanox.com>, Viacheslav
 Ovsiienko <viacheslavo@mellanox.com>, Zyta Szpak <zr@semihalf.com>, Liron
 Himi <lironh@marvell.com>, Stephen Hemminger <sthemmin@microsoft.com>, "K.
 Y. Srinivasan" <kys@microsoft.com>, Haiyang Zhang <haiyangz@microsoft.com>,
 Long Li <longli@microsoft.com>, Martin Spinler <spinler@cesnet.cz>,
 Heinrich Kuhn <heinrich.kuhn@netronome.com>, Harman Kalra
 <hkalra@marvell.com>, Jerin Jacob <jerinj@marvell.com>, Nithin Dabilpuram
 <ndabilpuram@marvell.com>, Kiran Kumar K <kirankumark@marvell.com>, Akhil
 Goyal <akhil.goyal@nxp.com>, Jasvinder Singh <jasvinder.singh@intel.com>,
 Cristian Dumitrescu <cristian.dumitrescu@intel.com>, Keith Wiles
 <keith.wiles@intel.com>, Maciej Czekaj <mczekaj@marvell.com>, Maxime
 Coquelin <maxime.coquelin@redhat.com>, Chenbo Xia <chenbo.xia@intel.com>,
 Zhihong Wang <zhihong.wang@intel.com>, Yong Wang <yongwang@vmware.com>
Message-ID: <20200923150238.01cbf109@hermes.lan>
In-Reply-To: <7906978.WFKINk0of7@thomas>
References: <20200913220711.3768597-1-thomas@monjalon.net>
 <3329768.rLCo6hCP44@thomas> <20200923144744.6ebf0065@hermes.lan>
 <7906978.WFKINk0of7@thomas>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH 02/20] ethdev: allow drivers to return error
 on close
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Wed, 23 Sep 2020 23:52:07 +0200
Thomas Monjalon <thomas@monjalon.net> wrote:

> > > > > Yes it is a step in the right direction.
> > > > > Changing the API means adding some error checks in every apps.
> > > > > The reason for not doing is that I did not commit for this task,
> > > > > and I am not the author of the deprecation notice.
> > > > > We can discuss how to follow up once this series is merged.    
> > > > 
> > > > Not sure what application can really do if dev_close fails other than call rte_exit()?    
> > > 
> > > At least, it can show a message to the user.  
> > 
> > Agree, but no code checks return from close() system call now.
> > At least testpmd should be updated; the examples are fine.  
> 
> How do you explicitly silence the static code analyzers?
> Do you recommend adding (void) in front of the call to close()?

Coverity usually gives something like, "return value of foo() is not checked
but checked 10 other places"