DPDK patches and discussions
 help / color / mirror / Atom feed
From: Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>
To: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Cc: dev@dpdk.org, Harman Kalra <hkalra@marvell.com>,
	Dmitry Malloy <dmitrym@microsoft.com>,
	Pallavi Kadam <pallavi.kadam@intel.com>
Subject: Re: [dpdk-dev] [PATCH 1/2] eal/windows: add interrupt thread skeleton
Date: Thu, 24 Sep 2020 18:19:03 -0700	[thread overview]
Message-ID: <20200925011903.GA7110@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> (raw)
In-Reply-To: <20200911002207.31813-2-dmitry.kozliuk@gmail.com>

On Fri, Sep 11, 2020 at 03:22:06AM +0300, Dmitry Kozlyuk wrote:
> Windows interrupt support is based on IO completion ports (IOCP).
> Interrupt thread would send the devices requests to notify about
> interrupts and then wait for any request completion. Add skeleton code
> of this model without any hardware support.
> 
> Another way to wake up the interrupt thread is APC (asynchronous procedure
> call), scheduled by any other thread via eal_intr_thread_schedule().
> This internal API is intended for alarm implementation.
> 
> Signed-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
> ---
>  lib/librte_eal/include/rte_eal_interrupts.h | 14 ++-
>  lib/librte_eal/rte_eal_exports.def          |  1 +
>  lib/librte_eal/windows/eal.c                |  5 ++
>  lib/librte_eal/windows/eal_interrupts.c     | 99 +++++++++++++++++++++
>  lib/librte_eal/windows/eal_windows.h        | 12 +++
>  lib/librte_eal/windows/include/pthread.h    |  7 ++
>  lib/librte_eal/windows/meson.build          |  1 +
>  7 files changed, 136 insertions(+), 3 deletions(-)
>  create mode 100644 lib/librte_eal/windows/eal_interrupts.c
> 
Reviewed-by: Narcisa Vasile <navasile@linux.microsoft.com>

Getting an "undefined reference to rte_intr_rx_ctl", guess we need to add a stub for this.
Otherwise, compiles successfully with both clang and mingw.

  reply	other threads:[~2020-09-25  1:19 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-11  0:22 [dpdk-dev] [PATCH 0/2] eal/windows: implement alarms Dmitry Kozlyuk
2020-09-11  0:22 ` [dpdk-dev] [PATCH 1/2] eal/windows: add interrupt thread skeleton Dmitry Kozlyuk
2020-09-25  1:19   ` Narcisa Ana Maria Vasile [this message]
2020-09-25  6:28     ` Dmitry Kozlyuk
2020-09-11  0:22 ` [dpdk-dev] [PATCH 2/2] eal/windows: implement alarm API Dmitry Kozlyuk
2020-09-21 19:08   ` [dpdk-dev] [EXTERNAL] " Khoa To
2020-09-24 21:38     ` Dmitry Kozlyuk
2020-09-25  2:19       ` Khoa To
2020-09-25 23:32 ` [dpdk-dev] [PATCH v2 0/2] eal/windows: implement alarms Dmitry Kozlyuk
2020-09-25 23:32   ` [dpdk-dev] [PATCH v2 1/2] eal/windows: add interrupt thread skeleton Dmitry Kozlyuk
2020-09-25 23:40     ` Narcisa Ana Maria Vasile
2020-09-25 23:32   ` [dpdk-dev] [PATCH v2 2/2] eal/windows: implement alarm API Dmitry Kozlyuk
2020-09-25 23:41     ` Narcisa Ana Maria Vasile
2020-10-14 21:36       ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200925011903.GA7110@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net \
    --to=navasile@linux.microsoft.com \
    --cc=dev@dpdk.org \
    --cc=dmitry.kozliuk@gmail.com \
    --cc=dmitrym@microsoft.com \
    --cc=hkalra@marvell.com \
    --cc=pallavi.kadam@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).