DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ankur Dwivedi <adwivedi@marvell.com>
To: <dev@dpdk.org>
Cc: <abhinandan.gujjar@intel.com>, <jerinj@marvell.com>,
	<anoobj@marvell.com>,  Ankur Dwivedi <adwivedi@marvell.com>
Subject: [dpdk-dev] [PATCH v2 1/3] test/event_crypto_adapter: return error with unsupported mode
Date: Fri, 25 Sep 2020 12:58:39 +0530
Message-ID: <20200925072841.17578-2-adwivedi@marvell.com> (raw)
In-Reply-To: <20200925072841.17578-1-adwivedi@marvell.com>

The capability of a hardware event device should be checked before
creating a event crypto adapter in a particular mode. The test case
returns error if the mode is not supported.

Signed-off-by: Ankur Dwivedi <adwivedi@marvell.com>
---
 app/test/test_event_crypto_adapter.c | 33 +++++++++++++++++++---------
 1 file changed, 23 insertions(+), 10 deletions(-)

diff --git a/app/test/test_event_crypto_adapter.c b/app/test/test_event_crypto_adapter.c
index 8d42462d8..3c64742b3 100644
--- a/app/test/test_event_crypto_adapter.c
+++ b/app/test/test_event_crypto_adapter.c
@@ -750,15 +750,30 @@ configure_event_crypto_adapter(enum rte_event_crypto_adapter_mode mode)
 	uint32_t cap;
 	int ret;
 
+	ret = rte_event_crypto_adapter_caps_get(evdev, TEST_CDEV_ID, &cap);
+	TEST_ASSERT_SUCCESS(ret, "Failed to get adapter capabilities\n");
+
+	/* Skip mode and capability mismatch check for SW eventdev */
+	if (!(cap & RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_NEW) &&
+	    !(cap & RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_FWD) &&
+	    !(cap & RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_QP_EV_BIND))
+		goto adapter_create;
+
+	if ((mode == RTE_EVENT_CRYPTO_ADAPTER_OP_FORWARD) &&
+	    !(cap & RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_FWD))
+		return -ENOTSUP;
+
+	if ((mode == RTE_EVENT_CRYPTO_ADAPTER_OP_NEW) &&
+	    !(cap & RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_NEW))
+		return -ENOTSUP;
+
+adapter_create:
 	/* Create adapter with default port creation callback */
 	ret = rte_event_crypto_adapter_create(TEST_ADAPTER_ID,
-					      TEST_CDEV_ID,
+					      evdev,
 					      &conf, mode);
 	TEST_ASSERT_SUCCESS(ret, "Failed to create event crypto adapter\n");
 
-	ret = rte_event_crypto_adapter_caps_get(TEST_ADAPTER_ID, evdev, &cap);
-	TEST_ASSERT_SUCCESS(ret, "Failed to get adapter capabilities\n");
-
 	if (cap & RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_QP_EV_BIND) {
 		ret = rte_event_crypto_adapter_queue_pair_add(TEST_ADAPTER_ID,
 				TEST_CDEV_ID, TEST_CDEV_QP_ID, &response_info);
@@ -813,6 +828,8 @@ test_crypto_adapter_conf(enum rte_event_crypto_adapter_mode mode)
 			TEST_ASSERT(ret >= 0, "Failed to link queue %d "
 					"port=%u\n", qid,
 					params.crypto_event_port_id);
+		} else {
+			return ret;
 		}
 		crypto_adapter_setup_done = 1;
 	}
@@ -847,10 +864,8 @@ test_crypto_adapter_conf_op_forward_mode(void)
 	enum rte_event_crypto_adapter_mode mode;
 
 	mode = RTE_EVENT_CRYPTO_ADAPTER_OP_FORWARD;
-	TEST_ASSERT_SUCCESS(test_crypto_adapter_conf(mode),
-				"Failed to config crypto adapter");
 
-	return TEST_SUCCESS;
+	return test_crypto_adapter_conf(mode);
 }
 
 static int
@@ -859,10 +874,8 @@ test_crypto_adapter_conf_op_new_mode(void)
 	enum rte_event_crypto_adapter_mode mode;
 
 	mode = RTE_EVENT_CRYPTO_ADAPTER_OP_NEW;
-	TEST_ASSERT_SUCCESS(test_crypto_adapter_conf(mode),
-				"Failed to config crypto adapter");
 
-	return TEST_SUCCESS;
+	return test_crypto_adapter_conf(mode);
 }
 
 
-- 
2.28.0


  reply	other threads:[~2020-09-25  7:29 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-08  9:15 [dpdk-dev] [PATCH 0/3] Bug fixes in event crypto adapter test application Ankur Dwivedi
2020-09-08  9:15 ` [dpdk-dev] [PATCH 1/3] test/event_crypto_adapter: return error with unsupported mode Ankur Dwivedi
2020-09-11  7:37   ` Gujjar, Abhinandan S
2020-09-18  7:10     ` Gujjar, Abhinandan S
2020-09-18 14:34       ` Ankur Dwivedi
2020-09-18 14:42         ` Gujjar, Abhinandan S
2020-09-18 15:03           ` Ankur Dwivedi
2020-09-23  5:31             ` Ankur Dwivedi
2020-09-23  7:17               ` Gujjar, Abhinandan S
2020-10-08  9:12   ` Jerin Jacob
2020-09-08  9:15 ` [dpdk-dev] [PATCH 2/3] test/event_crypto_adapter: fix function arguments Ankur Dwivedi
2020-09-08  9:15 ` [dpdk-dev] [PATCH 3/3] test/event_crypto_adapter: free resources during exit Ankur Dwivedi
2020-09-25  7:28 ` [dpdk-dev] [PATCH v2 0/3] Bug fixes in event crypto adapter test application Ankur Dwivedi
2020-09-25  7:28   ` Ankur Dwivedi [this message]
2020-09-25  7:28   ` [dpdk-dev] [PATCH v2 2/3] test/event_crypto_adapter: fix function arguments Ankur Dwivedi
2020-10-06 10:21     ` Gujjar, Abhinandan S
2020-10-06 12:57       ` Ankur Dwivedi
2020-09-25  7:28   ` [dpdk-dev] [PATCH v2 3/3] test/event_crypto_adapter: free resources during exit Ankur Dwivedi
2020-10-06 10:21     ` Gujjar, Abhinandan S
2020-10-06 10:29       ` Gujjar, Abhinandan S
2020-10-06 13:00         ` Ankur Dwivedi
2020-10-05  9:43   ` [dpdk-dev] [PATCH v2 0/3] Bug fixes in event crypto adapter test application Jerin Jacob
2020-10-05  9:48     ` Gujjar, Abhinandan S
2020-10-07  5:26   ` [dpdk-dev] [PATCH v3 0/3] Bug fixes in event crypto adapter test Ankur Dwivedi
2020-10-07  5:26     ` [dpdk-dev] [PATCH v3 1/3] test/event_crypto_adapter: return error with unsupported mode Ankur Dwivedi
2020-10-08  7:25       ` Gujjar, Abhinandan S
2020-10-07  5:26     ` [dpdk-dev] [PATCH v3 2/3] test/event_crypto_adapter: fix function arguments Ankur Dwivedi
2020-10-08  7:26       ` Gujjar, Abhinandan S
2020-10-07  5:26     ` [dpdk-dev] [PATCH v3 3/3] test/event_crypto_adapter: free resources during exit Ankur Dwivedi
2020-10-08  7:26       ` Gujjar, Abhinandan S
2020-10-08 12:52     ` [dpdk-dev] [PATCH v4 0/3] Bug fixes in event crypto adapter test Ankur Dwivedi
2020-10-08 12:52       ` [dpdk-dev] [PATCH v4 1/3] test/event_crypto_adapter: return error for unsupported mode Ankur Dwivedi
2020-10-08 12:52       ` [dpdk-dev] [PATCH v4 2/3] test/event_crypto_adapter: fix function arguments Ankur Dwivedi
2020-10-08 12:52       ` [dpdk-dev] [PATCH v4 3/3] test/event_crypto_adapter: free resources during exit Ankur Dwivedi
2020-10-08 15:00       ` [dpdk-dev] [PATCH v4 0/3] Bug fixes in event crypto adapter test Jerin Jacob

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200925072841.17578-2-adwivedi@marvell.com \
    --to=adwivedi@marvell.com \
    --cc=abhinandan.gujjar@intel.com \
    --cc=anoobj@marvell.com \
    --cc=dev@dpdk.org \
    --cc=jerinj@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git