From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D8C1EA04DB; Mon, 28 Sep 2020 18:21:45 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 791A62BA8; Mon, 28 Sep 2020 18:21:43 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id A909C1D629 for ; Mon, 28 Sep 2020 18:21:41 +0200 (CEST) IronPort-SDR: MzgpUrMrk6veEGtHawTE7Jhu5JMeQoz5Tcd8az/YkqlCa9/wIjSKx7G3RthOp7898d0liP8xJ+ +Ux+mTWNTpcQ== X-IronPort-AV: E=McAfee;i="6000,8403,9758"; a="159362487" X-IronPort-AV: E=Sophos;i="5.77,313,1596524400"; d="scan'208";a="159362487" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Sep 2020 09:21:36 -0700 IronPort-SDR: VDvfUfN/wAs5y2HA8r59zWtBHpnb3jI6kBICRGv0S00Z3hx6IoDbiHsPnf7EGdtmfBGSEe+Nfb qzSp/cHu2ufw== X-IronPort-AV: E=Sophos;i="5.77,313,1596524400"; d="scan'208";a="514319401" Received: from bricha3-mobl.ger.corp.intel.com ([10.213.192.54]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 28 Sep 2020 09:21:34 -0700 Date: Mon, 28 Sep 2020 17:21:30 +0100 From: Bruce Richardson To: "Wang, Haiyue" Cc: "Yigit, Ferruh" , "Guo, Jia" , "Wu, Jingjing" , "Zhang, Qi Z" , "Xing, Beilei" , "dev@dpdk.org" Message-ID: <20200928162130.GF951@bricha3-MOBL.ger.corp.intel.com> References: <20200909025415.6185-1-jia.guo@intel.com> <20200927020859.69387-1-jia.guo@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [dpdk-dev] [PATCH v6] net/iavf: support flex desc metadata extraction X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Sep 28, 2020 at 05:17:24PM +0100, Wang, Haiyue wrote: > + Bruce > > > -----Original Message----- > > From: Ferruh Yigit > > Sent: Tuesday, September 29, 2020 00:00 > > To: Guo, Jia ; Wu, Jingjing ; Zhang, Qi Z > > ; Xing, Beilei > > Cc: dev@dpdk.org; Wang, Haiyue > > Subject: Re: [dpdk-dev] [PATCH v6] net/iavf: support flex desc metadata extraction > > > > On 9/27/2020 3:08 AM, Jeff Guo wrote: > > > Enable metadata extraction for flexible descriptors in AVF, that would > > > allow network function directly get metadata without additional parsing > > > which would reduce the CPU cost for VFs. The enabling metadata > > > extractions involve the metadata of VLAN/IPv4/IPv6/IPv6-FLOW/TCP/MPLS > > > flexible descriptors, and the VF could negotiate the capability of > > > the flexible descriptor with PF and correspondingly configure the > > > specific offload at receiving queues. > > > > > > Signed-off-by: Jeff Guo > > > Acked-by: Haiyue Wang > > > > <...> > > > > > +/* Rx L3/L4 checksum */ > > > +static inline uint64_t > > > +iavf_rxd_error_to_pkt_flags(uint16_t stat_err0) > > > +{ > > > +uint64_t flags = 0; > > > + > > > +/* check if HW has decoded the packet and checksum */ > > > +if (unlikely(!(stat_err0 & (1 << IAVF_RX_FLEX_DESC_STATUS0_L3L4P_S)))) > > > +return 0; > > > + > > > +if (likely(!(stat_err0 & IAVF_RX_FLEX_ERR0_BITS))) { > > > +flags |= (PKT_RX_IP_CKSUM_GOOD | PKT_RX_L4_CKSUM_GOOD); > > > +return flags; > > > +} > > > + > > > +if (unlikely(stat_err0 & (1 << IAVF_RX_FLEX_DESC_STATUS0_XSUM_IPE_S))) > > > +flags |= PKT_RX_IP_CKSUM_BAD; > > > +else > > > +flags |= PKT_RX_IP_CKSUM_GOOD; > > > + > > > +if (unlikely(stat_err0 & (1 << IAVF_RX_FLEX_DESC_STATUS0_XSUM_L4E_S))) > > > +flags |= PKT_RX_L4_CKSUM_BAD; > > > +else > > > +flags |= PKT_RX_L4_CKSUM_GOOD; > > > + > > > +if (unlikely(stat_err0 & (1 << IAVF_RX_FLEX_DESC_STATUS0_XSUM_EIPE_S))) > > > +flags |= PKT_RX_EIP_CKSUM_BAD; > > > + > > > +return flags; > > > +} > > > > Is this static inline function used anywhere? If not can we delete it? > > > > The same function as iavf_flex_rxd_error_to_pkt_flags. > > Looks like meson/gcc missed this [-Werror,-Wunused-function] capturing. > http://mails.dpdk.org/archives/test-report/2020-September/154839.html > AFAIK, unused static functions get a warning about being unused, static inline functions don't. Unless you are defining a function in a header files, I'd recommend omitting the "inline" part so you do get unused function errors. /Bruce