From: Chenxu Di <chenxux.di@intel.com>
To: dev@dpdk.org
Cc: junyux.jiang@intel.com, shougangx.wang@intel.com,
Jeff Guo <jia.guo@intel.com>, Haiyue Wang <haiyue.wang@intel.com>
Subject: [dpdk-dev] [RFC 2/5] net/igc: decouple dependency from superseded structures
Date: Tue, 29 Sep 2020 07:48:33 +0000 [thread overview]
Message-ID: <20200929074835.39854-1-chenxux.di@intel.com> (raw)
From: Junyu Jiang <junyux.jiang@intel.com>
The legacy filter API will be removed, the associated rte_eth_ctrl.h
will also be removed. This patch replaces these superseded structures
by the PMD internal structures.
Signed-off-by: Junyu Jiang <junyux.jiang@intel.com>
---
drivers/net/igc/igc_filter.c | 2 +-
drivers/net/igc/igc_filter.h | 2 ++
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/igc/igc_filter.c b/drivers/net/igc/igc_filter.c
index 836621d4c..7b6f52a4c 100644
--- a/drivers/net/igc/igc_filter.c
+++ b/drivers/net/igc/igc_filter.c
@@ -216,7 +216,7 @@ igc_enable_tuple_filter(struct rte_eth_dev *dev,
ttqf &= ~IGC_TTQF_MASK_ENABLE;
/* TCP flags bits setting. */
- if (info->tcp_flags & RTE_NTUPLE_TCP_FLAGS_MASK) {
+ if (info->tcp_flags & IGC_NTUPLE_TCP_FLAGS_MASK) {
if (info->tcp_flags & RTE_TCP_URG_FLAG)
imir_ext |= IGC_IMIREXT_CTRL_URG;
if (info->tcp_flags & RTE_TCP_ACK_FLAG)
diff --git a/drivers/net/igc/igc_filter.h b/drivers/net/igc/igc_filter.h
index 79951504f..34bc0a7e3 100644
--- a/drivers/net/igc/igc_filter.h
+++ b/drivers/net/igc/igc_filter.h
@@ -16,6 +16,8 @@
extern "C" {
#endif
+#define IGC_NTUPLE_TCP_FLAGS_MASK 0x3F /**< TCP flags filter can match. */
+
int igc_add_ethertype_filter(struct rte_eth_dev *dev,
const struct igc_ethertype_filter *filter);
int igc_del_ethertype_filter(struct rte_eth_dev *dev,
--
2.17.1
next reply other threads:[~2020-09-29 8:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-29 7:48 Chenxu Di [this message]
2020-09-29 7:48 ` [dpdk-dev] [RFC 3/5] net/e1000: " Chenxu Di
2020-09-29 7:48 ` [dpdk-dev] [RFC 4/5] net/ixgbe: " Chenxu Di
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200929074835.39854-1-chenxux.di@intel.com \
--to=chenxux.di@intel.com \
--cc=dev@dpdk.org \
--cc=haiyue.wang@intel.com \
--cc=jia.guo@intel.com \
--cc=junyux.jiang@intel.com \
--cc=shougangx.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).