From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 20A82A04B1; Tue, 29 Sep 2020 21:57:47 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B65EC1DA99; Tue, 29 Sep 2020 21:57:44 +0200 (CEST) Received: from mail-pj1-f65.google.com (mail-pj1-f65.google.com [209.85.216.65]) by dpdk.org (Postfix) with ESMTP id 141C81DA7C for ; Tue, 29 Sep 2020 21:57:42 +0200 (CEST) Received: by mail-pj1-f65.google.com with SMTP id md22so4228401pjb.0 for ; Tue, 29 Sep 2020 12:57:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=dc8WnhEcLyqsWUV1TqgS2MyWAMj1bt7zaLnCJkDpAiM=; b=b9M9wDGAIk/ZrgkMs/D1wQeOb3pnAEOuuo+VaC+h4yV0LPj4X+JcHRnHbvsGM8Eotz KHVS7vKEzQ/AnNj0V5FqdLmixRJczgRsrXWjJP3GtRQyVRiuIX3ZdROryHAgDSApBDhK l+ple3QmyxI9nNwWjggPXDj5FCf1mulxjNW/JZ+M9Mtq8KOxvWDSJjFm5mQyZB7ZB1n9 oiu4TM+L/Y6eHtgMsCBtF2p/6NXG42S5epr7GZZvlgRa/z+o+cVl9j++xBKQb9cNjtSW toIDqVVn3YvkCEHB8lcEonfZP+CJw4ebhPZnp0jQUleKt0cfGuFWalGIsC93nQOhgnPB TK3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=dc8WnhEcLyqsWUV1TqgS2MyWAMj1bt7zaLnCJkDpAiM=; b=PXL4J/5bcNEzQ3eg7vIT5ANzmbRQFqnyHioXR9eNOMuFg6VqZeyVl4WeaDPI1GXA0Z 4VkIu/5qHXm142TDcdIaicByMDb4NIUoQ/ObNFwEMlWxXPMVpmedz/kxUKf/EzBJGX+2 PMopdtWKe2th/2ngAghwQ4fwpFRUH/p6CsSOYfUw1L5/tCQnulWFhLfyqP5wNLZgq7eX AMLJEmpfdOBuSWSfb9k7FFAvxgFOMkdyTZPNCpmFp4FY1FtzkpwOOKnRyT0qPwcKjvO6 0e4GXUWh1dU6ENr2HsWhHny9grnufbVwJtwx/b395CR4nUP/ydgEkkHnhtAWAUdRH2Yx em6Q== X-Gm-Message-State: AOAM531YKqcHe2xkoFKOFTwosxFi07Q540mHO8WgitcM518v5rPZls2a L0EO4wg1LgxmiqKUdk3Jf1nBHw== X-Google-Smtp-Source: ABdhPJyA4F9cFa1Lv+rL075abuLL8/JyeagKTbvVvbnaylxwf1hRW3NxowvzqU7P27t4q5rJQ0axzQ== X-Received: by 2002:a17:90b:289:: with SMTP id az9mr5427072pjb.31.1601409460186; Tue, 29 Sep 2020 12:57:40 -0700 (PDT) Received: from hermes.local (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id h9sm5618425pgk.52.2020.09.29.12.57.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Sep 2020 12:57:39 -0700 (PDT) Date: Tue, 29 Sep 2020 12:57:31 -0700 From: Stephen Hemminger To: wangyunjian Cc: , , , , , , Message-ID: <20200929125731.5dfafd26@hermes.local> In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] net/octeontx2: remove logically dead code X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, 26 Aug 2020 19:18:09 +0800 wangyunjian wrote: > if (tx_qconf) > free(tx_qconf); > - if (rx_qconf) > - free(rx_qconf); free accepts a NULL pointer so current practice is to avoid useless if() tests before free.