From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 64C74A04BC; Tue, 29 Sep 2020 17:45:40 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DFC241D941; Tue, 29 Sep 2020 17:45:36 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 3FEFD1BFFB for ; Tue, 29 Sep 2020 17:45:35 +0200 (CEST) IronPort-SDR: 7oSer4FabS5kj9nTkt2fhIo+8jc3Lbs4ywjNDSoszPQcWWgbDncPtPskZg0BJyAZts00PDgdw+ Ei0xz34rYP/g== X-IronPort-AV: E=McAfee;i="6000,8403,9759"; a="162283898" X-IronPort-AV: E=Sophos;i="5.77,319,1596524400"; d="scan'208";a="162283898" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Sep 2020 08:45:33 -0700 IronPort-SDR: fWuJbFoKzw/iBHWFjXdVegC6AatH4KteiqHd/i5vAJBOPkgkJhHJbehr3lzK45ocC+9378kuQz vBiG1VXfqtZQ== X-IronPort-AV: E=Sophos;i="5.77,319,1596524400"; d="scan'208";a="312258086" Received: from bricha3-mobl.ger.corp.intel.com ([10.213.220.178]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 29 Sep 2020 08:45:31 -0700 Date: Tue, 29 Sep 2020 16:45:27 +0100 From: Bruce Richardson To: Thomas Monjalon Cc: David Marchand , Andrew Rybchenko , dev@dpdk.org, Ferruh Yigit , Morten =?iso-8859-1?Q?Br=F8rup?= , Ivan Dyukov Message-ID: <20200929154527.GA966@bricha3-MOBL.ger.corp.intel.com> References: <20200929121222.12954-1-david.marchand@redhat.com> <802bfe55-2738-41b7-3af8-65d7d4636963@solarflare.com> <3091094.eTDPxqWGOJ@thomas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3091094.eTDPxqWGOJ@thomas> Subject: Re: [dpdk-dev] [PATCH] ethdev: fix link speed helper documentation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Sep 29, 2020 at 02:52:34PM +0200, Thomas Monjalon wrote: > 29/09/2020 14:17, Andrew Rybchenko: > > On 9/29/20 3:12 PM, David Marchand wrote: > > > When generating the documentation, a new warning can be seen: > > > > > > .../dpdk/lib/librte_ethdev/rte_ethdev.h:2441: > > > warning: argument 'link_speed' of command @param is not found in the > > > argument list of rte_eth_link_speed_to_str(uint32_t speed_link) > > > .../dpdk/lib/librte_ethdev/rte_ethdev.h:2455: warning: The following > > > parameters of rte_eth_link_speed_to_str(uint32_t speed_link) are not > > > documented: parameter 'speed_link' > > > > > > Align the function prototype to its doxygen description. > > > > > > Fixes: fbf931c9c392 ("ethdev: format link status text") > > > > > > Signed-off-by: David Marchand > > > > Acked-by: Andrew Rybchenko > > More errors of the same kind will happen because doxygen warnings > are sent to stdout by meson, so are hard to catch. > Technically that's "ninja" behaviour by default rather than meson - just to ensure we blame the right tool! :-) I've sent patchset http://patches.dpdk.org/project/dpdk/list/?series=12595 to try and improve this situation. Regards, /Bruce