Re: [dpdk-dev] [PATCH v9 00/11] adding support for python 3 only

[Bruce Richardson <bruce.richardson@intel.com>]

On Tue, Sep 29, 2020 at 04:25:40PM +0100, Kevin Laatz wrote:
> On 29/09/2020 13:22, David Marchand wrote:
> > Hello Kevin,
> > 
> > On Tue, Sep 29, 2020 at 12:27 PM Kevin Laatz <kevin.laatz@intel.com> wrote:
> > > This patch set converts all python scripts in the project to use
> > > python3 only and removes all deprecation notices associated with these
> > > changes. This is due to python2 being EOL in January 2020.
> > > 
> > > ---
> > > v6:
> > >    - rebased, removing conflict with make removal patchset.
> > >    - added changes to buildtools/map_to_win.py
> > > 
> > > v7:
> > >    - typo in email Cc'ing David Marchand
> > >    - added maintainers for buildtools patch
> > > 
> > > v8:
> > >    - removed unrelated cleanup
> > >    - replaced integer cast with integer division operator
> > > 
> > > v9:
> > >    - include documentation updates
> > > 
> > > Kevin Laatz (4):
> > >    app/test-cmdline: support python3 only
> > >    app/test: support python3 only
> > >    buildtools: support python3 only
> > >    doc: support python3 only
> > > 
> > > Louise Kilheeney (7):
> > >    usertools/dpdk-telemetry-client: support python3 only
> > >    usertools/dpdk-devbind: support python3 only
> > >    usertools/dpdk-pmdinfo: support python3 only
> > >    usertools/cpu_layout: support python3 only
> > >    devtools: support python3 only
> > >    config/arm: support python3 only
> > >    app/test-bbdev: support python3 only
> 
> Hi David,
> 
> > I can still see one issue in doc/guides/conf.py as you mentioned yesterday.
> > There is also a script that directly calls /usr/bin/python3, worth
> > fixing from my pov.
> > 
> > $ for file in $(find app/ buildtools/ config/ devtools/ doc/ drivers/
> > examples/ kernel/ lib/ license/ usertools/ -name "*.py"); do head -1
> > $file |grep -q env.*python3 || echo $file; done
> > doc/guides/conf.py
> > usertools/dpdk-telemetry.py
> 
> doc/guides/conf.py is indirectly called from sphinx which potentially causes some compatibilty issues when we make conf.py only support python3 (if sphinx in using python2) - this is why I left this out of the patchset, otherwise the doc build will be broken :-(
> 
> I can change direct call to /usr/bin/python3.
> 

I think we should err on the side of caution for the doc one - it can
always be changed by a later patch anyway. Cleaning up the dpdk-telemetry
one is probably worth doing though, I agree.

/Bruce