From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C1E53A04BC; Tue, 29 Sep 2020 18:23:37 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E21301DA33; Tue, 29 Sep 2020 18:23:35 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 4F3FF1D9FD for ; Tue, 29 Sep 2020 18:23:34 +0200 (CEST) IronPort-SDR: X/k+9ZIksZxODdsXy5FmLHsUDkKjWeyI2LaC+IuuZChoaA8fRII+vNOrinycH7GuzuOrX8Q8SC rMx2jw/J/aSA== X-IronPort-AV: E=McAfee;i="6000,8403,9759"; a="159603405" X-IronPort-AV: E=Sophos;i="5.77,319,1596524400"; d="scan'208";a="159603405" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Sep 2020 09:23:30 -0700 IronPort-SDR: Sxx22/lukRAAff+lyoEJpdu+BscvqQVgo9B8KepBLcvcxorDsBu3cXMUX/hubVrOq2mslGwmde U7lihcI6cB1A== X-IronPort-AV: E=Sophos;i="5.77,319,1596524400"; d="scan'208";a="514743289" Received: from bricha3-mobl.ger.corp.intel.com ([10.213.220.178]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 29 Sep 2020 09:23:29 -0700 Date: Tue, 29 Sep 2020 17:23:26 +0100 From: Bruce Richardson To: Thomas Monjalon Cc: dev@dpdk.org Message-ID: <20200929162325.GC966@bricha3-MOBL.ger.corp.intel.com> References: <20200929153413.280581-1-bruce.richardson@intel.com> <20200929153413.280581-2-bruce.richardson@intel.com> <3530692.ZXM58GVc4I@thomas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3530692.ZXM58GVc4I@thomas> Subject: Re: [dpdk-dev] [PATCH 1/4] doc/api: hide verbose doxygen standard output X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Sep 29, 2020 at 05:55:44PM +0200, Thomas Monjalon wrote: > > The standard output of doxygen is very verbose, and since ninja mixes > > stdout and stderr together it makes it difficult to see any warnings from > > the doxygen run. Therefore, we can just log the standard output to file, > > and only output the stderr to make warnings clear. > [...] > > -doxygen "${DOXYCONF}" | tee doxygen.out > > +doxygen "${DOXYCONF}" > doxygen.out > > ninja is printing extra lines: > ninja: Entering directory `build' > [0/1] Running external command doc > Building docs: Doxygen_API HTML_Guides > > It makes hard to detect whether all run fine or not. > Can we remove these extra lines with a ninja option? > Can we return an error if there are some errors in doxygen? > If doxygen fails, then the whole build should fail - though to be honest that is hard to test since most invalid changes I've tried making end up just as warnings. The wrapper script for doxygen has "-e" flag so it should fail if any part of it does, i.e. doxygen, and ninja always returns error if any subtask fails. There is also the WARN_AS_ERROR setting for doxygen which we can use if you want to be stricter [1]. Once all warnings are fixed, I'd suggest setting that based on the werror setting for the build as a whole. [1] https://www.doxygen.nl/manual/config.html#cfg_warn_as_error