From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E435EA04B5; Wed, 30 Sep 2020 11:01:33 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 392B91D5CC; Wed, 30 Sep 2020 11:01:32 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 270AA1D5C1 for ; Wed, 30 Sep 2020 11:01:30 +0200 (CEST) IronPort-SDR: vpEGu/J8geOTxYCryrAq4jNZL1q/SLAmE8mUP1/jneWPzC8S9VWoldFm+LzsCWuY+5qt3KidAs PNRS+Mqsco8g== X-IronPort-AV: E=McAfee;i="6000,8403,9759"; a="223994784" X-IronPort-AV: E=Sophos;i="5.77,321,1596524400"; d="scan'208";a="223994784" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Sep 2020 02:01:28 -0700 IronPort-SDR: KgprmGoT+ePFDpUt+ey9+9uYy8R9KNDVWS9C4sMcb7jcj8FmPLaP1WApdqSIcpEsMC5zaYLYeN zbd0+I3HjNhQ== X-IronPort-AV: E=Sophos;i="5.77,322,1596524400"; d="scan'208";a="457581623" Received: from bricha3-mobl.ger.corp.intel.com ([10.213.29.17]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 30 Sep 2020 02:01:27 -0700 Date: Wed, 30 Sep 2020 10:01:22 +0100 From: Bruce Richardson To: Thomas Monjalon Cc: dev@dpdk.org, i.dyukov@samsung.com Message-ID: <20200930090122.GA977@bricha3-MOBL.ger.corp.intel.com> References: <20200929153413.280581-1-bruce.richardson@intel.com> <20200929165502.336919-1-bruce.richardson@intel.com> <20200929165502.336919-6-bruce.richardson@intel.com> <16615567.jCnPzILXAk@thomas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <16615567.jCnPzILXAk@thomas> Subject: Re: [dpdk-dev] [PATCH v2 5/6] ethdev: fix mis-named parameter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Sep 29, 2020 at 07:34:17PM +0200, Thomas Monjalon wrote: > > The parameter to rte_eth_link_speed_to_str was called "speed_link" in > > the function prototype in the header file, but "link_speed" everywhere > > else. This showed up as warnings when building the API docs, due to > > missing and undocumented parameters from doxygen's viewpoint. > > > > Rename the prototype value to the correct name to fix these issues. > > It has been fixed by David and merged already by Ferruh. > Yep, I guessed there was a patch outstanding for it from someone, though I think the patch wasn't merged when I did this patch, so I included it to guarantee that this patchset didn't break the build when werror was turned on. /Bruce