From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7D911A04B5; Thu, 1 Oct 2020 09:55:37 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 73C5F1D6F7; Thu, 1 Oct 2020 09:55:35 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by dpdk.org (Postfix) with ESMTP id 1885F1D56F for ; Thu, 1 Oct 2020 09:55:32 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1601538928; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ctifEM8bBo55cr6RJzuya89931/kswERr33YWiPKyCI=; b=Yd8fE6xL0ixT80wuqhADHj578VEaN1SyO4qcbX257phG4Iv+mOIef1of5+/AhQXa2fuNeC O5MMR4oHblUqi++GtYXca2IkgRZhbTem0OP7De7fxSQ5E7uiwUdi+FwN/8nd54TT7ilk6k z/9CSsIW/XGYdi/68B/GpFuBi6Kc018= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-1-JwzOUjkAOFG6uYAmZNKcPQ-1; Thu, 01 Oct 2020 03:55:26 -0400 X-MC-Unique: JwzOUjkAOFG6uYAmZNKcPQ-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 44BBE8015C3; Thu, 1 Oct 2020 07:55:24 +0000 (UTC) Received: from dmarchan.remote.csb (unknown [10.40.193.185]) by smtp.corp.redhat.com (Postfix) with ESMTP id 75C2519C59; Thu, 1 Oct 2020 07:55:21 +0000 (UTC) From: David Marchand To: dev@dpdk.org Cc: Anoob Joseph , Ray Kinsella , Neil Horman , Liron Himi , Harman Kalra Date: Thu, 1 Oct 2020 09:55:17 +0200 Message-Id: <20201001075517.5838-1-david.marchand@redhat.com> In-Reply-To: <20200902095957.19121-1-david.marchand@redhat.com> References: <20200902095957.19121-1-david.marchand@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=david.marchand@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII" Subject: [dpdk-dev] [PATCH v2] drivers/common: mark all symbols as internal X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Now that we have the internal tag, let's avoid confusion with exported symbols in common drivers that were using the experimental tag as a workaround. There is also no need to put internal API symbols in the public stable ABI. Signed-off-by: David Marchand Acked-by: Anoob Joseph --- Changes since v1: - rebased and dropped iavf bits, --- drivers/common/cpt/cpt_pmd_ops_helper.h | 8 +++++--- drivers/common/cpt/rte_common_cpt_version.map | 13 +++---------- drivers/common/mvep/rte_common_mvep_version.map | 2 +- drivers/common/mvep/rte_mvep_common.h | 3 +++ drivers/common/octeontx/octeontx_mbox.h | 5 +++++ .../common/octeontx/rte_common_octeontx_version.map | 2 +- 6 files changed, 18 insertions(+), 15 deletions(-) diff --git a/drivers/common/cpt/cpt_pmd_ops_helper.h b/drivers/common/cpt/cpt_pmd_ops_helper.h index 716ae94c8e..413ca50edd 100644 --- a/drivers/common/cpt/cpt_pmd_ops_helper.h +++ b/drivers/common/cpt/cpt_pmd_ops_helper.h @@ -18,7 +18,7 @@ * @return * - length */ - +__rte_internal int32_t cpt_pmd_ops_helper_get_mlen_direct_mode(void); @@ -29,6 +29,7 @@ cpt_pmd_ops_helper_get_mlen_direct_mode(void); * @return * - length */ +__rte_internal int cpt_pmd_ops_helper_get_mlen_sg_mode(void); @@ -38,6 +39,7 @@ cpt_pmd_ops_helper_get_mlen_sg_mode(void); * @return * - length */ +__rte_internal int cpt_pmd_ops_helper_asym_get_mlen(void); @@ -50,13 +52,13 @@ cpt_pmd_ops_helper_asym_get_mlen(void); * @return * - 0 on success, negative on error */ -__rte_experimental +__rte_internal int cpt_fpm_init(uint64_t *fpm_table_iova); /* * Clear ECC FMUL precomputed table */ -__rte_experimental +__rte_internal void cpt_fpm_clear(void); #endif /* _CPT_PMD_OPS_HELPER_H_ */ diff --git a/drivers/common/cpt/rte_common_cpt_version.map b/drivers/common/cpt/rte_common_cpt_version.map index 4d85021a87..b4080e0f8c 100644 --- a/drivers/common/cpt/rte_common_cpt_version.map +++ b/drivers/common/cpt/rte_common_cpt_version.map @@ -1,18 +1,11 @@ -DPDK_21 { +INTERNAL { global: + cpt_fpm_clear; + cpt_fpm_init; cpt_pmd_ops_helper_asym_get_mlen; cpt_pmd_ops_helper_get_mlen_direct_mode; cpt_pmd_ops_helper_get_mlen_sg_mode; local: *; }; - -EXPERIMENTAL { - global: - - cpt_fpm_clear; - cpt_fpm_init; - - local: *; -}; diff --git a/drivers/common/mvep/rte_common_mvep_version.map b/drivers/common/mvep/rte_common_mvep_version.map index e5af82c61d..cbac7bfa8d 100644 --- a/drivers/common/mvep/rte_common_mvep_version.map +++ b/drivers/common/mvep/rte_common_mvep_version.map @@ -1,4 +1,4 @@ -DPDK_21 { +INTERNAL { global: rte_mvep_deinit; diff --git a/drivers/common/mvep/rte_mvep_common.h b/drivers/common/mvep/rte_mvep_common.h index 0593cefcd2..b10540316b 100644 --- a/drivers/common/mvep/rte_mvep_common.h +++ b/drivers/common/mvep/rte_mvep_common.h @@ -5,6 +5,7 @@ #ifndef __RTE_MVEP_COMMON_H__ #define __RTE_MVEP_COMMON_H__ +#include #include enum mvep_module_type { @@ -15,7 +16,9 @@ enum mvep_module_type { MVEP_MOD_T_LAST }; +__rte_internal int rte_mvep_init(enum mvep_module_type module, struct rte_kvargs *kvlist); +__rte_internal int rte_mvep_deinit(enum mvep_module_type module); #endif /* __RTE_MVEP_COMMON_H__ */ diff --git a/drivers/common/octeontx/octeontx_mbox.h b/drivers/common/octeontx/octeontx_mbox.h index e56719cb85..706b198f6e 100644 --- a/drivers/common/octeontx/octeontx_mbox.h +++ b/drivers/common/octeontx/octeontx_mbox.h @@ -35,11 +35,16 @@ struct octeontx_mbox_hdr { uint8_t res_code; /* Functional layer response code */ }; +__rte_internal int octeontx_mbox_init(void); void octeontx_set_global_domain(uint16_t global_domain); +__rte_internal uint16_t octeontx_get_global_domain(void); +__rte_internal int octeontx_mbox_set_ram_mbox_base(uint8_t *ram_mbox_base, uint16_t domain); +__rte_internal int octeontx_mbox_set_reg(uint8_t *reg, uint16_t domain); +__rte_internal int octeontx_mbox_send(struct octeontx_mbox_hdr *hdr, void *txdata, uint16_t txlen, void *rxdata, uint16_t rxlen); diff --git a/drivers/common/octeontx/rte_common_octeontx_version.map b/drivers/common/octeontx/rte_common_octeontx_version.map index 30f3fa65e0..049f66b331 100644 --- a/drivers/common/octeontx/rte_common_octeontx_version.map +++ b/drivers/common/octeontx/rte_common_octeontx_version.map @@ -1,4 +1,4 @@ -DPDK_21 { +INTERNAL { global: octeontx_get_global_domain; -- 2.23.0