From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 91207A04B5; Fri, 2 Oct 2020 13:18:44 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A9D8A1D575; Fri, 2 Oct 2020 13:18:42 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id A246F1D56E for ; Fri, 2 Oct 2020 13:18:41 +0200 (CEST) IronPort-SDR: g3zbWlrTaB3lotU5y9xKOVI3uxOa9TxxWy5vLrann5ZzUjWmkqV4yuUaFLyDE44W+kuUvwl3x1 JOYU4GY0x7tA== X-IronPort-AV: E=McAfee;i="6000,8403,9761"; a="247705832" X-IronPort-AV: E=Sophos;i="5.77,327,1596524400"; d="scan'208";a="247705832" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Oct 2020 04:18:34 -0700 IronPort-SDR: ffk4zSvcCusyx6aKbeS+I0Q8g1LxZyo8t7dFwP53IOPFEdoguyJdTSWGwS0CzznIBhdciRQILD g0Lvx2cezmTw== X-IronPort-AV: E=Sophos;i="5.77,327,1596524400"; d="scan'208";a="508126601" Received: from bricha3-mobl.ger.corp.intel.com ([10.213.30.87]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 02 Oct 2020 04:18:28 -0700 Date: Fri, 2 Oct 2020 12:18:23 +0100 From: Bruce Richardson To: David Marchand Cc: Kevin Laatz , Thomas Monjalon , dev , "Burakov, Anatoly" , Robin Jarry , Stephen Hemminger , Ray Kinsella , Neil Horman , John McNamara , Marko Kovacevic , Timothy Redaelli , Luca Boccassi Message-ID: <20201002111823.GA1325@bricha3-MOBL.ger.corp.intel.com> References: <20200929102224.440322-1-kevin.laatz@intel.com> <20200930114024.446473-1-kevin.laatz@intel.com> <20200930114024.446473-12-kevin.laatz@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [dpdk-dev] [PATCH v10 11/11] doc: support python3 only X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Oct 02, 2020 at 01:01:13PM +0200, David Marchand wrote: > On Wed, Sep 30, 2020 at 1:45 PM Kevin Laatz wrote: > > diff --git a/doc/guides/conf.py b/doc/guides/conf.py > > index 9ebc26ed3f..ef550f68c0 100644 > > --- a/doc/guides/conf.py > > +++ b/doc/guides/conf.py > > @@ -1,7 +1,7 @@ > > +#!/usr/bin/env python3 > > # SPDX-License-Identifier: BSD-3-Clause > > # Copyright(c) 2010-2015 Intel Corporation > > > > -from __future__ import print_function > > from docutils import nodes > > from distutils.version import LooseVersion > > from sphinx import __version__ as sphinx_version > > @@ -13,12 +13,7 @@ > > from os.path import dirname > > from os.path import join as path_join > > > > -try: > > - # Python 2. > > - import ConfigParser as configparser > > -except: > > - # Python 3. > > - import configparser > > +import configparser > > I am ok with dropping this part: the doc generation with python 2 / an > old sphinx is already broken since 20.02 with meson. > I can give details for people interested. > I'm ok with this. I suspect most non-developers of DPDK just use the published docs on the website. > > > > > try: > > import sphinx_rtd_theme > > diff --git a/doc/guides/contributing/coding_style.rst b/doc/guides/contributing/coding_style.rst > > index 0be9546a6a..4fc010ca49 100644 > > --- a/doc/guides/contributing/coding_style.rst > > +++ b/doc/guides/contributing/coding_style.rst > > @@ -765,7 +765,7 @@ specializations, run the ``app/test`` binary, and use the ``dump_log_types`` > > Python Code > > ----------- > > > > -All Python code should work with Python 2.7+ and 3.2+ and be compliant with > > +All Python code should work with 3.2+ and be compliant with > > `PEP8 (Style Guide for Python Code) `_. > > I am for dropping any mention of a version here. > On current HEAD of the main branch, the requirements already ask for a > 3.5 version. > I would simply ask for PEP8 compliance in this doc. > > Opinion? > Ok with this too.