From: "Jayatheerthan, Jay" <jay.jayatheerthan@intel.com>
To: jerinj@marvell.com, thomas@monjalon.net, nikhil.rao@intel.com
Cc: dev@dpdk.org, stable@dpdk.org, jay.jayatheerthan@intel.com
Subject: [dpdk-dev] [PATCH 2/2] app/test: add net null dev creation in Rx adapter autotest
Date: Sat, 3 Oct 2020 14:35:41 +0530 [thread overview]
Message-ID: <20201003090541.32449-2-jay.jayatheerthan@intel.com> (raw)
In-Reply-To: <20201003090541.32449-1-jay.jayatheerthan@intel.com>
From: "Jay Jayatheerthan" <jay.jayatheerthan@intel.com>
Allows creation of net_null if vdev EAL option is not specified and
uninit vdev created in the test. The change also adds error checks
for vdev init and uninit.
Signed-off-by: Jay Jayatheerthan <jay.jayatheerthan@intel.com>
---
app/test/test_event_eth_rx_adapter.c | 61 +++++++++++++++++++++++++++-
1 file changed, 59 insertions(+), 2 deletions(-)
diff --git a/app/test/test_event_eth_rx_adapter.c b/app/test/test_event_eth_rx_adapter.c
index 71c946164..dbf85be35 100644
--- a/app/test/test_event_eth_rx_adapter.c
+++ b/app/test/test_event_eth_rx_adapter.c
@@ -30,6 +30,8 @@ struct event_eth_rx_adapter_test_params {
};
static struct event_eth_rx_adapter_test_params default_params;
+static bool event_dev_created;
+static bool eth_dev_created;
static inline int
port_init_common(uint16_t port, const struct rte_eth_conf *port_conf,
@@ -202,7 +204,10 @@ testsuite_setup(void)
if (!count) {
printf("Failed to find a valid event device,"
" testing with event_skeleton device\n");
- rte_vdev_init("event_skeleton", NULL);
+ err = rte_vdev_init("event_skeleton", NULL);
+ TEST_ASSERT(err == 0, "Failed to create event_skeleton. err=%d",
+ err);
+ event_dev_created = true;
}
struct rte_event_dev_config config = {
@@ -222,6 +227,15 @@ testsuite_setup(void)
TEST_ASSERT(err == 0, "Event device initialization failed err %d\n",
err);
+ count = rte_eth_dev_count_total();
+ if (!count) {
+ printf("Testing with net_null device\n");
+ err = rte_vdev_init("net_null", NULL);
+ TEST_ASSERT(err == 0, "Failed to create net_null. err=%d",
+ err);
+ eth_dev_created = true;
+ }
+
/*
* eth devices like octeontx use event device to receive packets
* so rte_eth_dev_start invokes rte_event_dev_start internally, so
@@ -249,7 +263,10 @@ testsuite_setup_rx_intr(void)
if (!count) {
printf("Failed to find a valid event device,"
" testing with event_skeleton device\n");
- rte_vdev_init("event_skeleton", NULL);
+ err = rte_vdev_init("event_skeleton", NULL);
+ TEST_ASSERT(err == 0, "Failed to create event_skeleton. err=%d",
+ err);
+ event_dev_created = true;
}
struct rte_event_dev_config config = {
@@ -270,6 +287,15 @@ testsuite_setup_rx_intr(void)
TEST_ASSERT(err == 0, "Event device initialization failed err %d\n",
err);
+ count = rte_eth_dev_count_total();
+ if (!count) {
+ printf("Testing with net_null device\n");
+ err = rte_vdev_init("net_null", NULL);
+ TEST_ASSERT(err == 0, "Failed to create net_null. err=%d",
+ err);
+ eth_dev_created = true;
+ }
+
/*
* eth devices like octeontx use event device to receive packets
* so rte_eth_dev_start invokes rte_event_dev_start internally, so
@@ -292,21 +318,52 @@ testsuite_setup_rx_intr(void)
static void
testsuite_teardown(void)
{
+ int err;
uint32_t i;
RTE_ETH_FOREACH_DEV(i)
rte_eth_dev_stop(i);
+ if (eth_dev_created) {
+ err = rte_vdev_uninit("net_null");
+ if (err)
+ printf("Failed to delete net_null. err=%d", err);
+ eth_dev_created = false;
+ }
+
rte_mempool_free(default_params.mp);
+ if (event_dev_created) {
+ err = rte_vdev_uninit("event_skeleton");
+ if (err)
+ printf("Failed to delete event_skeleton. err=%d", err);
+ event_dev_created = false;
+ }
+
+ memset(&default_params, 0, sizeof(default_params));
}
static void
testsuite_teardown_rx_intr(void)
{
+ int err;
if (!default_params.rx_intr_port_inited)
return;
rte_eth_dev_stop(default_params.rx_intr_port);
+ if (eth_dev_created) {
+ err = rte_vdev_uninit("net_null");
+ if (err)
+ printf("Failed to delete net_null. err=%d", err);
+ eth_dev_created = false;
+ }
rte_mempool_free(default_params.mp);
+ if (event_dev_created) {
+ err = rte_vdev_uninit("event_skeleton");
+ if (err)
+ printf("Failed to delete event_skeleton. err=%d", err);
+ event_dev_created = false;
+ }
+
+ memset(&default_params, 0, sizeof(default_params));
}
static int
--
2.17.1
next prev parent reply other threads:[~2020-10-03 9:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-03 9:05 [dpdk-dev] [PATCH 1/2] app/test: uninit vdevs in event eth " Jayatheerthan, Jay
2020-10-03 9:05 ` Jayatheerthan, Jay [this message]
2020-10-06 17:47 ` [dpdk-dev] [PATCH 2/2] app/test: add net null dev creation in " Jayatheerthan, Jay
2020-10-07 10:15 ` Rao, Nikhil
2020-10-06 17:47 ` [dpdk-dev] [PATCH 1/2] app/test: uninit vdevs in event eth " Jayatheerthan, Jay
2020-10-07 10:13 ` Rao, Nikhil
2020-10-08 9:32 ` Jerin Jacob
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201003090541.32449-2-jay.jayatheerthan@intel.com \
--to=jay.jayatheerthan@intel.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=nikhil.rao@intel.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).