From: Stephen Hemminger <stephen@networkplumber.org>
To: nipun.gupta@nxp.com
Cc: dev@dpdk.org, thomas@monjalon.net, ferruh.yigit@intel.com,
arybchenko@solarflare.com, hemant.agrawal@nxp.com,
sachin.saxena@nxp.com, rohit.raj@nxp.com
Subject: Re: [dpdk-dev] [PATCH 1/3 v2] ethdev: add rx offload to drop error packets
Date: Mon, 5 Oct 2020 08:34:55 -0700 [thread overview]
Message-ID: <20201005083455.2fdf57f2@hermes.local> (raw)
In-Reply-To: <20201005071506.28861-1-nipun.gupta@nxp.com>
On Mon, 5 Oct 2020 12:45:04 +0530
nipun.gupta@nxp.com wrote:
> From: Nipun Gupta <nipun.gupta@nxp.com>
>
> This change adds a RX offload capability, which once enabled,
> hardware will drop the packets in case there of any error in
> the packet such as L3 checksum error or L4 checksum.
>
> Signed-off-by: Nipun Gupta <nipun.gupta@nxp.com>
> Signed-off-by: Rohit Raj <rohit.raj@nxp.com>
> ---
> These patches are based over series:
> https://patchwork.dpdk.org/patch/78630/
>
> Changes in v2:
> - Add support in DPAA1 driver (patch 2/3)
> - Add support and config parameter in testpmd (patch 3/3)
>
> lib/librte_ethdev/rte_ethdev.h | 1 +
> 1 file changed, 1 insertion(+)
Maybe this should be an rte_flow match/action which would then make it
more flexible?
There is not much of a performance gain for this in real life and
if only one driver supports it then I am not convinced this is needed.
next prev parent reply other threads:[~2020-10-05 15:35 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-31 7:53 [dpdk-dev] [PATCH] " Nipun Gupta
2020-08-31 12:58 ` Ferruh Yigit
2020-08-31 16:04 ` Nipun Gupta
2020-08-31 17:00 ` Stephen Hemminger
2020-09-01 8:09 ` Thomas Monjalon
2020-09-01 10:56 ` Nipun Gupta
2020-09-21 7:29 ` Ori Kam
2020-10-05 7:15 ` [dpdk-dev] [PATCH 1/3 v2] " nipun.gupta
2020-10-05 7:15 ` [dpdk-dev] [PATCH 2/3 v2] net/dpaa: support RX offload for error packet drop nipun.gupta
2020-10-05 7:15 ` [dpdk-dev] [PATCH 3/3 v2] testpmd: support hardware offload to drop error packets nipun.gupta
2020-10-08 15:06 ` Asaf Penso
2020-10-08 15:45 ` Nipun Gupta
2020-10-05 15:34 ` Stephen Hemminger [this message]
2020-10-05 16:10 ` [dpdk-dev] [PATCH 1/3 v2] ethdev: add rx " Jerin Jacob
2020-10-06 10:37 ` Nipun Gupta
2020-10-06 12:01 ` Jerin Jacob
2020-10-06 13:10 ` Nipun Gupta
2020-10-06 13:13 ` Jerin Jacob
2020-10-08 8:53 ` Nipun Gupta
2020-10-08 8:55 ` Jerin Jacob
2020-10-08 15:13 ` Asaf Penso
2020-10-09 13:13 ` [dpdk-dev] [PATCH 1/3 v3] " nipun.gupta
2020-10-09 13:13 ` [dpdk-dev] [PATCH 2/3 v3] net/dpaa: support RX offload for error packet drop nipun.gupta
2020-10-09 13:13 ` [dpdk-dev] [PATCH 3/3 v3] app/testpmd: support hardware offload to drop error packets nipun.gupta
2020-10-11 7:22 ` Asaf Penso
2020-10-11 10:13 ` [dpdk-dev] [PATCH 1/3 v3] ethdev: add rx " Jerin Jacob
2020-10-11 21:41 ` Thomas Monjalon
2020-10-12 5:40 ` Nipun Gupta
2020-10-13 7:22 ` Nipun Gupta
2020-10-12 8:01 ` Andrew Rybchenko
2020-10-12 11:30 ` Nipun Gupta
2020-10-12 12:22 ` Andrew Rybchenko
2020-10-12 12:53 ` Nipun Gupta
2020-10-13 7:21 ` Andrew Rybchenko
2020-10-13 7:36 ` Nipun Gupta
2020-10-13 7:51 ` Andrew Rybchenko
2020-10-13 8:12 ` Nipun Gupta
2020-10-15 13:23 ` [dpdk-dev] [PATCH 1/3 v4] ethdev: add Rx " nipun.gupta
2020-10-15 13:23 ` [dpdk-dev] [PATCH 2/3 v4] net/dpaa: support Rx offload for error packet drop nipun.gupta
2020-10-15 13:23 ` [dpdk-dev] [PATCH 3/3 v4] app/testpmd: support hardware offload to drop error packets nipun.gupta
2020-10-29 17:22 ` Dharmik Thakkar
2020-10-31 18:16 ` Nipun Gupta
2020-10-19 3:30 ` [dpdk-dev] [PATCH 1/3 v4] ethdev: add Rx " Ajit Khaparde
2021-02-18 20:32 ` Ferruh Yigit
2021-02-18 20:37 ` Thomas Monjalon
2021-04-20 1:11 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201005083455.2fdf57f2@hermes.local \
--to=stephen@networkplumber.org \
--cc=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=hemant.agrawal@nxp.com \
--cc=nipun.gupta@nxp.com \
--cc=rohit.raj@nxp.com \
--cc=sachin.saxena@nxp.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).